MantisBT - ParaView
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013525ParaView(No Category)public2012-10-16 14:332015-01-11 08:32
ReporterUtkarsh Ayachit 
Assigned ToUtkarsh Ayachit 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Versiongit-master 
Target VersionFixed in Version3.98.0 
ProjectKitware
Topic Name13525_fix_pipeline_updates
Typeincorrect functionality
Summary0013525: When playing animation, display lists are always discarded even if pipeline data didn't change with time.
Description* Create Sphere
* Step through animation.
By adding break points in debugger, we detect that the display lists are regenerated for each timestep, even in builtin mode. That's bad.

We can expect the data to be "forced" to be delivered in client-server mode since the client cannot be any more smart about whether the pipeline really executed, but it's not acceptable in builtin mode.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-10-16 14:33Utkarsh AyachitNew Issue
2012-10-16 14:33Utkarsh AyachitAssigned To => Utkarsh Ayachit
2012-10-16 14:41Utkarsh AyachitTopic Name => 13525_fix_pipeline_updates
2012-10-16 14:41Utkarsh AyachitNote Added: 0029396
2012-10-16 14:41Utkarsh AyachitStatusbacklog => gatekeeper review
2012-10-16 14:41Utkarsh AyachitFixed in Version => git-next
2012-10-16 14:41Utkarsh AyachitResolutionopen => fixed
2012-10-19 14:29Utkarsh AyachitFixed in Versiongit-next => git-master
2012-10-19 14:29Utkarsh AyachitStatusgatekeeper review => customer review
2012-10-19 14:29Utkarsh AyachitNote Added: 0029452
2012-10-29 17:04Utkarsh AyachitFixed in Versiongit-master => 3.98.0
2013-01-17 19:22Alan ScottNote Added: 0030182
2013-01-17 19:22Alan ScottStatuscustomer review => closed
2015-01-11 08:31Utkarsh AyachitSource_changeset_attached => ParaView master adf704ec
2015-01-11 08:32Utkarsh AyachitSource_changeset_attached => ParaView master 07671104

Notes
(0029396)
Utkarsh Ayachit   
2012-10-16 14:41   
commit 07671104c1ad1030e9e16b0b71f81529659906dc
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Tue Oct 16 14:35:31 2012 -0400

    Fixed BUG 0013525. Avoid rendering pipeline resets when playing animation.
    
    When playing animation, display lists are always discarded even if pipeline data
    didn't change with time. Although the geometry filter and the vtkPVCacheKeeper
    in vtkGeometryRepresentation didn't re-execute, the data was still treated as
    modified. This was due to the logic in vtkPVDataDeliveryManager::SetPiece(). The
    code was implemented to look at the DataTime provided by the pipeline. That was
    done so that we could detect the change in data object when representation type
    changes. However, the same can be done simply by comparing the data-object
    pointer. Doing that addresses this bug as well.
    
    Note however, in client-server mode, we still would force delivery for all
    representations when time changes irrespective of whether the data really
    changed.
    
    Change-Id: I1b41778a5e3fcfa041ff48860c5311245a5182a7
(0029452)
Utkarsh Ayachit   
2012-10-19 14:29   
merged into master, if applicable.
(0030182)
Alan Scott   
2013-01-17 19:22   
Trusting Utkarsh's running this in a debugger. It should be fine in remote server mode.