MantisBT - ParaView
View Issue Details
0013763ParaView(No Category)public2012-12-31 11:002013-05-18 20:00
Utkarsh Ayachit 
Utkarsh Ayachit 
normalminorhave not tried
closedfixed 
 
4.04.0 
Sandia
refactor_panels
incorrect functionality
0013763: Buggy spacing between widgets on properties panel
Create "Wavelet" and hit apply. Now start typing something the "search" box on the properties panel. As widgets get shown/hidden, the spacing between widgets doesn't always seem right.
New Panels
Issue History
2012-12-31 11:00Utkarsh AyachitNew Issue
2013-03-22 23:43Utkarsh AyachitAssigned To => Kyle Lutz
2013-03-22 23:45Utkarsh AyachitNote Added: 0030464
2013-03-22 23:45Utkarsh AyachitTarget Version => 4.0
2013-03-23 11:48Utkarsh AyachitNote Added: 0030468
2013-03-23 14:40Utkarsh AyachitTag Attached: New Panels
2013-04-03 06:43Utkarsh AyachitStatusbacklog => todo
2013-04-03 14:34Kyle LutzNote Added: 0030512
2013-04-03 14:34Kyle LutzStatustodo => active development
2013-04-22 17:20Utkarsh AyachitAssigned ToKyle Lutz => Utkarsh Ayachit
2013-04-22 17:21Utkarsh AyachitTopic Name => refactor_panels
2013-04-22 17:21Utkarsh AyachitNote Added: 0030592
2013-04-22 17:21Utkarsh AyachitStatusactive development => gatekeeper review
2013-04-22 17:21Utkarsh AyachitFixed in Version => git-next
2013-04-22 17:21Utkarsh AyachitResolutionopen => fixed
2013-04-25 09:22Utkarsh AyachitFixed in Versiongit-next => git-master
2013-04-25 09:24Utkarsh AyachitNote Added: 0030618
2013-04-25 09:24Utkarsh AyachitStatusgatekeeper review => customer review
2013-04-30 20:19Alan ScottNote Added: 0030651
2013-04-30 20:19Alan ScottStatuscustomer review => closed
2013-05-18 20:00Utkarsh AyachitFixed in Versiongit-master => 4.0

Notes
(0030464)
Utkarsh Ayachit   
2013-03-22 23:45   
The problem is spacing of 2 added to the DisplayLayout (in pqPropertiesPanel) and to the m_layout (in pqProxyProprtiesPanel).

When you hide an item, you need to remove it from the layout as well.
(0030468)
Utkarsh Ayachit   
2013-03-23 11:48   
The logic for controlling visibility of widgets in the panel needs some refactoring. It's easy to confuse the logic e.g.

Create sphere source, apply
change search text to 'line".
now in the toolbar, change the representation type to "Surface with edges" -- the panel erroneously updates and the widgets no longer match the search text.
(0030512)
Kyle Lutz   
2013-04-03 14:34   
That should now be fixed with: http://paraview.org/Bug/view.php?id=13990 [^]
(0030592)
Utkarsh Ayachit   
2013-04-22 17:21   
commit 17a9b733b119c44780fc10e153e0606e26101dd4
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Fri Apr 12 12:05:25 2013 -0400

    Refactoring Properties Panel (pqPropertiesPanel).
    
    This commit refactors pqPropertiesPanel for better usability and visual
    appearance. The changes can be summarized as follows:
    
    - Added a new class, pqProxyWidget, which creates the 'auto-generated' panel for
    any proxy. pqPropertiesPanel now uses this class to create the panels for
    source/display.
    
    - Property group were extended to add ability to group properties on non-exposed
    properties (as demonstrated by Wavelet source). The visual appearance of
    property groups was also changed. Also fixed leaks in ServerManager relating to
    groups and new property attributes that were added in past for the panels.
    
    - pqPropertyWidgetDecorator was added to provide a mechanism to add custom logic
    to widgets which having to create new widget types. pqPropertyWidgetDecorator
    can be used to control widget visibility, for example.
    
    - Converted custom panels for for several filters to be non-custom i.e. simply
    be auto-generated.
    
    - Added mechanism for plugins to provide new pqPropertyWidget types for
    properties, property groups or new pqPropertyWidgetDecorator types. Added an
    example under Examples that demonstrates the use of the same.
    
    - Added infrastructure to print debug messages when certain environment
    variables are set (pqDebug).
    
    - Removing obsolete SummaryPanel elements.
    
    - Updated tests to work with these changes.
    
    Change-Id: I49e82525ba666380b265a7f2075207dc2cd6f452
(0030618)
Utkarsh Ayachit   
2013-04-25 09:24   
SUMMARY
---------------------------------------------
Topics merged into master:
        13450_update_tests_to_use_new_panels
(VTK) 14023-plot3d-function-support
        14026_catalyst_python_warning
        14032_fix_CoProcessingTestInput
        fix_protobuf_try_compiles
        pvw-python-refactoring
        pvw-remove-example
        refactor_panels
(VTK) update_vtk_master
        zoom-to-data-icon
        fix_cmake_2.8.10_plugins_issue
(0030651)
Alan Scott   
2013-04-30 20:19   
Tested remote server, master, Linux.