MantisBT - ParaView
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013965ParaView(No Category)public2013-03-23 02:302015-01-11 08:26
ReporterUtkarsh Ayachit 
Assigned ToUtkarsh Ayachit 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version4.0 
ProjectTBD
Topic Namemisc_panel_fixes
Typeincorrect functionality
Summary0013965: Miscellaneous property panel issues
Description(a) Properties being pushed prematurely:

Attempt to change the opacity while typing, the values get updated as the user is typing. That's very bad as incorrect values can get pushed and also repeated renders can have performance issues.

(b) "Apply" button goes green too frequently.

Create Sphere source. Hit apply. Now click in "Center" property's 0th element. Hit tab without changing any value for a few times. Apply button will go green. It should not. Nothing has changed.

(c) Large values show least insignificant digits.

Create Sphere. Start typing 0.0012323234343 etc. for Center[0], the widget scrolls. Hit tab. Now the value you see some random digits. We should reposition the cursor to the beginning.

(d) Apply button doesn't go green fast enough.

Create Sphere. Hit Apply. Start typing something in "Radius". Apply button doesn't go green until the focus is lost and one hits "Enter".

Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-03-23 02:30Utkarsh AyachitNew Issue
2013-03-23 02:33Utkarsh AyachitDescription Updatedbug_revision_view_page.php?rev_id=573#r573
2013-03-23 02:41Utkarsh AyachitTopic Name => misc_panel_fixes
2013-03-23 02:41Utkarsh AyachitNote Added: 0030467
2013-03-23 02:41Utkarsh AyachitStatusbacklog => gatekeeper review
2013-03-23 02:41Utkarsh AyachitFixed in Version => git-next
2013-03-23 02:41Utkarsh AyachitResolutionopen => fixed
2013-03-23 02:41Utkarsh AyachitAssigned To => Utkarsh Ayachit
2013-03-24 11:21Utkarsh AyachitFixed in Versiongit-next => git-master
2013-03-24 11:21Utkarsh AyachitStatusgatekeeper review => customer review
2013-03-24 11:21Utkarsh AyachitNote Added: 0030471
2013-04-02 18:55Alan ScottNote Added: 0030495
2013-04-02 18:55Alan ScottStatuscustomer review => closed
2013-05-18 20:00Utkarsh AyachitFixed in Versiongit-master => 4.0
2015-01-11 08:26Utkarsh AyachitSource_changeset_attached => ParaView master 11c2fae9
2015-01-11 08:26Utkarsh AyachitSource_changeset_attached => ParaView master 146a6fae

Notes
(0030467)
Utkarsh Ayachit   
2013-03-23 02:41   
commit 146a6fae43ddaea042a465cdf7c7439ded0bbefd
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Sat Mar 23 02:31:58 2013 -0400

    BUG 0013965. Fixes plethora of panel usability issues.
    
    pqPropertyWidget now fires two signals: changeAvailable() and changeFinished().
    pqPropertiesPanel uses changeAvailable() to mark Apply button green, while
    changeFinished() to call Apply (if auto-apply is ON) or push the value (for
    Display properties). Updated all pqPropertyWidget subclasses to respect this new
    protocol. This provides a clean distinction between when widgets say something
    is being changed/edited and something has been completely edited and ready to be
    processed.
    
    Using pqLineEdit instead of QLineEdit whereever relevant. Since pqLineEdit
    provides a textChangedAndEditingFinished() signal that can be used instead of
    editingFinished(), we can fire changeFinished() signals more reliable (not
    firing unless value was edited by the user) thus avoiding the bogus "Apply" bug.
    
    pqLineEdit also ensures that the most significant digits are always shown.
    
    Change-Id: I0ca10d56577d799791f29ecd7b4fe326064063a9
(0030471)
Utkarsh Ayachit   
2013-03-24 11:21   
SUMMARY
---------------------------------------------
Topics merged into master:
        add_stereo_type_to_pvx
(VTK) bgp_xlc_fixes
        fix_structured_volume_rendering
        misc_panel_fixes
(0030495)
Alan Scott   
2013-04-02 18:55   
Looks good. Tested Linux, master, local server.