View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0013833ParaView(No Category)public2013-01-29 19:212016-08-12 09:59
ReporterAlan Scott 
Assigned ToKitware Robot 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionmoved 
PlatformOSOS Version
Product Versiongit-master 
Target VersionFixed in Version 
Summary0013833: ProgressHandler - spyPlotReader is broken
DescriptionProgress handler code in the spyplot (CTH) reader is broken. In files vtkSpyPlotReader.cxx and vtkSpyPlotBlockIterator.cxx, the calls to UpdateProgress do not coordinate with each other. This means that progress goes from 0.0 to 0.2, then from 0.04 to 0.4, then from 0.6 to 1.0. This is obviously incorrect.

Another related bug, in the same code, is that for multiple servers, the code counts wrong. In the following code:
 this->Parent->UpdateProgress(0.2 * (file_index+1.0)/numFiles);

numFiles is the number of files handled by this process, and file_index is the file number that all processes are handling. For instance, if the second pvserver is handling 4 files, numFiles will == 4, and file_index will go 5,6,7 and then 8. This gives a progress that is over 1.0 (and is illegal).


Suggested correction (just fixing the file_index issue) would be:

vtkSpyPlotBlockIterator.cxx, line 227, should be:
      this->Parent->UpdateProgress(0.2 * (file_index+1.0)/numFiles);
to
      this->Parent->UpdateProgress(0.2 * (file_index-this->FileStart+1.0)/ numFiles);

Be sure to check the rest of the two SpyPlot reader files for the same bug.
TagsNo tags attached.
ProjectSandia
Topic Name
Typeincorrect functionality
Attached Files

 Relationships
child of 0013831closedKitware Robot Master bug - Progress Handler is a mess 

  Notes
(0030324)
Alan Scott (manager)
2013-02-07 16:11

 I believe I forgot to say how to replicate this. I believe it was with Dave's medium CTH dataset, 8 cores. Basically, the number of files must be higher than the number of cores.
(0038324)
Kitware Robot (administrator)
2016-08-12 09:59

 Resolving issue as `moved`.

This issue tracker is no longer used. Further discussion of this issue may take place in the current ParaView Issues page linked in the banner at the top of this page.

 Issue History
Date Modified Username Field Change
2013-01-29 19:21 Alan Scott New Issue
2013-01-29 21:49 Alan Scott Relationship added child of 0013831
2013-02-07 16:11 Alan Scott Note Added: 0030324
2016-08-12 09:59 Kitware Robot Note Added: 0038324
2016-08-12 09:59 Kitware Robot Status backlog => closed
2016-08-12 09:59 Kitware Robot Resolution open => moved
2016-08-12 09:59 Kitware Robot Assigned To => Kitware Robot

Copyright © 2000 - 2018 MantisBT Team