View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0014580ParaView(No Category)public2014-02-17 11:122014-08-29 11:00
ReporterUtkarsh Ayachit 
Assigned ToSankhesh Jhaveri 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Versiongit-master 
Target Version4.2Fixed in Version4.2 
Summary0014580: Charts Panel: Series Parameters list doesn't have a top-level check box.
DescriptionOne the table/tree widget showing the series for charts, there's no checkbox in the header to allow user to quickly toggle the state for all items.
TagsNo tags attached.
ProjectSandia
Topic Name14580-top-level-checkbox
Typeincorrect functionality
Attached Files

 Relationships

  Notes
(0032341)
Utkarsh Ayachit (administrator)
2014-02-17 11:15

Developer Note:

Currently, it seems we have different mechanisms for dealing with checkbox in the header, separately for QTableView, QTableWidget, QTreeView and QTreeWidget. I wonder is there's a generic way of addressing all these.

I am thinking we could subclass QHeaderView to "paint" the checkbox and handle clicks on it to consistently set/get the state for all the top-level items from the QAbstractItemModel without having to rely on what type of view/model it actually is.

Beware of the click handler interacting with header clicks for sorting, since in some cases sorting will be enabled.
(0032484)
Sankhesh Jhaveri (developer)
2014-03-18 15:35

commit 329d97736536aa880b27f1222b8c8e657c25ab56
Author: Sankhesh Jhaveri <sankhesh.jhaveri@kitware.com>
Date: Mon Mar 17 11:29:50 2014 -0400

    Threshold for checkableheader test

    Change-Id: Ib6da087354a1da0d55e9a57eb4aca751b28b76ec

commit 9347b60f736a844fc934420ac012403f25705567
Author: Sankhesh Jhaveri <sankhesh.jhaveri@kitware.com>
Date: Wed Mar 5 13:38:14 2014 -0500

    ENH: Paint checkbox in QHeaderView

    Added new class that derives from QHeaderView and paints a checkbox on the
    section header if the individual model items are checkable.
    Currently the class is used in pqTreeView and needs to be standardized acros
    all views and widgets.
    Removed old unused pqCheckableHeaderView and pqCheckableHeaderModel classes.
    This fixes issue 14580.

    Change-Id: Ib9f45794340823819eb3f59dba23461dead53f79
(0032491)
Utkarsh Ayachit (administrator)
2014-03-20 08:32

Topics merged in master
(VTK) 14258-remote-polyhedra
        14580-top-level-checkbox
        14584-frequency-live-view
(VTK) 14614-report-numpy
(VTK) 14615-volume-rendering-tet-crash
        animation-movie-compressor-support
(VTK) catalyst-web-interactive-composite
        data_template_redefine
(VTK) enable_subclassing_vtkControlPointsItems
        ensemble-reader
        expand_fragment_integration
        fix-variable-referece
        fix_qt5_dashboard_failures
(VTK) probe_enhancements
        sciberquest-test-timeout
(0032532)
Sankhesh Jhaveri (developer)
2014-03-24 12:53

commit 2a3fcf5c171e9d82a204490264c674205f3751ee
Author: Sankhesh Jhaveri <sankhesh.jhaveri@kitware.com>
Date: Mon Mar 24 12:06:05 2014 -0400

    ENH: Logic to set correct size of checkbox for QCheckableHeaderView
    
    This change fixes issue with size of checkbox on the Macintosh platform where
    the section header is of a much smaller height.
    
    Change-Id: I7a1260f39514167567a8b947c2ce1367ea309329

 Qt/Widgets/pqCheckableHeaderView.cxx | 120 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------
 Qt/Widgets/pqCheckableHeaderView.h | 67 ++++++++++++++++++++++++++-------------------
 2 files changed, 128 insertions(+), 59 deletions(-)
(0032538)
Utkarsh Ayachit (administrator)
2014-03-28 11:55

---------------------------------------------
Topics merged into master:
        14557-color-legend-update
        14580-top-level-checkbox
(VTK) 14615-fix-mpi-segfault
        14650_check_bounds
        catalyst-web
        delaunay3d-alpha-bools
        fix_qt5_dashboard_failures
        pvweb-doc-update
(VTK) vtk_02_20_2014
        14632-find-data-query-combobo
(0032556)
Alan Scott (manager)
2014-04-08 19:10

Developer tag in git. Closing.

 Issue History
Date Modified Username Field Change
2014-02-17 11:12 Utkarsh Ayachit New Issue
2014-02-17 11:12 Utkarsh Ayachit Assigned To => Sankhesh Jhaveri
2014-02-17 11:15 Utkarsh Ayachit Note Added: 0032341
2014-02-17 11:18 Utkarsh Ayachit Status backlog => todo
2014-03-18 15:35 Sankhesh Jhaveri Topic Name => 14580-top-level-checkbox
2014-03-18 15:35 Sankhesh Jhaveri Note Added: 0032484
2014-03-18 15:35 Sankhesh Jhaveri Status todo => gatekeeper review
2014-03-18 15:35 Sankhesh Jhaveri Resolution open => fixed
2014-03-20 08:31 Utkarsh Ayachit Fixed in Version => git-master
2014-03-20 08:32 Utkarsh Ayachit Status gatekeeper review => customer review
2014-03-20 08:32 Utkarsh Ayachit Note Added: 0032491
2014-03-24 12:53 Sankhesh Jhaveri Note Added: 0032532
2014-03-24 12:53 Sankhesh Jhaveri Status customer review => gatekeeper review
2014-03-28 11:55 Utkarsh Ayachit Status gatekeeper review => customer review
2014-03-28 11:55 Utkarsh Ayachit Note Added: 0032538
2014-04-08 19:10 Alan Scott Note Added: 0032556
2014-04-08 19:10 Alan Scott Status customer review => closed
2014-06-17 09:22 Utkarsh Ayachit Target Version => 4.2
2014-08-29 11:00 Utkarsh Ayachit Fixed in Version git-master => 4.2


Copyright © 2000 - 2018 MantisBT Team