(0008457)
Mark Richardson (reporter)
2007-08-14 13:49

The new chart options dialog allows the user to turn log scale on and off. I need to fix a bug when turning the log scale on when the range is not valid. The chart reports a warning, but then tries to draw the tick marks in log scale.

(0008471)
Mark Richardson (reporter)
2007-08-15 14:15

I finished cleaning up the chart log scale functionality. If the range is not valid for log scale, the chart will revert to linear scale, while preserving the log scale flag.

(0008598)
Ken Moreland (manager)
2007-08-23 09:18

Is it possible to gray out the checkbox when the range is invalid for log scale? I know that is not 100% reliable since the range can change on an update, but it will make the interface much more usable most of the time.

(0008714)
Ken Moreland (manager)
2007-08-28 13:37

It was brought up at the meeting that we really should just mimic what is done for the log scale in the color map dialog box where the range is adjusted to a range valid for log scale but still (probably) gives useful information.

(0009567)
Mark Richardson (reporter)
2007-10-25 16:33

As a temporary fix for 3.2, I removed the chart log scale warning message. I also added "When Available" to the chart log scale option.

(0011240)
Berk Geveci (administrator)
2008-04-09 20:57

Reminder sent to: Ken Moreland

What is the with this bug?

(0011275)
Ken Moreland (manager)
2008-04-14 11:28

The current functionality is still not sufficient. The problem is that when log scaling is invalid, the chart silently does nothing. Even though ParaView is behaving as designed, it appears as if there is a bug. Something more proactive should happen when log scaling is used with invalid ranges. Here are some suggestions.

1. Remove the log scaling option when it is invalid. Gray out the option in the view settings dialog box to both prevent the user from using the option and alert them that the option is not viable.

2. Silently adjust the range to something valid. This, of course, can go horribly wrong (as I have notice it frequently doing when selecting log scalar mapping). I think Excel picks the smallest value greater than 0 to use as the lower range, but I'm not sure that will work well in ParaView.

3. Give an error message alerting the user to the invalid range with instructions on how to fix it and then turn off log range. This could be either a dialog box or in the output window. Either is fine by me, but if the output window is used, the message should still be clear and easy for an end user to read (no file/line #/class information obfuscating the message).

4. While an invalid log scaling is selected, replace the chart in the plot view with a message describing the error and what to do about it.

I used to be an advocate of either option 1 or 2. However, no I'm not sure they are good ideas anymore. I understand that both are harder to implement and they both have fairly common cases where they break down. Option 1 breaks down if you select a valid log range and then a change in data causes the range to become invalid. Option 2 breaks down because it becomes impossible to predict exactly what a good range would be. Now I advocate doing either option 3 or 4, whichever is easier.

(0011280)
Mark Richardson (reporter)
2008-04-14 13:09
edited on: 2008-04-15 13:11

I think option 3 will be the easiest to implement. I had something like it before, but there were complaints about it popping up the message too often. I meant to limit the message to any time the range changes or the log scale was just turned on.

(0011343)
Mark Richardson (reporter)
2008-04-15 13:16

The axis layout pops up a warning if the log scale range is invalid. It should only pop up when the log scale option is on and the range is changed or the log scale was just turned on. Let me know if it pops up too often.

(0011459)
Alan Scott (manager)
2008-04-21 13:04

Looks correct to me. Tested client/server.

Issue History
Date Modified	Username	Field	Change
2007-08-14 13:49	Mark Richardson	Note Added: 0008457
2007-08-15 14:15	Mark Richardson	Status	tabled => @80@
2007-08-15 14:15	Mark Richardson	Resolution	open => fixed
2007-08-15 14:15	Mark Richardson	Note Added: 0008471
2007-08-23 09:18	Ken Moreland	Note Added: 0008598
2007-08-28 13:37	Ken Moreland	Status	@80@ => @20@
2007-08-28 13:37	Ken Moreland	Resolution	fixed => reopened
2007-08-28 13:37	Ken Moreland	Note Added: 0008714
2007-08-29 15:06	Ken Moreland	Priority	normal => high
2007-08-29 15:06	Ken Moreland	Category	=> 3.2
2007-10-25 16:33	Mark Richardson	Note Added: 0009567
2008-04-09 20:57	Berk Geveci	Note Added: 0011240
2008-04-14 11:28	Ken Moreland	Note Added: 0011275
2008-04-14 13:09	Mark Richardson	Note Added: 0011280
2008-04-15 13:11	Mark Richardson	Note Edited: 0011280
2008-04-15 13:16	Mark Richardson	Status	@20@ => @80@
2008-04-15 13:16	Mark Richardson	Resolution	reopened => fixed
2008-04-15 13:16	Mark Richardson	Note Added: 0011343
2008-04-21 13:04	Alan Scott	Status	@80@ => closed
2008-04-21 13:04	Alan Scott	Note Added: 0011459
2011-06-16 13:10	Zack Galbreath	Category	=> (No Category)

Notes
(0008457) Mark Richardson (reporter) 2007-08-14 13:49	The new chart options dialog allows the user to turn log scale on and off. I need to fix a bug when turning the log scale on when the range is not valid. The chart reports a warning, but then tries to draw the tick marks in log scale.

(0008471) Mark Richardson (reporter) 2007-08-15 14:15	I finished cleaning up the chart log scale functionality. If the range is not valid for log scale, the chart will revert to linear scale, while preserving the log scale flag.

(0008598) Ken Moreland (manager) 2007-08-23 09:18	Is it possible to gray out the checkbox when the range is invalid for log scale? I know that is not 100% reliable since the range can change on an update, but it will make the interface much more usable most of the time.

(0008714) Ken Moreland (manager) 2007-08-28 13:37	It was brought up at the meeting that we really should just mimic what is done for the log scale in the color map dialog box where the range is adjusted to a range valid for log scale but still (probably) gives useful information.

(0009567) Mark Richardson (reporter) 2007-10-25 16:33	As a temporary fix for 3.2, I removed the chart log scale warning message. I also added "When Available" to the chart log scale option.

(0011240) Berk Geveci (administrator) 2008-04-09 20:57	Reminder sent to: Ken Moreland What is the with this bug?

(0011275) Ken Moreland (manager) 2008-04-14 11:28	The current functionality is still not sufficient. The problem is that when log scaling is invalid, the chart silently does nothing. Even though ParaView is behaving as designed, it appears as if there is a bug. Something more proactive should happen when log scaling is used with invalid ranges. Here are some suggestions. 1. Remove the log scaling option when it is invalid. Gray out the option in the view settings dialog box to both prevent the user from using the option and alert them that the option is not viable. 2. Silently adjust the range to something valid. This, of course, can go horribly wrong (as I have notice it frequently doing when selecting log scalar mapping). I think Excel picks the smallest value greater than 0 to use as the lower range, but I'm not sure that will work well in ParaView. 3. Give an error message alerting the user to the invalid range with instructions on how to fix it and then turn off log range. This could be either a dialog box or in the output window. Either is fine by me, but if the output window is used, the message should still be clear and easy for an end user to read (no file/line #/class information obfuscating the message). 4. While an invalid log scaling is selected, replace the chart in the plot view with a message describing the error and what to do about it. I used to be an advocate of either option 1 or 2. However, no I'm not sure they are good ideas anymore. I understand that both are harder to implement and they both have fairly common cases where they break down. Option 1 breaks down if you select a valid log range and then a change in data causes the range to become invalid. Option 2 breaks down because it becomes impossible to predict exactly what a good range would be. Now I advocate doing either option 3 or 4, whichever is easier.

(0011280) Mark Richardson (reporter) 2008-04-14 13:09 edited on: 2008-04-15 13:11	I think option 3 will be the easiest to implement. I had something like it before, but there were complaints about it popping up the message too often. I meant to limit the message to any time the range changes or the log scale was just turned on.

(0011343) Mark Richardson (reporter) 2008-04-15 13:16	The axis layout pops up a warning if the log scale range is invalid. It should only pop up when the log scale option is on and the range is changed or the log scale was just turned on. Let me know if it pops up too often.

(0011459) Alan Scott (manager) 2008-04-21 13:04	Looks correct to me. Tested client/server.

Relationships