Robert,<br><br>On further consideration, I've decided to go with your patch. I've committed it to CVS (slightly modified to remove the signal changes).<br>Attached is a patch for the final version that made it in.<br>
<br>Utkarsh<br><br><div class="gmail_quote">On Tue, May 5, 2009 at 3:28 PM, Utkarsh Ayachit <span dir="ltr"><<a href="mailto:utkarsh.ayachit@kitware.com">utkarsh.ayachit@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Robert,<br><br>What your patch is doing is exactly what I've done, except at the server manager level (so in vtkSMScalarBarRepresentationProxy instead of pqScalarBarRepresentation). I guess I am going to mark bug #8958 resolved, unless someone tells me otherwise :).<br>
<font color="#888888">
<br>Utkarsh</font><div><div></div><div class="h5"><br><br><div class="gmail_quote">On Tue, May 5, 2009 at 3:14 PM, Dominik Szczerba <span dir="ltr"><<a href="mailto:dominik@itis.ethz.ch" target="_blank">dominik@itis.ethz.ch</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
I know what the reason is.<br>
I have originally submitted the bug under 'Paraview' project, then realizing that the last posts before were the previous year, and in addition seeing also project 'Paraview3', I concluded that the former must be referring to 2.x branch or so - and I resubmitted to the latter, where also the earlier posts were just days before.<br>
To some extent I may be called guilty, but the 2 actual Paraview projects are very confusing.<br>
Many thanks - and sorry. I only hope you two can agree on a better solution. I can test whatever you conclude with.<br>
thanks and regards,<br><font color="#888888">
Dominik</font><div><div></div><div><br>
<br>
Robert Maynard wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Odly enough I just finished fixing this bug today, with a patch for the visibility issue at <a href="http://www.vtk.org/Bug/view.php?id=8958" target="_blank">http://www.vtk.org/Bug/view.php?id=8958</a><br>
<br>
The locking bug it self can be fixed by simply changing one line.<br>
<br>
Index: C:/Work/ParaViewGeo/VTK/Widgets/vtkBorderWidget.cxx<br>
===================================================================<br>
--- C:/Work/ParaViewGeo/VTK/Widgets/vtkBorderWidget.cxx (revision 3953)<br>
+++ C:/Work/ParaViewGeo/VTK/Widgets/vtkBorderWidget.cxx (revision 3954)<br>
@@ -275,7 +275,9 @@<br>
reinterpret_cast<vtkBorderRepresentation*>(self->WidgetRep)->MovingOff();<br>
<br>
// stop adjusting<br>
- self->EventCallbackCommand->SetAbortFlag(1);<br>
+ //by setting the abort flag to 0 we allow the end interaction event to be<br>
+ //caught be other observers so that mouse buttons don't get stuck being down.<br>
+ self->EventCallbackCommand->SetAbortFlag(0);<br>
self->EndInteraction();<br>
self->InvokeEvent(vtkCommand::EndInteractionEvent,NULL);<br>
}<br>
<br>
Dominik Szczerba wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Many thanks for such a quick reaction!<br>
I will give it a try next week.<br>
regards,<br>
Dominik<br>
<br>
Utkarsh Ayachit wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Dominik,<br>
I just committed a fix for this issue. Feel free to give it a try and let me know if it still doesn't work.<br>
<br>
Thanks,<br>
Utkarsh<br>
<br>
/cvsroot/ParaView3/ParaView3/Qt/Core/pqScalarBarRepresentation.cxx,v <-- Qt/Core/pqScalarBarRepresentation.cxx<br>
new revision: 1.11; previous revision: 1.10<br>
/cvsroot/ParaView3/ParaView3/Servers/ServerManager/Resources/rendering.xml,v <-- Servers/ServerManager/Resources/rendering.xml<br>
new revision: 1.345; previous revision: 1.344<br>
/cvsroot/ParaView3/ParaView3/Servers/ServerManager/vtkSMScalarBarWidgetRepresentationProxy.cxx,v <-- Servers/ServerManager/vtkSMScalarBarWidgetRepresentationProxy.cxx<br>
new revision: 1.10; previous revision: 1.9<br>
/cvsroot/ParaView3/ParaView3/Servers/ServerManager/vtkSMScalarBarWidgetRepresentationProxy.h,v <-- Servers/ServerManager/vtkSMScalarBarWidgetRepresentationProxy.h<br>
new revision: 1.6; previous revision: 1.5<br>
<br>
<br>
On Wed, Apr 15, 2009 at 1:49 PM, Dominik Szczerba <<a href="mailto:dominik@itis.ethz.ch" target="_blank">dominik@itis.ethz.ch</a> <mailto:<a href="mailto:dominik@itis.ethz.ch" target="_blank">dominik@itis.ethz.ch</a>>> wrote:<br>
<br>
-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA1<br>
<br>
Even simpler way to reproduce:<br>
<br>
just move the (sliced) dataset with MMB onto the visible colorbar: a<br>
lock results for me. Invisible datasets hide their colorbars, but they<br>
are somehow still there, locking the navigation: a clear bug, at least<br>
on my system.<br>
<br>
- - Dominik<br>
<br>
Dominik Szczerba wrote:<br>
> No, it does not have to do with the mouse outside the render window.<br>
> This is a bug with colorbar. To reproduce:<br>
><br>
> Load a dataset, slice it, color it with a scalar, display the<br>
colorbar.<br>
> Load another dataset, slice it, color it.<br>
> Now hide the first slice (unclick the eye).<br>
> The color legend is gone, but stays there hidden, faking the<br>
mouse. Move<br>
> the cursor to see false mouse-over effects. This now often results in<br>
> the mentioned "locking" while dragging with the middle button. It<br>
is the<br>
> invisible colorbar that gets moved instead of the dataset and<br>
the whole<br>
> thing gets eventually stuck. It is extremely annoying, if not<br>
impossible<br>
> in case of complex pipeline states, to go through all entries and<br>
switch<br>
> off the colorbars. Is it possible to fix this?<br>
><br>
> - Dominik<br>
><br>
> Utkarsh Ayachit wrote:<br>
>> That generally happens when you start dragging but move the<br>
mouse out<br>
>> of the renderwindow before releasing the mouse button. Is that<br>
indeed<br>
>> the case?<br>
><br>
>> Utkarsh<br>
><br>
>> On Tue, Apr 14, 2009 at 6:19 AM, Dominik Szczerba<br>
<<a href="mailto:dominik@itis.ethz.ch" target="_blank">dominik@itis.ethz.ch</a> <mailto:<a href="mailto:dominik@itis.ethz.ch" target="_blank">dominik@itis.ethz.ch</a>>> wrote:<br>
>> Hi,<br>
>> I am getting annoying critical problems when moving datasets<br>
(here, a<br>
>> result of cutting tool): the dataset keeps moving even after I<br>
release<br>
>> the middle mouse button and I have to click around blind like<br>
crazy to<br>
>> "unlock" it. I see the following in the output window:<br>
><br>
>> endUndoSet called without a beginUndoSet.<br>
>> endUndoSet called without a beginUndoSet.<br>
>> endUndoSet called without a beginUndoSet.<br>
>> endUndoSet called without a beginUndoSet.<br>
>> endUndoSet called without a beginUndoSet.<br>
>> endUndoSet called without a beginUndoSet.<br>
>> endUndoSet called without a beginUndoSet.<br>
>> endUndoSet called without a beginUndoSet.<br>
><br>
>> Can someone please advise how to fix it?<br>
><br>
>> regards,<br>
>> Dominik<br>
> _______________________________________________<br>
> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a> <<a href="http://www.kitware.com" target="_blank">http://www.kitware.com</a>><br>
> Visit other Kitware open-source projects at<br>
> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
> Please keep messages on-topic and check the ParaView Wiki at:<br>
> <a href="http://paraview.org/Wiki/ParaView" target="_blank">http://paraview.org/Wiki/ParaView</a><br>
> Follow this link to subscribe/unsubscribe:<br>
> <a href="http://www.paraview.org/mailman/listinfo/paraview" target="_blank">http://www.paraview.org/mailman/listinfo/paraview</a><br>
><br>
<br>
- --<br>
Dominik Szczerba, PhD<br>
Computational Physics Group<br>
IT'IS Foundation for Research<br>
<a href="http://www.itis.ethz.ch" target="_blank">www.itis.ethz.ch</a> <<a href="http://www.itis.ethz.ch" target="_blank">http://www.itis.ethz.ch</a>><br>
-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v2.0.9 (GNU/Linux)<br>
Comment: Using GnuPG with SUSE - <a href="http://enigmail.mozdev.org" target="_blank">http://enigmail.mozdev.org</a><br>
<br>
iEYEARECAAYFAknmHiYACgkQ/EBMh9bUuzJwwQCfZSHSpQ99zTAxS6tiIYAhZyvm<br>
DqgAoKFZHkNGdmIro+9P4Zel4P/U7eC4<br>
=d9xA<br>
-----END PGP SIGNATURE-----<br>
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br></div></div>
-- <br><div>
Dominik Szczerba, PhD<br>
Computational Physics Group<br>
IT'IS Foundation<br>
</div><div><div></div><div><a href="http://www.itis.ethz.ch" target="_blank">http://www.itis.ethz.ch</a><br>
</div></div></blockquote></div><br>
</div></div></blockquote></div><br>