<HTML>
<HEAD>
<TITLE>Re: [Paraview] Problem with custom time-aware reader</TITLE>
</HEAD>
<BODY>
<FONT FACE="Calibri, Verdana, Helvetica, Arial"><SPAN STYLE='font-size:11pt'>I don’t know why you are getting the FooReader warning. It sounds like an object named FooReader is being defined twice in the server manager XML, but I don’t know where.<BR>
<BR>
The calling of RequestInformation is a little tricky to explain. In general, RequestInformation should <I>not</I> be called when the time changes. However, when the time changes, the file series reader changes the filename to the internal reader (in this case, the foo reader). The correct behavior for the pipeline is to re-call RequestInformation if the the algorithm object gets modified (e.g. an ivar like FileName changes). Thus, if the time changes then the file series reader will call RequestInformation on the foo reader from within the RequestData pipeline pass. I would not be surprised if this was the same behavior in both the GUI and Python. It might just be that the progress monitoring is slightly different.<BR>
<BR>
-Ken<BR>
<BR>
<BR>
On 9/6/09 3:24 PM, "Karl König" <<a href="kkoenig11@web.de">kkoenig11@web.de</a>> wrote:<BR>
<BR>
</SPAN></FONT><BLOCKQUOTE><FONT FACE="Calibri, Verdana, Helvetica, Arial"><SPAN STYLE='font-size:11pt'>Hi Ken,<BR>
<BR>
Thank you very much for taking the time to look into my problem again.<BR>
As a matter of fact I had worked out a solution using its own<BR>
bookkeeping of files by means of a "vtkStringArray *FileNames".<BR>
But you are right, your solution is minimal and avoids re-implementing<BR>
features already provided by<BR>
ParaView3/Servers/Filters/vtkFileSeriesReader.cxx, features I haven't<BR>
been aware of because I simply followed the instructions to use the<BR>
class without actually studying it.<BR>
<BR>
I hope you don't mind that I still have a few questions about the<BR>
prototypical time-aware reader FooReader for files series with one time<BR>
step value per file and no meta file.<BR>
<BR>
1) I opened the file series file*.foo from the tarball attached to my<BR>
initial posting and opened the Python shell from within ParaView 3.6.1<BR>
(having successfully loaded the plugin by setting PV_PLUGIN_PATH). I get<BR>
a warning I cannot make any sense of:<BR>
<BR>
Python 2.5.2 (r252:60911, Jan 4 2009, 18:00:02)<BR>
[GCC 4.3.2] on linux2<BR>
>>> from paraview.simple import *<BR>
Warning: FooReader is being overwritten. This may point to an issue in<BR>
the ParaView configuration files<BR>
>>><BR>
<BR>
Deleting ~/.config/ParaView/ParaView3.6.ini does not remove the warning.<BR>
I wonder what's wrong with this reader plugin as for the other reader<BR>
plugin that comes with ParaView 3.6.1, the VisIt Reader, there is no<BR>
such warning.<BR>
I get the same message for a cvs build (paraview version 3.7.0, Date:<BR>
2009-09-05).<BR>
<BR>
2) Despite the warning, using the reader works from Python<BR>
>>> view = GetActiveView(); view.ViewTime;<BR>
0.0<BR>
>>> reader = GetActiveSource(); reader.TimestepValues<BR>
[0.0, 0.10000000000000001, 0.20000000000000001, 0.29999999999999999,<BR>
0.40000000000000002, 0.5, 0.59999999999999998, 0.69999999999999996,<BR>
0.80000000000000004, 0.90000000000000002]<BR>
>>> view.ViewTime = -1.2; Render()<BR>
=> on standard output I can see that RequestData is invoked and the<BR>
first file, file0.foo, is loaded, i.e. clamping provided by<BR>
FileSeriesReader works for FooReader. Same for snapping to files for<BR>
non-existent time step values works:<BR>
>>> view.ViewTime = 0.19; Render()<BR>
=> second file, file1.foo, is loaded.<BR>
<BR>
But I noticed from the standard output that only RequestData is called.<BR>
When using the VCR controls from the GUI to step to the next file,<BR>
ParaView behaves differently: first RequestInformation is called, then<BR>
RequestData, then again RequestInformation. If both RequestInformation<BR>
and RequestData contained a call to MyReadFile, that would be three<BR>
times parsing the same file.<BR>
a) Could someone please elaborate on the need to calling<BR>
RequestInformation twice?<BR>
b) Would I run into trouble (e.g. when using some kind of filter) if I<BR>
kept book of the file read last and skipping RequestInformation if<BR>
this->FileName hasn't changed since called last time? That would<BR>
eliminate the overhead of the trailing RequestInformation call.<BR>
c) Would I run into trouble if I kept book of all files read initially<BR>
(i.e. after pressing ok in the open file dialog) and completely skipped<BR>
later calls of RequestInformation, e.g. via<BR>
<BR>
int vtkFooReader::RequestInformation(vtkInformation *request,<BR>
vtkInformationVector **inputVector, vtkInformationVector *outputVector)<BR>
{<BR>
if (this->FileNames->LookupValue(this->FileName) < 0)<BR>
{<BR>
...<BR>
this->FileNames->InsertNextValue(this->FileName);<BR>
...<BR>
}<BR>
return 1;<BR>
}<BR>
<BR>
I tried b) and c) and applying a couple of filters I did not notice any<BR>
unwanted side effects. I couldn't test all of them, so did I miss a<BR>
combination where skipping RequestInformation before and after calling<BR>
RequestData - but still having run RequestInformation once for all files<BR>
initially - does make a difference?<BR>
<BR>
Thank you very much in advance.<BR>
<BR>
Karl<BR>
<BR>
<BR>
<BR>
<BR>
----- Original Message -----<BR>
From: "Moreland, Kenneth" <<a href="kmorel@sandia.gov">kmorel@sandia.gov</a>><BR>
To: Karl König <<a href="kkoenig11@web.de">kkoenig11@web.de</a>><BR>
CC: "<a href="paraview@paraview.org">paraview@paraview.org</a>" <<a href="paraview@paraview.org">paraview@paraview.org</a>><BR>
Sent: Sonntag, 6. September 2009 18:20:26<BR>
Subject: [Paraview] Problem with custom time-aware reader<BR>
> OOPS! STOP! BACK UP! I looked at your code too quickly, misunderstood<BR>
> what you were doing, and gave totally the wrong advise. Please ignore<BR>
> everything I said before.<BR>
><BR>
> If you are using the file series reader, then your reader should be<BR>
> completely ignorant of any file series. It should read in only the file<BR>
> it is given, and if that file changes then it should ignore whatever<BR>
> file it was previously given. Therefore, the problem with your reader<BR>
> is that it is trying to collect time information over all the files.<BR>
> That is the job of the file series reader and as a result it is fouling<BR>
> up the operation of the file series reader.<BR>
><BR>
> So, what your reader should do is read in the time value in the file it<BR>
> is given, set the TIME_STEPS key to ONLY that time value and set the<BR>
> TIME_RANGE to be only that range. Attached is a modified version of<BR>
> your reader example that has all that time series management stripped<BR>
> out. The resulting code is much smaller and actually works.<BR>
><BR>
> Specifically what was happening was that by the time RequestInformation<BR>
> was called on the last time step, your reader had collected information<BR>
> about all the time steps and returned all the time steps in all the<BR>
> files. The file series reader thought you meant that the last file<BR>
> contained all those time steps (some file formats do contain multiple<BR>
> time steps in a single file). Because your reader said that the last<BR>
> file contained all the time steps, the file series reader was using that<BR>
> last file for all the time steps.<BR>
><BR>
> -Ken<BR>
><BR>
><BR>
> On 9/3/09 11:24 PM, "Karl König" <<a href="kkoenig11@web.de">kkoenig11@web.de</a>> wrote:<BR>
><BR>
> Hi Ken,<BR>
><BR>
> Thanks again for your input.<BR>
><BR>
> > You have the basic idea. The seg fault is probably happening because<BR>
> > the destructor of you class is trying to free the pointer you set<BR>
> to it,<BR>
> > which is probably actually pointing to some spot on the stack.<BR>
> ><BR>
> > You are probably not seeing this mapping/lookup in the VTK IO classes<BR>
> > because you are looking at classes that do not directly support time<BR>
> > (such as the legacy readers and XML readers). Those readers read<BR>
> > exactly one file with one time step in it. ParaView has a magic meta<BR>
> > reader called a FileSeriesReader that takes a real reader and a<BR>
> > collection of files and multiplexes the files to the reader based<BR>
> on the<BR>
> > time.<BR>
> ><BR>
> > In retrospect, this is probably an easier way to go (assuming your<BR>
> final<BR>
> > reader is a file series like this). Documentation on using the<BR>
> > FileSeriesReader is on the Wiki at<BR>
> ><BR>
> > <a href="http://www.paraview.org/Wiki/Restarted_Simulation_Readers#Customized_Restart_Reader">http://www.paraview.org/Wiki/Restarted_Simulation_Readers#Customized_Restart_Reader</a><BR>
><BR>
> I've been aware of that page. In fact, FooReader.xml and<BR>
> FooReaderGUI.xml of the tarball I posted already did make use of the<BR>
> FileSeriesReader. Together with calling<BR>
> outInfo->Set(vtkStreamingDemandDrivenPipeline::TIME_STEPS(), ...)<BR>
> outInfo->Set(vtkStreamingDemandDrivenPipeline::TIME_RANGE(), ...)<BR>
> in RequestInformation it is responsible for inspecting all files of the<BR>
> series between selecting them in the file open dialog and appearing of<BR>
> the Apply button.<BR>
><BR>
> Anyway, I'll try to use again the mapping time step value -> file name<BR>
> and iron out the segfault on deletion of the reader object.<BR>
><BR>
> I'll post the solution in case I can work it out and someone is<BR>
> interested.<BR>
><BR>
> Karl<BR>
><BR>
><BR>
><BR>
><BR>
><BR>
> **** Kenneth Moreland<BR>
> *** Sandia National Laboratories<BR>
> *********** <BR>
> *** *** *** email: <a href="kmorel@sandia.gov">kmorel@sandia.gov</a><BR>
> ** *** ** phone: (505) 844-8919<BR>
> *** web: <a href="http://www.cs.unm.edu/~kmorel">http://www.cs.unm.edu/~kmorel</a><BR>
><BR>
<BR>
<BR>
<BR>
<BR>
</SPAN></FONT></BLOCKQUOTE><FONT FACE="Calibri, Verdana, Helvetica, Arial"><SPAN STYLE='font-size:11pt'><BR>
</SPAN></FONT><FONT SIZE="2"><FONT FACE="Consolas, Courier New, Courier"><SPAN STYLE='font-size:10pt'><BR>
**** Kenneth Moreland<BR>
*** Sandia National Laboratories<BR>
*********** <BR>
*** *** *** email: <a href="kmorel@sandia.gov">kmorel@sandia.gov</a><BR>
** *** ** phone: (505) 844-8919<BR>
*** web: <a href="http://www.cs.unm.edu/~kmorel">http://www.cs.unm.edu/~kmorel</a><BR>
</SPAN></FONT></FONT><FONT FACE="Calibri, Verdana, Helvetica, Arial"><SPAN STYLE='font-size:11pt'><BR>
</SPAN></FONT>
</BODY>
</HTML>