That's allright. Thanks ! I like the new input dialogs.<br><br>Jerome<br><br><div class="gmail_quote">2010/3/23 Utkarsh Ayachit <span dir="ltr"><<a href="mailto:utkarsh.ayachit@kitware.com">utkarsh.ayachit@kitware.com</a>></span><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Jerome,<br>
<br>
That should be fixed now.<br>
<br>
/cvsroot/ParaView3/ParaView3/Qt/Components/pqChangeInputDialog.cxx,v<br>
<-- Qt/Components/pqChangeInputDialog.cxx<br>
new revision: 1.4; previous revision: 1.3<br>
<br>
Utkarsh<br>
<br>
On Fri, Mar 19, 2010 at 10:51 PM, Utkarsh Ayachit<br>
<div><div></div><div class="h5"><<a href="mailto:utkarsh.ayachit@kitware.com">utkarsh.ayachit@kitware.com</a>> wrote:<br>
> Oh isn't it already? Looks like there's a bug with multiple input<br>
> connections. I'll fix it.<br>
><br>
> On Fri, Mar 19, 2010 at 4:36 AM, Jérôme <<a href="mailto:jerome.velut@gmail.com">jerome.velut@gmail.com</a>> wrote:<br>
>> Thanks Utkarsh<br>
>><br>
>> I like it ! However - let me know if I am boring ;) -, for multiple inputs<br>
>> on<br>
>> one port (such as AppendGeometry), it would be nice if the current inputs<br>
>> are already selected when choosing "Change Input" in the pipeline<br>
>> browser. Lazy men (yes, I am) don't want to reselect them...<br>
>><br>
>> Anyway, that's good !<br>
>> Jerome<br>
>><br>
>> 2010/3/17 Utkarsh Ayachit <<a href="mailto:utkarsh.ayachit@kitware.com">utkarsh.ayachit@kitware.com</a>><br>
>>><br>
>>> Folks,<br>
>>><br>
>>> I've committed some changes. A slight change from the mockup is the<br>
>>> placement of the radio buttons, since the buttons on the top seemed<br>
>>> disconnected from the pipeline view when more than 1 input ports were<br>
>>> present. Also, if there's only 1 input port, the radio buttons are now<br>
>>> hidden.<br>
>>><br>
>>><br>
>>> Jeremy,<br>
>>><br>
>>> I think I understood what you meant, and I've tried to address that<br>
>>> issue as well. Feel free to give that a try.<br>
>>><br>
>>> Utkarsh<br>
>>><br>
>>> On Tue, Mar 16, 2010 at 12:08 PM, Jérôme <<a href="mailto:jerome.velut@gmail.com">jerome.velut@gmail.com</a>> wrote:<br>
>>> > Then I was right : I was not clear enough!<br>
>>> ><br>
>>> > First, I talked about the current panel, not your mockup. I agree with<br>
>>> > those who enthousiastic.<br>
>>> > Second, the problem I noted on the multiple-input-port panel is that<br>
>>> > the input are not ordered by index, but by name. Changing "Source"<br>
>>> > to "ArbirtraySource" in the filters.xml for streamer with custom source<br>
>>> > will change the order the inputs appear. Well, I know, if the name are<br>
>>> > well-chosen, it is not a problem.<br>
>>> ><br>
>>> > Now, let's take this pipeline:<br>
>>> ><br>
>>> > builtin<br>
>>> > |<br>
>>> > |---Wavelet<br>
>>> > | |<br>
>>> > | Gradient<br>
>>> > |<br>
>>> > | --- PointSource<br>
>>> ><br>
>>> > If you want to initialize a stream tracer in the Gradient at each point<br>
>>> > of PointSource, you have to select Gradient, then choose filter -><br>
>>> > Stream tracer with custom source. The inputs panel is shown, with<br>
>>> > the Input field being already set to the selected 'Gradient'. What you<br>
>>> > have to do is to set the Source to PointSource from the pipeline.<br>
>>> > Well...<br>
>>> > Attached is a screenshot of this procedure, but Source is named<br>
>>> > ArbitrarySource. The Gradient is set as ArbitrarySource, and Input field<br>
>>> > is not set.<br>
>>> ><br>
>>> > I hope I am clearer now!<br>
>>> ><br>
>>> > Jerome<br>
>>> ><br>
>>> ><br>
>>> ><br>
>>> ><br>
>>> > 2010/3/16 Utkarsh Ayachit <<a href="mailto:utkarsh.ayachit@kitware.com">utkarsh.ayachit@kitware.com</a>><br>
>>> >><br>
>>> >> I am not sure why there's a problem. In your case, your filters have 2<br>
>>> >> input ports. e.g. in the stream tracer case, referring to the mockup,<br>
>>> >> INPUT1 will be called "Input" while INPUT2 will be called<br>
>>> >> "ArbitrarySource" or "Source" as the case may be. Both of which<br>
>>> >> allowing the user to only add 1 item in the input box next to them.<br>
>>> >><br>
>>> >> Utkarsh<br>
>>> >><br>
>>> >> On Tue, Mar 16, 2010 at 4:23 AM, Jérôme <<a href="mailto:jerome.velut@gmail.com">jerome.velut@gmail.com</a>> wrote:<br>
>>> >> > My 2 cents on this :<br>
>>> >> > It seems to me that the input list is provided in alphabetical order.<br>
>>> >> > In<br>
>>> >> > my<br>
>>> >> > case I have a lot of custom plugins that take 2 inputs, one being<br>
>>> >> > vtkImageData<br>
>>> >> > and the other a vtkPolyData (such a stream tracer with custom<br>
>>> >> > source).<br>
>>> >> > Depending on wich is the 'principal' input, the default input setting<br>
>>> >> > of<br>
>>> >> > this<br>
>>> >> > panel have non-corresponding type. For instance, the Image input is<br>
>>> >> > set<br>
>>> >> > to an existing PointSet.<br>
>>> >> ><br>
>>> >> > I don't know if I am clear enough, but maybe you can try with the<br>
>>> >> > stream<br>
>>> >> > tracer<br>
>>> >> > with custom source: in the current configuration, there is no<br>
>>> >> > problem.<br>
>>> >> > But I<br>
>>> >> > am<br>
>>> >> > quite sure that if you rename the 2nd input "Source" to<br>
>>> >> > "ArbitrarySource" in<br>
>>> >> > the<br>
>>> >> > filters.xml, you will understand this tiny problem.<br>
>>> >> ><br>
>>> >> > Jerome<br>
>>> >> ><br>
>>> >> > 2010/3/16 Christian Werner <<a href="mailto:christian.werner@rwth-aachen.de">christian.werner@rwth-aachen.de</a>><br>
>>> >> >><br>
>>> >> >> I vote yes for the mockup!<br>
>>> >> >><br>
>>> >> >> Utkarsh Ayachit wrote:<br>
>>> >> >>><br>
>>> >> >>> I agree, the pipeline preview is confusing and for the most part<br>
>>> >> >>> useless. Unless people object, I'd vote for removing it as well.<br>
>>> >> >>><br>
>>> >> >>> Attached is a sample mockup. In case of filters like Append which<br>
>>> >> >>> have<br>
>>> >> >>> single input port, but multiple input connections, the use can type<br>
>>> >> >>> in<br>
>>> >> >>> a comma separated list of the inputs in the input field or select<br>
>>> >> >>> multiple items using the pipeline browser in the dialog.<br>
>>> >> >>><br>
>>> >> >>> Utkarsh<br>
>>> >> >>><br>
>>> >> >>> On Mon, Mar 15, 2010 at 11:22 AM, Christian Werner<br>
>>> >> >>> <<a href="mailto:christian.werner@rwth-aachen.de">christian.werner@rwth-aachen.de</a>> wrote:<br>
>>> >> >>><br>
>>> >> >>>><br>
>>> >> >>>> As a user, may I present three suggestions, two of which should be<br>
>>> >> >>>> very<br>
>>> >> >>>> easy<br>
>>> >> >>>> and still yield an improvement.<br>
>>> >> >>>><br>
>>> >> >>>> 1) remove the Pipeline Preview: This may be rude because it's<br>
>>> >> >>>> somehow<br>
>>> >> >>>> nice.<br>
>>> >> >>>> But then again, you cannot change what happens to the pipeline<br>
>>> >> >>>> anyway.<br>
>>> >> >>>> Also,<br>
>>> >> >>>> I don't think one would change his mind about the selection of the<br>
>>> >> >>>> inputs<br>
>>> >> >>>> just because the Pipeline Preview shows something unsuspected.<br>
>>> >> >>>> Most<br>
>>> >> >>>> of<br>
>>> >> >>>> the<br>
>>> >> >>>> time the user knows what he is doing and wants to quickly and<br>
>>> >> >>>> easily<br>
>>> >> >>>> select<br>
>>> >> >>>> his inputs. The actual layout works against this intend. The<br>
>>> >> >>>> Pipeline<br>
>>> >> >>>> Preview can be included again once a nice layout is found.<br>
>>> >> >>>><br>
>>> >> >>>> 2) hide the Pipeline Preview and make it visible if the user wants<br>
>>> >> >>>> to<br>
>>> >> >>>><br>
>>> >> >>>> 3) change the layout such that the inputs are shown on top and let<br>
>>> >> >>>> QT<br>
>>> >> >>>> manage<br>
>>> >> >>>> the form's height. You normally don't use so many inputs, so this<br>
>>> >> >>>> most<br>
>>> >> >>>> probably would never lead to problems.<br>
>>> >> >>>><br>
>>> >> >>>><br>
>>> >> >>>> Best regards,<br>
>>> >> >>>> Christian<br>
>>> >> >>>><br>
>>> >> >>>> Paul Edwards wrote:<br>
>>> >> >>>><br>
>>> >> >>>>><br>
>>> >> >>>>> One simple fix would be to make sure that the preview window<br>
>>> >> >>>>> isn't<br>
>>> >> >>>>> selectable. A lot of my users get confused thinking one box is<br>
>>> >> >>>>> for<br>
>>> >> >>>>> the input and the other as the source.<br>
>>> >> >>>>><br>
>>> >> >>>>> Regards,<br>
>>> >> >>>>> Paul<br>
>>> >> >>>>><br>
>>> >> >>>>> On 12 March 2010 19:10, Utkarsh Ayachit<br>
>>> >> >>>>> <<a href="mailto:utkarsh.ayachit@kitware.com">utkarsh.ayachit@kitware.com</a>><br>
>>> >> >>>>> wrote:<br>
>>> >> >>>>><br>
>>> >> >>>>><br>
>>> >> >>>>>><br>
>>> >> >>>>>> I cannot agree more. I am going to take a stab and fixing this<br>
>>> >> >>>>>> before<br>
>>> >> >>>>>> 3.8. We've just had too many complaints about this dialog to<br>
>>> >> >>>>>> keep<br>
>>> >> >>>>>> on<br>
>>> >> >>>>>> delaying this.<br>
>>> >> >>>>>><br>
>>> >> >>>>>> Utkarsh<br>
>>> >> >>>>>><br>
>>> >> >>>>>> On Fri, Mar 12, 2010 at 2:00 PM, Christian Werner<br>
>>> >> >>>>>> <<a href="mailto:christian.werner@rwth-aachen.de">christian.werner@rwth-aachen.de</a>> wrote:<br>
>>> >> >>>>>><br>
>>> >> >>>>>><br>
>>> >> >>>>>>><br>
>>> >> >>>>>>> Hello!<br>
>>> >> >>>>>>><br>
>>> >> >>>>>>> I wonder why the input port selection is so cramped in the<br>
>>> >> >>>>>>> input<br>
>>> >> >>>>>>> editor.<br>
>>> >> >>>>>>> It<br>
>>> >> >>>>>>> is really bad that you cannot actually read out the selections<br>
>>> >> >>>>>>> you<br>
>>> >> >>>>>>> make<br>
>>> >> >>>>>>> without moving the scrollbar. Then, after scrolling, you cannot<br>
>>> >> >>>>>>> change<br>
>>> >> >>>>>>> the<br>
>>> >> >>>>>>> other input without scrolling back. This really steals your<br>
>>> >> >>>>>>> time.<br>
>>> >> >>>>>>> On<br>
>>> >> >>>>>>> the<br>
>>> >> >>>>>>> other hand there is that pipeline preview which is nice to see<br>
>>> >> >>>>>>> but<br>
>>> >> >>>>>>> honestly<br>
>>> >> >>>>>>> I'd instantly trade it away for a better overview on my inputs.<br>
>>> >> >>>>>>> I<br>
>>> >> >>>>>>> have<br>
>>> >> >>>>>>> attached a picture that shows the situation on my PC.<br>
>>> >> >>>>>>><br>
>>> >> >>>>>>> By the way, doesn't anyone have any idea about my last issue?<br>
>>> >> >>>>>>> (no<br>
>>> >> >>>>>>> cell/point<br>
>>> >> >>>>>>> data in imported ITK volumes):<br>
>>> >> >>>>>>><br>
>>> >> >>>>>>><br>
>>> >> >>>>>>>><br>
>>> >> >>>>>>>> "Create Cell or Point Data out of Image"<br>
>>> >> >>>>>>>><br>
>>> >> >>>>>>>><br>
>>> >> >>>>>>><br>
>>> >> >>>>>>> Best regards,<br>
>>> >> >>>>>>> Christian<br>
>>> >> >>>>>>><br>
>>> >> >>>>>>> _______________________________________________<br>
>>> >> >>>>>>> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>>> >> >>>>>>><br>
>>> >> >>>>>>> Visit other Kitware open-source projects at<br>
>>> >> >>>>>>> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>>> >> >>>>>>><br>
>>> >> >>>>>>> Please keep messages on-topic and check the ParaView Wiki at:<br>
>>> >> >>>>>>> <a href="http://paraview.org/Wiki/ParaView" target="_blank">http://paraview.org/Wiki/ParaView</a><br>
>>> >> >>>>>>><br>
>>> >> >>>>>>> Follow this link to subscribe/unsubscribe:<br>
>>> >> >>>>>>> <a href="http://www.paraview.org/mailman/listinfo/paraview" target="_blank">http://www.paraview.org/mailman/listinfo/paraview</a><br>
>>> >> >>>>>>><br>
>>> >> >>>>>>><br>
>>> >> >>>>>>><br>
>>> >> >>>>>>><br>
>>> >> >>>>>><br>
>>> >> >>>>>> _______________________________________________<br>
>>> >> >>>>>> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>>> >> >>>>>><br>
>>> >> >>>>>> Visit other Kitware open-source projects at<br>
>>> >> >>>>>> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>>> >> >>>>>><br>
>>> >> >>>>>> Please keep messages on-topic and check the ParaView Wiki at:<br>
>>> >> >>>>>> <a href="http://paraview.org/Wiki/ParaView" target="_blank">http://paraview.org/Wiki/ParaView</a><br>
>>> >> >>>>>><br>
>>> >> >>>>>> Follow this link to subscribe/unsubscribe:<br>
>>> >> >>>>>> <a href="http://www.paraview.org/mailman/listinfo/paraview" target="_blank">http://www.paraview.org/mailman/listinfo/paraview</a><br>
>>> >> >>>>>><br>
>>> >> >>>>>><br>
>>> >> >>>>>><br>
>>> >> >>>><br>
>>> >> >>>><br>
>>> >> >>>><br>
>>> >> >>>><br>
>>> >> >>>> ------------------------------------------------------------------------<br>
>>> >> >>>><br>
>>> >> >><br>
>>> >> >> _______________________________________________<br>
>>> >> >> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>>> >> >><br>
>>> >> >> Visit other Kitware open-source projects at<br>
>>> >> >> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>>> >> >><br>
>>> >> >> Please keep messages on-topic and check the ParaView Wiki at:<br>
>>> >> >> <a href="http://paraview.org/Wiki/ParaView" target="_blank">http://paraview.org/Wiki/ParaView</a><br>
>>> >> >><br>
>>> >> >> Follow this link to subscribe/unsubscribe:<br>
>>> >> >> <a href="http://www.paraview.org/mailman/listinfo/paraview" target="_blank">http://www.paraview.org/mailman/listinfo/paraview</a><br>
>>> >> ><br>
>>> >> ><br>
>>> >> > _______________________________________________<br>
>>> >> > Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>>> >> ><br>
>>> >> > Visit other Kitware open-source projects at<br>
>>> >> > <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>>> >> ><br>
>>> >> > Please keep messages on-topic and check the ParaView Wiki at:<br>
>>> >> > <a href="http://paraview.org/Wiki/ParaView" target="_blank">http://paraview.org/Wiki/ParaView</a><br>
>>> >> ><br>
>>> >> > Follow this link to subscribe/unsubscribe:<br>
>>> >> > <a href="http://www.paraview.org/mailman/listinfo/paraview" target="_blank">http://www.paraview.org/mailman/listinfo/paraview</a><br>
>>> >> ><br>
>>> >> ><br>
>>> ><br>
>>> ><br>
>><br>
>><br>
><br>
</div></div></blockquote></div><br>