<html><body bgcolor="#FFFFFF"><div>Great. There should probably be some documentation updates to let developers know that the variable needs to be turned on so that their plugins will get copied. I still need to try this on windows. <br>
<br><div>-----</div><div>Mike Jackson <a href="http://www.bluequartz.net"><a href="http://www.bluequartz.net">www.bluequartz.net</a></a></div><div>Principal Software Engineer <a href="mailto:mike.jackson@bluequartz.net"><a href="mailto:mike.jackson@bluequartz.net">mike.jackson@bluequartz.net</a></a></div>
<div>BlueQuartz Software Dayton, Ohio</div><div><br></div></div><div><br>On May 17, 2010, at 18:28, Dave Partyka <<a href="mailto:dave.partyka@kitware.com">dave.partyka@kitware.com</a>> wrote:<br><br></div>
<div></div><blockquote type="cite"><div>Hi Mike, <div><br></div><div>I committed your patch to master and cherry picked it onto the release branch.<br><br><div class="gmail_quote">On Mon, May 17, 2010 at 9:41 AM, Michael Jackson <span dir="ltr"><<a href="mailto:mike.jackson@bluequartz.net"><a href="mailto:mike.jackson@bluequartz.net">mike.jackson@bluequartz.net</a></a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">519:[mjackson@Ferb:ParaView]$ git diff<br>
diff --git a/CMakeLists.txt b/CMakeLists.txt<br>
index 45eef61..6698fcc 100644<br>
--- a/CMakeLists.txt<br>
+++ b/CMakeLists.txt<br>
@@ -26,6 +26,11 @@ GET_PROPERTY(PV_TARGET_SUPPORTS_SHARED_LIBS<br>
SET(PARAVIEW_PLUGINLIST_TXT "${ParaView_BINARY_DIR}/PluginList.txt")<br>
FILE(WRITE ${PARAVIEW_PLUGINLIST_TXT} "")<br>
<br>
+<br>
#########################################################################<br>
+# PARAVIEW_PLUGINLIST is used to generate the config file distributed with<br>
+# ParaView that lists the plugins distributed with ParaView.<br>
+SET(PARAVIEW_PLUGINLIST "" CACHE INTERNAL "List of configured plugins" FORCE)<br>
+<br>
SET(PARAVIEW_PLUGIN_CONFIG_LIST "" CACHE INTERNAL "List of configured plugins.")<br>
<br>
#########################################################################<br>
@@ -313,10 +318,7 @@ SET(PARAVIEW_SMTESTDRIVER_EXECUTABLE ${EXECUTABLE_OUTPUT_PATH}/smTestDriver${<br>
# release/debug configuration gets considered.<br>
GET_TARGET_PROPERTY(PARAVIEW_PROCESS_XML_EXECUTABLE kwProcessXML LOCATION)<br>
<br>
-#########################################################################<br>
-# PARAVIEW_PLUGINLIST is used to generate the config file distributed with<br>
-# ParaView that lists the plugins distributed with ParaView.<br>
-SET(PARAVIEW_PLUGINLIST "" CACHE INTERNAL "List of configured plugins" FORCE)<br>
+<br>
ADD_SUBDIRECTORY(Plugins)<br>
<br>
#########################################################################<br>
<br>
That is the first change. The issue with BUILD_PARAVIEW_PLUGINLIST I am not sure where that should properly be enabled. Currently it is enabled in ParaView/Plugins/CMakeLists.txt at the top of the file. If someone uses the PARAVIEW_EXTRA_EXTERNAL_MODULES I don't think the BUILD_PARAVIEW_PLUGINLIST gets enabled in the proper sequence. So I guess it comes down to is it the responsibility of the programmer to enable it or should it get enabled if the ADD_PARAVIEW_PLUGIN is called which would cover all the bases?<br>
___________________________________________________________<div class="im"><br>
Mike Jackson <a href="http://www.bluequartz.net" target="_blank"><a href="http://www.bluequartz.net">www.bluequartz.net</a></a><br>
<br>
<br>
<br></div><div><div></div><div class="h5">
On May 14, 2010, at 9:10 PM, Dave Partyka wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Cool okay! Can you make a proper git patch against Master and send it to the list? I will apply it and cherry pick it into the list.<br>
<br>
On Fri, May 14, 2010 at 7:40 PM, Michael Jackson <<a href="mailto:mike.jackson@bluequartz.net" target="_blank"><a href="mailto:mike.jackson@bluequartz.net">mike.jackson@bluequartz.net</a></a>> wrote:<br>
There is another cmake variable "BUILD_PARAVIEW_PLUGINLIST" which needs to be enabled in the *ParaViewImport.cmake file. I added SET (BUILD_PARAVIEW_PLUGINLIST ON) to my PVMXADataModelParaViewImport.cmake file (and with the other corrections) I now can do a "make install" and have ParaView.app include my plugins. So where should I send a patch?<br>
<br>
Now.. if I could only convince "make install" to actually install ParaView.app where I want that would be great. No Write privs in /Applications.<br>
--<br>
<br>
Mike Jackson <<a href="http://www.bluequartz.net" target="_blank"><a href="http://www.bluequartz.net">www.bluequartz.net</a></a>><br>
<br>
On May 14, 2010, at 5:12 PM, Michael Jackson wrote:<br>
<br>
Ok,<br>
So here is the problem. The PARAVIEW_EXTRA_EXTERNAL_MODULES is called in the top level ParaView CMakeLists.txt file. AFTER that call the line:<br>
SET(PARAVIEW_PLUGINLIST "" CACHE INTERNAL "List of configured plugins" FORCE)<br>
<br>
is called which wipes out any plugins that were added by External Modules. So one needs to initialize the PARAVIEW_PLUGINLIST BEFORE the line:<br>
<br>
INCLUDE(ParaViewCommon)<br>
<br>
is executed:<br>
<br>
But that still didn't work but is probably part of the problem<br>
___________________________________________________________<br>
Mike Jackson <a href="http://www.bluequartz.net" target="_blank"><a href="http://www.bluequartz.net">www.bluequartz.net</a></a><br>
<br>
On May 14, 2010, at 1:40 PM, Dave Partyka wrote:<br>
<br>
Hi Mike,<br>
<br>
Do you mind trying to print some messages then? When you call ADD_PARAVIEW_PLUGIN the plugin gets Appended to PARAVIEW_PLUGINLIST and also install rules should be created. Can you add this line say in Applications\ParaView\CMakeLists.txt and then configure and see if you're plugins get printed in the list of plugins?<br>
<br>
message("PARAVIEW_PLUGINLIST ${PARAVIEW_PLUGINLIST}")<br>
<br>
On Fri, May 14, 2010 at 11:02 AM, Michael Jackson <<a href="mailto:mike.jackson@bluequartz.net" target="_blank"><a href="mailto:mike.jackson@bluequartz.net">mike.jackson@bluequartz.net</a></a>> wrote:<br>
This is still NOT working on the latest pull of the "release" branch of ParaView. I can NOT simply do a "make install" on OS X and have my custom plugins copied into the Application Bundle along with any other plugins that are included with ParaView.<br>
___________________________________________________________<br>
<br>
Mike Jackson <a href="http://www.bluequartz.net" target="_blank"><a href="http://www.bluequartz.net">www.bluequartz.net</a></a><br>
<br>
On Apr 26, 2010, at 11:47 AM, Michael Jackson wrote:<br>
<br>
Thanks, I'll give that a try. "Make install" does fixup the bundle correctly. I just left out my plugins.<br>
<br>
So I have to do a cpack run in order to get a working installation on my local machine? ie, an "installation" that is NOT in my build directory? Seems odd.<br>
<br>
--<br>
Mike Jackson <<a href="http://www.bluequartz.net" target="_blank"><a href="http://www.bluequartz.net">www.bluequartz.net</a></a>><br>
<br>
On Apr 26, 2010, at 11:05 AM, Dave Partyka wrote:<br>
<br>
I would recommend:<br>
<br>
cpack --config <build-dir>/Applications/ParaView/CPackParaViewConfig.cmake -G DragNDrop<br>
<br>
As per: <a href="http://paraview.org/Wiki/ParaView:Build_And_Install" target="_blank"><a href="http://paraview.org/Wiki/ParaView:Build_And_Install">http://paraview.org/Wiki/ParaView:Build_And_Install</a></a><br>
<br>
If you do make install I believe it just runs all install rules and I don't believe any of the fixup bundle routines get called.<br>
<br>
On Mon, Apr 26, 2010 at 9:43 AM, Michael Jackson <<a href="mailto:mike.jackson@bluequartz.net" target="_blank"><a href="mailto:mike.jackson@bluequartz.net">mike.jackson@bluequartz.net</a></a>> wrote:<br>
Just tried a 'Make install' and after installation (to the wrong directory**) my custom plugins that are built as part of ParaView (using PARAVIEW_EXTRA_EXTERNAL_MODULE). Is this going to be fixed before the full release comes out?<br>
<br>
<br>
**I have a CMAKE_INSTALL_PREFIX of /Users/Shared/Toolkits/ParaView-3.8 but when I run 'make install' ParaView gets installed into /Applications? I tried exporting DESTDIR=$CMAKE_INSTALL_PATH but that did not seem to help either. I do not have write access to /Applications for this user account so this "feature" is a real problem.<br>
<br>
___________________________________________________________<br>
Mike Jackson <a href="http://www.bluequartz.net" target="_blank"><a href="http://www.bluequartz.net">www.bluequartz.net</a></a><br>
Principal Software Engineer <a href="mailto:mike.jackson@bluequartz.net" target="_blank"><a href="mailto:mike.jackson@bluequartz.net">mike.jackson@bluequartz.net</a></a><br>
BlueQuartz Software Dayton, Ohio<br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank"><a href="http://www.kitware.com">www.kitware.com</a></a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank"><a href="http://www.kitware.com/opensource/opensource.html">http://www.kitware.com/opensource/opensource.html</a></a><br>
<br>
Please keep messages on-topic and check the ParaView Wiki at: <a href="http://paraview.org/Wiki/ParaView" target="_blank"><a href="http://paraview.org/Wiki/ParaView">http://paraview.org/Wiki/ParaView</a></a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.paraview.org/mailman/listinfo/paraview" target="_blank"><a href="http://www.paraview.org/mailman/listinfo/paraview">http://www.paraview.org/mailman/listinfo/paraview</a></a><br>
<br>
<br>
<br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank"><a href="http://www.kitware.com">www.kitware.com</a></a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank"><a href="http://www.kitware.com/opensource/opensource.html">http://www.kitware.com/opensource/opensource.html</a></a><br>
<br>
Please keep messages on-topic and check the ParaView Wiki at: <a href="http://paraview.org/Wiki/ParaView" target="_blank"><a href="http://paraview.org/Wiki/ParaView">http://paraview.org/Wiki/ParaView</a></a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.paraview.org/mailman/listinfo/paraview" target="_blank"><a href="http://www.paraview.org/mailman/listinfo/paraview">http://www.paraview.org/mailman/listinfo/paraview</a></a><br>
<br>
</blockquote>
<br>
</div></div></blockquote></div><br></div>
</div></blockquote></body></html>