Okay I pushed both d48e13e489e35be17a6a881e2f0c94649dec1622 && 9514b8974df55064bf54a4d27816cdffeaa71723 to the release branch.<br><br><div class="gmail_quote">On Fri, May 28, 2010 at 9:28 AM, Utkarsh Ayachit <span dir="ltr"><<a href="mailto:utkarsh.ayachit@kitware.com">utkarsh.ayachit@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Alright, I've committed it to master. Dave, can you move this to the<br>
release branch as well, thanks.<br>
<br>
commit d48e13e489e35be17a6a881e2f0c94649dec1622<br>
Author: Utkarsh Ayachit <<a href="mailto:utkarsh.ayachit@kitware.com">utkarsh.ayachit@kitware.com</a>><br>
Date: Fri May 28 09:27:12 2010 -0400<br>
<br>
Removed BUILD_PARAVIEW_PLUGINLIST.<br>
<br>
Removing unnecessary BUILD_PARAVIEW_PLUGINLIST varible. This was<br>
resulting in<br>
plugins included using PARAVIEW_EXTRA_EXTERNAL_MODULES not being<br>
listed in the<br>
default list of plugins.<br>
<br>
<br>
Utkarsh<br>
<br>
On Thu, May 27, 2010 at 5:59 PM, Mike Jackson<br>
<div><div></div><div class="h5"><<a href="mailto:mike.jackson@bluequartz.net">mike.jackson@bluequartz.net</a>> wrote:<br>
> The patch is close but there are a few corrections and since I don't<br>
> have a "patch" tool on my windows machine I'll have to try to describe<br>
> the corrections here by hand so look carefully rather than trying to<br>
> use 'patch' to apply these changes.<br>
><br>
> diff --git a/CMakeLists.txt b/CMakeLists.txt<br>
> index 8b77219..b08089d 100644<br>
> --- a/CMakeLists.txt<br>
> +++ b/CMakeLists.txt<br>
> @@ -30,9 +30,7 @@ FILE(WRITE ${PARAVIEW_PLUGINLIST_TXT} "")<br>
> #########################################################################<br>
> # PARAVIEW_PLUGINLIST is used to generate the config file distributed with<br>
> # ParaView that lists the plugins distributed with ParaView.<br>
><br>
> -SET(PARAVIEW_PLUGIN_CONFIG_LIST "" CACHE INTERNAL "List of configured<br>
> plugins.")<br>
><br>
><br>
> diff --git a/CMake/ParaViewPlugins.cmake b/CMake/ParaViewPlugins.cmake<br>
> index 1d03765..00e0ec9 100644<br>
> --- a/CMake/ParaViewPlugins.cmake<br>
> +++ b/CMake/ParaViewPlugins.cmake<br>
> @@ -1010,11 +1010,7 @@ FUNCTION(ADD_PARAVIEW_PLUGIN NAME VERSION)<br>
> # this builds a list of actual plugin names added by plugins<br>
> provided in the<br>
> # ParaView source directory itself.<br>
> # This is used to generate the ".plugins" configuration file.<br>
> - if (BUILD_PARAVIEW_PLUGINLIST)<br>
> - SET(PARAVIEW_PLUGINLIST ${PARAVIEW_PLUGINLIST} ${NAME} CACHE INTERNAL<br>
> - "List of configured plugins")<br>
> - endif (BUILD_PARAVIEW_PLUGINLIST)<br>
> -<br>
> + SET(PARAVIEW_PLUGINLIST ${PARAVIEW_PLUGINLIST} ${NAME} CACHE<br>
> INTERNAL "List of configured plugins")<br>
> ENDIF(GUI_SRCS OR SM_SRCS OR ARG_SOURCES OR ARG_PYTHON_MODULES)<br>
><br>
> ENDFUNCTION(ADD_PARAVIEW_PLUGIN)<br>
><br>
> Those changes allowed my ParaView 3.8.0 source to correctly generate<br>
> the .plugins file.<br>
> _________________________________________________________<br>
> Mike Jackson <a href="mailto:mike.jackson@bluequartz.net">mike.jackson@bluequartz.net</a><br>
> BlueQuartz Software <a href="http://www.bluequartz.net" target="_blank">www.bluequartz.net</a><br>
> Principal Software Engineer Dayton, Ohio<br>
><br>
><br>
><br>
> On Thu, May 27, 2010 at 5:32 PM, Utkarsh Ayachit<br>
> <<a href="mailto:utkarsh.ayachit@kitware.com">utkarsh.ayachit@kitware.com</a>> wrote:<br>
>> Mike,<br>
>><br>
>> Attached is a patch that fixes this issue. Can you try if that works?<br>
>> Dave, if that works, can you commit that to the master and release<br>
>> branches?<br>
>><br>
>> Utkarsh<br>
>><br>
>> On Thu, May 27, 2010 at 4:54 PM, Mike Jackson<br>
>> <<a href="mailto:mike.jackson@bluequartz.net">mike.jackson@bluequartz.net</a>> wrote:<br>
>>> Here is some more information about what is going on with my windows<br>
>>> build. I had to add the following to the top of my<br>
>>> "*ParaViewImport.cmake" file:<br>
>>><br>
>>> SET (BUILD_PARAVIEW_PLUGINLIST ON)<br>
>>><br>
>>> So now the .plugins file correctly has my plugins listed except that<br>
>>> the "autoload" property is set to "0". Shouldn't that be "1" by<br>
>>> default? Seems odd but I am sure I don't fully understand all the<br>
>>> ramifications of having that value set to "1" by default.<br>
>>><br>
>>> Also, during the build I am compiling a 3rd party library that needs<br>
>>> to get added to the installer generation. Is there a way to do this?<br>
>>> If I run the "INSTALL" project from VS I get everything installed<br>
>>> correctly. If I use the CPack command like took to generate the<br>
>>> installer the library is missing from the install.<br>
>>> _________________________________________________________<br>
>>> Mike Jackson <a href="mailto:mike.jackson@bluequartz.net">mike.jackson@bluequartz.net</a><br>
>>><br>
>>> On Thu, May 27, 2010 at 4:23 PM, Michael Jackson<br>
>>> <<a href="mailto:mike.jackson@bluequartz.net">mike.jackson@bluequartz.net</a>> wrote:<br>
>>>> <a href="http://gitorious.bluequartz.net/mxa/pvmxadatamodel/blobs/master/PVMXADataModelParaViewImport.cmake" target="_blank">http://gitorious.bluequartz.net/mxa/pvmxadatamodel/blobs/master/PVMXADataModelParaViewImport.cmake</a><br>
>>>><br>
>>>> I am calling ADD_PARAVIEW_PLUGIN in my Cmake files. Not sure why this isn't<br>
>>>> working. I thought we had that fixed. At least at some point during the RC<br>
>>>> process this did actually work.<br>
>>>> --<br>
>>>> Mike J.<br>
>>>><br>
>>>> On May 27, 2010, at 4:06 PM, Dave Partyka wrote:<br>
>>>><br>
>>>>> How are you building your plugin? I believe that the ADD_PARAVIEW_PLUGIN<br>
>>>>> macro constructs the list of Plugins that get written into the .plugins<br>
>>>>> file.<br>
>>>>><br>
>>>>> On Thu, May 27, 2010 at 3:54 PM, Mike Jackson<br>
>>>>> <<a href="mailto:mike.jackson@bluequartz.net">mike.jackson@bluequartz.net</a>> wrote:<br>
>>>>> So then what is the point of having ParaView look in the plugins<br>
>>>>> directory if it is not going to be used. Why not just have ParaView<br>
>>>>> look in the "bin" folder (at least on windows)?<br>
>>>>><br>
>>>>> I see there is a file called ".plugins" inside the bin directory. Mine<br>
>>>>> has the following content:<br>
>>>>><br>
>>>>> <?xml version="1.0"?><br>
>>>>> <Plugins><br>
>>>>> <Plugin name="SierraPlotTools" auto_load="0"/><br>
>>>>> <Plugin name="SurfaceLIC" auto_load="0"/><br>
>>>>> <Plugin name="AnalyzeReader" auto_load="0"/><br>
>>>>> <Plugin name="AnalyzeWriter" auto_load="0"/><br>
>>>>> <Plugin name="NIfTIReader" auto_load="0"/><br>
>>>>> <Plugin name="NIfTIWriter" auto_load="0"/><br>
>>>>> </Plugins><br>
>>>>><br>
>>>>> This is missing my plugins although the plugins are "installed" in the<br>
>>>>> bin directory during the "INSTALL" project build. There is another<br>
>>>>> file in the build directory called "PluginList.txt" that _does_ list<br>
>>>>> my plugins though.<br>
>>>>> _________________________________________________________<br>
>>>>> Mike Jackson <a href="mailto:mike.jackson@bluequartz.net">mike.jackson@bluequartz.net</a><br>
>>>>> BlueQuartz Software <a href="http://www.bluequartz.net" target="_blank">www.bluequartz.net</a><br>
>>>>> Principal Software Engineer Dayton, Ohio<br>
>>>>><br>
>>>>><br>
>>>>><br>
>>>>> On Thu, May 27, 2010 at 3:42 PM, Utkarsh Ayachit<br>
>>>>> <<a href="mailto:utkarsh.ayachit@kitware.com">utkarsh.ayachit@kitware.com</a>> wrote:<br>
>>>>> > Mike,<br>
>>>>> ><br>
>>>>> > That was a conscious decision. We deliberately install all plugin dlls<br>
>>>>> > in the same directory as the paraview.exe on windows, just to avoid<br>
>>>>> > missing dlls issues at runtime. Originally, we had the separate<br>
>>>>> > "plugins" directory to make it easier for users to locate the plugins<br>
>>>>> > and load them manually. But now, that's a non-issue, since paraview<br>
>>>>> > explicitly lists all the plugins it's distributed with in the plugin<br>
>>>>> > manager dialog.<br>
>>>>> ><br>
>>>>> > Are you saying that the plugins added using<br>
>>>>> > PARAVIEW_EXTRA_EXTERNAL_MODULES are not being installed at all? If<br>
>>>>> > that's the case, then it's definitely a bug.<br>
>>>>> ><br>
>>>>> > As far as the package generation goes, you need to use CPack. Refer to<br>
>>>>> > this wiki page for details:<br>
>>>>> > <a href="http://www.paraview.org/Wiki/ParaView:Build_And_Install#Install_ParaView" target="_blank">http://www.paraview.org/Wiki/ParaView:Build_And_Install#Install_ParaView</a><br>
>>>>> ><br>
>>>>> > Utkarsh<br>
>>>>> ><br>
>>>>> > On Thu, May 27, 2010 at 12:37 PM, Mike Jackson<br>
>>>>> > <<a href="mailto:mike.jackson@bluequartz.net">mike.jackson@bluequartz.net</a>> wrote:<br>
>>>>> >> Pulled ParaView 3.8.0 from Git. Configured with CMake for VS2008 x64<br>
>>>>> >> with PARAVIEW_EXTRA_EXTERNAL_MODULES listing 4 of my custom plugins.<br>
>>>>> >> Compiled. Installed. And all the "client" plugins are installed lose<br>
>>>>> >> into the ParaView-3.8.0/bin directory instead of<br>
>>>>> >> ParaView-3.8.0/bin/plugins. Also, I have NSIS installed, where is the<br>
>>>>> >> "PACKAGE" target in the VS Solution or is there another mechanism to<br>
>>>>> >> use to create the installer?<br>
>>>>> >> The other (probably more likely) possibility is that I didn't really<br>
>>>>> >> pull the 3.8.0 tag from git and instead have some other tag.<br>
>>>>> >><br>
>>>>> >> # On branch v3.8.0<br>
>>>>> >> # Changed but not updated:<br>
>>>>> >> # (use "git add <file>..." to update what will be committed)<br>
>>>>> >> # (use "git checkout -- <file>..." to discard changes in working<br>
>>>>> >> directory)<br>
>>>>> >> #<br>
>>>>> >> # modified: CMake/FindHDF5.cmake<br>
>>>>> >> #<br>
>>>>> >> # Untracked files:<br>
>>>>> >> # (use "git add <file>..." to include in what will be committed)<br>
>>>>> >> #<br>
>>>>> >> # .cproject<br>
>>>>> >> # .project<br>
>>>>> >> # Applications/ParaView/Testing/XML/Fractal3D.xml<br>
>>>>> >> # CMake/AdjustLibVars.cmake<br>
>>>>> >> # CMake/_FindHDF5.cmake<br>
>>>>> >> # i386/<br>
>>>>> >> # x64/<br>
>>>>> >> no changes added to commit (use "git add" and/or "git commit -a")<br>
>>>>> >><br>
>>>>> >> I just tried this with the ParaView 3.8.0 source code .zip file from<br>
>>>>> >> the <a href="http://paraview.org" target="_blank">paraview.org</a> web site and had the same results. I also built the<br>
>>>>> >> NSIS installer, and then actually ran the installer and the same issue<br>
>>>>> >> happens. Bug?<br>
>>>>> >> _________________________________________________________<br>
>>>>> >> Mike Jackson <a href="mailto:mike.jackson@bluequartz.net">mike.jackson@bluequartz.net</a><br>
>>>>> >> BlueQuartz Software <a href="http://www.bluequartz.net" target="_blank">www.bluequartz.net</a><br>
>>>>> >> Principal Software Engineer Dayton, Ohio<br>
>>>>> >> _______________________________________________<br>
>>>>> >> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>>>>> >><br>
>>>>> >> Visit other Kitware open-source projects at<br>
>>>>> >> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>>>>> >><br>
>>>>> >> Please keep messages on-topic and check the ParaView Wiki at:<br>
>>>>> >> <a href="http://paraview.org/Wiki/ParaView" target="_blank">http://paraview.org/Wiki/ParaView</a><br>
>>>>> >><br>
>>>>> >> Follow this link to subscribe/unsubscribe:<br>
>>>>> >> <a href="http://www.paraview.org/mailman/listinfo/paraview" target="_blank">http://www.paraview.org/mailman/listinfo/paraview</a><br>
>>>>> >><br>
>>>>> ><br>
>>>>> _______________________________________________<br>
>>>>> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>>>>><br>
>>>>> Visit other Kitware open-source projects at<br>
>>>>> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>>>>><br>
>>>>> Please keep messages on-topic and check the ParaView Wiki at:<br>
>>>>> <a href="http://paraview.org/Wiki/ParaView" target="_blank">http://paraview.org/Wiki/ParaView</a><br>
>>>>><br>
>>>>> Follow this link to subscribe/unsubscribe:<br>
>>>>> <a href="http://www.paraview.org/mailman/listinfo/paraview" target="_blank">http://www.paraview.org/mailman/listinfo/paraview</a><br>
>>>>><br>
>>>><br>
>>>><br>
>>> _______________________________________________<br>
>>> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>>><br>
>>> Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>>><br>
>>> Please keep messages on-topic and check the ParaView Wiki at: <a href="http://paraview.org/Wiki/ParaView" target="_blank">http://paraview.org/Wiki/ParaView</a><br>
>>><br>
>>> Follow this link to subscribe/unsubscribe:<br>
>>> <a href="http://www.paraview.org/mailman/listinfo/paraview" target="_blank">http://www.paraview.org/mailman/listinfo/paraview</a><br>
>>><br>
>><br>
><br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Please keep messages on-topic and check the ParaView Wiki at: <a href="http://paraview.org/Wiki/ParaView" target="_blank">http://paraview.org/Wiki/ParaView</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.paraview.org/mailman/listinfo/paraview" target="_blank">http://www.paraview.org/mailman/listinfo/paraview</a><br>
</div></div></blockquote></div><br>