Hi Dominik,<div><br></div><div>This patch request confuses me since currently we are not explicitly link to python unless it is enabled. The code currently in the pv branch of XDMF is:</div><div><br></div><div><div> IF(VTK_WRAP_PYTHON)</div>
<div> INCLUDE(${VTK_CMAKE_DIR}/vtkWrapPython.cmake OPTIONAL)</div><div> VTK_WRAP_PYTHON2(vtk${PROJECT_NAME}Python XdmfPython_SRCS ${Xdmf_SRCS})</div><div> VTK_ADD_LIBRARY(vtk${PROJECT_NAME}Python MODULE ${XdmfPython_SRCS} ${Xdmf_SRCS})</div>
<div> IF(VTK_USE_PARALLEL)</div><div> TARGET_LINK_LIBRARIES(vtk${PROJECT_NAME}Python vtkIOPythonD vtkRenderingPythonD vtkParallelPythonD Xdmf)</div><div> ELSE(VTK_USE_PARALLEL)</div><div> TARGET_LINK_LIBRARIES(vtk${PROJECT_NAME}Python vtkIOPythonD vtkRenderingPythonD Xdmf)</div>
<div> ENDIF(VTK_USE_PARALLEL)</div><div> ADD_DEPENDENCIES(vtk${PROJECT_NAME}Python vtk${PROJECT_NAME})</div><div> ENDIF(VTK_WRAP_PYTHON)</div><div><br><div class="gmail_quote">On Thu, Jun 9, 2011 at 11:10 AM, Dominik Szczerba <span dir="ltr"><<a href="mailto:dominik@itis.ethz.ch">dominik@itis.ethz.ch</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Dear all,<br>
<br>
I have just checked, the previously fix has not been integrated. Is<br>
there a reason? Currently there is a nice conditional, but afterwards<br>
vtkParallelPythonD is unconditionally linked anyway ;))<br>
Here again a patch against the latest git from git://<a href="http://paraview.org/Xdmf.git" target="_blank">paraview.org/Xdmf.git</a>.<br>
Can you please commit it or let me do it?<br>
<br>
Many thanks.<br>
<br>
--- CMakeLists.txt.orig.txt 2011-06-09 17:05:56.125816000 +0200<br>
+++ CMakeLists.txt 2011-06-09 17:00:59.844367200 +0200<br>
<div class="im">@@ -141,8 +141,6 @@<br>
ELSE(VTK_USE_PARALLEL)<br>
TARGET_LINK_LIBRARIES(vtk${PROJECT_NAME}Python vtkIOPythonD<br>
vtkRenderingPythonD Xdmf)<br>
ENDIF(VTK_USE_PARALLEL)<br>
- TARGET_LINK_LIBRARIES(vtk${PROJECT_NAME}Python vtkIOPythonD<br>
- vtkRenderingPythonD vtkParallelPythonD Xdmf)<br>
ADD_DEPENDENCIES(vtk${PROJECT_NAME}Python vtk${PROJECT_NAME})<br>
ENDIF(VTK_WRAP_PYTHON)<br>
ELSE(VTK_FOUND)<br>
<br>
<br>
</div><div><div></div><div class="h5">On Wed, Feb 23, 2011 at 11:08 PM, Dominik Szczerba <<a href="mailto:dominik@itis.ethz.ch">dominik@itis.ethz.ch</a>> wrote:<br>
> Hi Robert,<br>
><br>
> I just pulled the latest version to find an error again. I do not know<br>
> what went wrong, but here is a fix against the latest git version.<br>
><br>
> Regards,<br>
> Dominik<br>
><br>
> --- vtk/CMakeLists.txt.orig 2011-02-23 22:57:13.000000000 +0100<br>
> +++ vtk/CMakeLists.txt 2011-02-23 23:05:00.000000000 +0100<br>
> @@ -141,8 +141,6 @@<br>
> ELSE(VTK_USE_PARALLEL)<br>
> TARGET_LINK_LIBRARIES(vtk${PROJECT_NAME}Python vtkIOPythonD<br>
> vtkRenderingPythonD Xdmf)<br>
> ENDIF(VTK_USE_PARALLEL)<br>
> - TARGET_LINK_LIBRARIES(vtk${PROJECT_NAME}Python vtkIOPythonD<br>
> - vtkRenderingPythonD vtkParallelPythonD Xdmf)<br>
> ADD_DEPENDENCIES(vtk${PROJECT_NAME}Python vtk${PROJECT_NAME})<br>
> ENDIF(VTK_WRAP_PYTHON)<br>
> ELSE(VTK_FOUND)<br>
><br>
><br>
> On Fri, Jan 28, 2011 at 10:19 PM, Robert Maynard<br>
> <<a href="mailto:robert.maynard@kitware.com">robert.maynard@kitware.com</a>> wrote:<br>
>> Hi Dominik,<br>
>> Thanks for the updated patch, I just wanted to give you a heads up about the<br>
>> patch because I almost ignored your email since it was inverted.<br>
>> I committed your fix, and gave your authorship as you can see following the<br>
>> link.<br>
>> <a href="http://paraview.org/gitweb?p=Xdmf.git;a=commit;h=a3abadc1cd95b8b9ec4e96a4b94f496f2b937fb1" target="_blank">http://paraview.org/gitweb?p=Xdmf.git;a=commit;h=a3abadc1cd95b8b9ec4e96a4b94f496f2b937fb1</a><br>
>><br>
>> On Fri, Jan 28, 2011 at 4:09 PM, Dominik Szczerba <<a href="mailto:dominik@itis.ethz.ch">dominik@itis.ethz.ch</a>><br>
>> wrote:<br>
>>><br>
>>> Hi Robert,<br>
>>> Yes indeed, I am very sorry...<br>
>>> Corrected one attached. I also generated the patch now from the root<br>
>>> folder to make explicitly clear I want to modify vtk/CMakeLists.txt<br>
>>> and not the base one.<br>
>>> Regards,<br>
>>> Dominik<br>
>>><br>
>>> On Fri, Jan 28, 2011 at 9:25 PM, Robert Maynard<br>
>>> <<a href="mailto:robert.maynard@kitware.com">robert.maynard@kitware.com</a>> wrote:<br>
>>> > Hi Dominik,<br>
>>> > I will add this today to the pv branch of XDMF. In the future can you<br>
>>> > diff<br>
>>> > the other way, currently it looks like your patch removes non parallel<br>
>>> > compilation.<br>
>>> ><br>
>>> > On Fri, Jan 28, 2011 at 10:21 AM, Dominik Szczerba<br>
>>> > <<a href="mailto:dominik@itis.ethz.ch">dominik@itis.ethz.ch</a>><br>
>>> > wrote:<br>
>>> >><br>
>>> >> Please find attached a simple patch fixing compilation with no<br>
>>> >> parallel support. I would be happy if you could commit it to the<br>
>>> >> repository.<br>
>>> >> Thanks and best regards,<br>
>>> >> Dominik<br>
>>> >><br>
>>> >> _______________________________________________<br>
>>> >> Xdmf mailing list<br>
>>> >> <a href="mailto:Xdmf@lists.kitware.com">Xdmf@lists.kitware.com</a><br>
>>> >> <a href="http://www.kitware.com/cgi-bin/mailman/listinfo/xdmf" target="_blank">http://www.kitware.com/cgi-bin/mailman/listinfo/xdmf</a><br>
>>> >><br>
>>> ><br>
>>> ><br>
>>> ><br>
>>> > --<br>
>>> > Robert Maynard<br>
>>> ><br>
>><br>
>><br>
>><br>
>> --<br>
>> Robert Maynard<br>
>><br>
><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Robert Maynard<br>
</div></div>