I pushed a vtk topic branch to gerrit. The topic moves the debug leaks from from ViewsQt to GUISupportQt.<br><br><a href="http://review.source.kitware.com/#/t/1829/">http://review.source.kitware.com/#/t/1829/</a><br><br>I updated the 13024-debug-leaks-view branch on paraview stage. When the vtk topic goes from gerrit to master, then this branch can be added to paraview.<br>
<br>Pat<br><br><div class="gmail_quote">On Wed, Dec 5, 2012 at 10:19 PM, Pat Marion <span dir="ltr"><<a href="mailto:pat.marion@kitware.com" target="_blank">pat.marion@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi John,<br><br>Thanks for the patch! Actually, funny you should send this email... I just revived this this branch, 13024-debug-leaks-view, over the weekend. I encountered that same thing as you did, merge conflicts and an annoying dependency on vtkViewsQt.<br>
<br>Unfortunately, the vtkQtDebugLeaksView got moved into vtkViewsQt during
modularization, even though it doesn't have a dependency on vtkViews. I'll submit a patch to vtk to move the class into vtkGUISupportQt where I think it belongs, then I'll get 13024-debug-leaks-view merged into ParaView.<br>
<br>It's fine if you want to do work on moving dock panels around, I don't have any new development on the class planned.<div class="im"><br><br>> <span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Is it feasible to view debug leaks on remote nodes?<br>
<br></span></div>It would be feasible, and could be quite useful! Might not be the most straightforward to implement, though. Also, I'm not sure to what extent you use the python console in ParaView for debugging, but it's always been a dream of mine to add a feature that allows the python console to inspect remote objects on server nodes.<span class="HOEnZb"><font color="#888888"><br>
<br>Pat</font></span><div class="HOEnZb"><div class="h5"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><br><br></span><br><div class="gmail_quote">On Wed, Dec 5, 2012 at 3:46 AM, Biddiscombe, John A. <span dir="ltr"><<a href="mailto:biddisco@cscs.ch" target="_blank">biddisco@cscs.ch</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="white" link="blue" vlink="purple" lang="EN-GB">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">I’m replying on this thread, but my comments are really addressed to Pat.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Having made use of the memory inspector, I have memory leaks in my reader and wanted to track them down.
<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">I tried to merge in the DebugLeaksView<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><a href="http://public.kitware.com/Wiki/DebugLeaksView" target="_blank">http://public.kitware.com/Wiki/DebugLeaksView</a><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">helper which I thought would be nice to test. Using 3.98 I encountered conflicts and made a patch (though the conflicts I had might be caused by another tweak
I made locally). Anyway, attached it a new patchset to get the debug leaks going in 3.98<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">For wiki page : I had to turn on VTK_DEBUG_LEAKS (fairly obvious) and manually enable vtkViewsQt module or something like that.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">When compiling, lots of include paths were wrong so I just hard coded them and manually added vtkViewsQt.lib to the link line for paraview exe.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">The debug leaks window is really fabulous. I spent an hour tweaking my code and reduced my ref counts and spare objects by a full factor of two. Now I have
no leaks. <u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Feature request : Combine memory inspector and debug leaks into a single dock window. (Is it feasible to view debug leaks on remote nodes? – while running possibly,
but not at closedown I suppose).<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">I may have a play with the QtDebugLeaks stuff if you aren’t developing it any more to do the dock window combination changes.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Patches attached are not very useful as the VTK stuff isn’t included and it would only take you 2 minutes to do it yourself anyway. Mostly just wanted to bump
this thread in case someone was going to cleanly integrate the debugleaks in 3.98<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Thanks very much for both these memory management controls, really saved me a lot of work.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">JB<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<div>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal" style="margin-left:36.0pt"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext" lang="EN-US">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext" lang="EN-US">
Burlen Loring [mailto:<a href="mailto:bloring@lbl.gov" target="_blank">bloring@lbl.gov</a>] <br>
<b>Sent:</b> 01 December 2012 21:03<br>
<b>To:</b> Sebastien Jourdain<br>
<b>Cc:</b> Biddiscombe, John A.; <a href="mailto:paraview@paraview.org" target="_blank">paraview@paraview.org</a><br>
<b>Subject:</b> Re: [Paraview] new memory inspector panel documentation<u></u><u></u></span></p>
</div>
</div><div><div>
<p class="MsoNormal" style="margin-left:36.0pt"><u></u> <u></u></p>
<p class="MsoNormal" style="margin-left:36.0pt">Sebastien,<br>
<br>
Thanks for putting it in the right place. This morning I've merged the new docs with the old in the user guide to clean it up a bit. I wasn' t sure how important having a consitent look was (eg dialogs/windows in mac style), so I left the old images in the
source but commented out in case that is important to you guys.<br>
<br>
Burlen<br>
<br>
On 12/01/2012 11:51 AM, Sebastien Jourdain wrote: <u></u><u></u></p>
<p class="MsoNormal" style="margin-left:36.0pt">Thanks Burlen, <u></u><u></u></p>
<div>
<p class="MsoNormal" style="margin-left:36.0pt"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:36.0pt">I've moved your doc inside the User guide on the wiki. <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:36.0pt">I'll regenerate the PDF of the User Guide for the coming release which will include your contribution.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:36.0pt"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:36.0pt">Thanks again,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:36.0pt"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:36.0pt">Seb<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-right:0cm;margin-bottom:12.0pt;margin-left:36.0pt">
<u></u> <u></u></p>
<div>
<p class="MsoNormal" style="margin-left:36.0pt">On Sat, Dec 1, 2012 at 1:25 PM, Burlen Loring <<a href="mailto:bloring@lbl.gov" target="_blank">bloring@lbl.gov</a>> wrote:<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:36.0pt">Just wanted to mentioned that Utkarsh and Sebastien deserve a lot of credit for this too. Their help is always very much appreciated :-)
<u></u><u></u></p>
<div>
<div>
<p class="MsoNormal" style="margin-left:36.0pt"><br>
<br>
On 12/01/2012 08:59 AM, Burlen Loring wrote:<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:36.0pt">Hi John, Thanks! That's great to know, very glad to hear you've found it useful.<br>
<br>
Burlen<br>
<br>
<br>
<br>
On 12/01/2012 03:56 AM, Biddiscombe, John A. wrote:<br>
<br>
<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:36.0pt">Burlen<br>
<br>
The inspector is great and I've been using it extensively to monitor some of the big jobs I've run recently. It really helps knowing how much memory you've actually used on each node - and more importantly, how close you are to getting a job killed.<br>
<br>
Thanks for taking the time to contribute it.<br>
<br>
JB<br>
<br>
<br>
-----Original Message-----<br>
From: <a href="mailto:paraview-bounces@paraview.org" target="_blank">paraview-bounces@paraview.org</a> [mailto:<a href="mailto:paraview-bounces@paraview.org" target="_blank">paraview-bounces@paraview.org</a>] On Behalf Of burlen<br>
Sent: 01 December 2012 01:16<br>
To: <a href="mailto:paraview@paraview.org" target="_blank">paraview@paraview.org</a><br>
Subject: [Paraview] new memory inspector panel documentation<br>
<br>
Documentation for the new memory inspector panel can be found here:<br>
<br>
<a href="http://paraview.org/Wiki/ParaView/Memory_Inspector_Panel" target="_blank">http://paraview.org/Wiki/ParaView/Memory_Inspector_Panel</a><br>
<br>
The new panel reports per-process usage and provides some additional debugging tools. It should be available in the 3.98 release.<br>
<br>
Burlen<br>
<br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">
http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Please keep messages on-topic and check the ParaView Wiki at: <a href="http://paraview.org/Wiki/ParaView" target="_blank">
http://paraview.org/Wiki/ParaView</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.paraview.org/mailman/listinfo/paraview" target="_blank">http://www.paraview.org/mailman/listinfo/paraview</a><br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">
http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Please keep messages on-topic and check the ParaView Wiki at: <a href="http://paraview.org/Wiki/ParaView" target="_blank">
http://paraview.org/Wiki/ParaView</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.paraview.org/mailman/listinfo/paraview" target="_blank">http://www.paraview.org/mailman/listinfo/paraview</a><u></u><u></u></p>
<p class="MsoNormal" style="margin-left:36.0pt"><u></u> <u></u></p>
<p class="MsoNormal" style="margin-left:36.0pt"><br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">
http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Please keep messages on-topic and check the ParaView Wiki at: <a href="http://paraview.org/Wiki/ParaView" target="_blank">
http://paraview.org/Wiki/ParaView</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.paraview.org/mailman/listinfo/paraview" target="_blank">http://www.paraview.org/mailman/listinfo/paraview</a><u></u><u></u></p>
</div>
</div>
</div>
<p class="MsoNormal" style="margin-left:36.0pt"><u></u> <u></u></p>
</div>
<p class="MsoNormal" style="margin-left:36.0pt"><u></u> <u></u></p>
</div></div></div>
</div>
</blockquote></div><br>
</div></div></blockquote></div><br>