MantisBT - ParaView
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0012937ParaView(No Category)public2012-02-14 13:132013-01-10 22:45
ReporterSebastien Jourdain 
Assigned ToSebastien Jourdain 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version3.98.0 
ProjectTBD
Topic Name12937-undo-redo-zoom-to-box
Typeincorrect functionality
Summary0012937: Undo Redo not working for "Zoom to Box" action
DescriptionWhen the camera is modified each position is stored in a custom undo stack which is not the case when we call the "Zoom to Box" function.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-02-14 13:13Sebastien JourdainNew Issue
2012-02-14 13:13Sebastien JourdainAssigned To => Sebastiennn Jourdain
2012-02-14 13:13Sebastien JourdainStatusbacklog => todo
2012-02-14 13:14Sebastien JourdainStatustodo => active development
2012-02-14 14:13Sebastien JourdainTopic Name => 12937-undo-redo-zoom-to-box
2012-02-14 14:13Sebastien JourdainStatusactive development => gatekeeper review
2012-02-14 14:13Sebastien JourdainResolutionopen => fixed
2012-02-17 12:22Utkarsh AyachitFixed in Version => git-master
2012-02-17 12:22Utkarsh AyachitStatusgatekeeper review => customer review
2012-02-17 12:22Utkarsh AyachitNote Added: 0028286
2012-02-20 10:28Utkarsh AyachitFixed in Versiongit-master => 3.14
2012-04-12 20:51Alan ScottNote Added: 0028471
2012-07-18 20:51Alan ScottNote Added: 0028813
2012-07-18 20:51Alan ScottNote Added: 0028814
2012-07-18 20:51Alan ScottStatuscustomer review => todo
2012-07-19 08:18Sebastien JourdainNote Added: 0028841
2012-07-19 08:50Sebastien JourdainNote Added: 0028843
2012-10-30 09:11Sebastien JourdainNote Added: 0029593
2012-10-30 09:11Sebastien JourdainStatustodo => gatekeeper review
2012-10-31 10:46Utkarsh AyachitFixed in Version3.14 => 3.98.0
2012-10-31 10:47Utkarsh AyachitStatusgatekeeper review => customer review
2012-10-31 10:47Utkarsh AyachitNote Added: 0029611
2013-01-10 22:45Alan ScottNote Added: 0030092
2013-01-10 22:45Alan ScottStatuscustomer review => closed

Notes
(0028286)
Utkarsh Ayachit   
2012-02-17 12:22   
Merged into git-master, if applicable.
(0028471)
Alan Scott   
2012-04-12 20:51   
I just tested this, and it works with undo, but fails with redo. Alan.
(0028813)
Alan Scott   
2012-07-18 20:51   
This now doesn't undo at all.
(0028814)
Alan Scott   
2012-07-18 20:51   
Not working.
(0028841)
Sebastien Jourdain   
2012-07-19 08:18   
Hi Alan,

camera changes are not and should not be recorded in the regular Undo/Redo. Instead they are managed by the camera undo/redo that you can find on top of each window toolbar. And that's what is happening with the "Zoom to box" action, you can not Undo them, unless you undo by using those set of window related toolbar button.

Although, while double checking this morning, I've noticed that some RenderView related change get recorded, which seems to be a bug.

Please let me know if you still think it is not working.
(0028843)
Sebastien Jourdain   
2012-07-19 08:50   
Ok I've fixed some of the unwanted behavior here: http://www.paraview.org/Bug/view.php?id=13313 [^]

BUT, "Zoom to box" change the center of rotation (I don't know if this is intended or not), and that change get recorded in the main undo/redo stack as it is not a camera position related change.
 
So depending on what is expected for "Zoom to box" and the "Center of rotation", the behavior is the way it is supposed to be now.
(0029593)
Sebastien Jourdain   
2012-10-30 09:11   
Move forward to customer review....
(0029611)
Utkarsh Ayachit   
2012-10-31 10:47   
merged into master, if applicable.
(0030092)
Alan Scott   
2013-01-10 22:45   
Seems to work correctly.

Tested local server, Windows, master.