MantisBT - ParaView
View Issue Details

ID	Project	Category	View Status	Date Submitted	Last Update
0013093	ParaView	Feature	public	2012-04-13 10:34	2012-10-29 17:04

Reporter	Ian Curington
Assigned To	Sebastien Jourdain
Priority	high	Severity	minor	Reproducibility	have not tried
Status	closed	Resolution	fixed
Platform		OS		OS Version
Product Version	3.14.1
Target Version		Fixed in Version	3.98.0
Project	ParaViewPro
Topic Name	13262-non-orthogonal-source-plugin
Type	usability

Summary	0013093: Cube Axes Labelling Untransformed ranges
Description	PROBLEM: If mesh is transformed using Display tab (Z*10, etc) cube axes show only result of this transform, not original mesh coordinates in tics and labels. SOLUTION: Add additional option toggle, letting user set application specific context of tic labels, either transformed or untransformed. Make default transformed, so will not be disruptive change. PATCH: patched files: vtkCubeAxesRepresentation.[h,cxx], pqCubeAxesEditorDialog.cxx, pqCubeAxesEditorDialog.ui, views_and_representations.xml action: copy vtkCubeAxesRepresentation.[h,cxx] to ParaView-3.14.0/ParaViewCore/ClientServerCore copy pqCubeAxesEditorDialog.cxx to ParaView-3.14.0/Qt/Components copy pqCubeAxesEditorDialog.ui to ParaView-3.14.0/Qt/Components/Resources/UI copy views_and_representations.xml to ParaView-3.14.0/ParaViewCore/ServerImplementation/Resources DESCRIPTION: When we load terrain mesh, scale it along Z axis (e.g. x5) and turn on cube axes around that pipeline item, axes labels for Z axis range will also be scaled (x5). In case we want to represent terrain's elevation by using cube axes, or generally to represent original data's extent with axes, this scaling will make cube axes inappropriate. To fix this behavior, our patch adds new property, UnscaledTicks, which controls if tick labels on axes are generated from original data or from transformed representation. CHANGES: To make this patch, following changes were made (ParaView source patch): - vtkCubeAxesRepresentation.[h,cxx] - Added UnscaledTicks property and Set[XYZ]AxisRange() / SetBounds() logic depending on flag's value, - views_and_representations.xml - Added UnscaledTicks PQ property to vtkCubeAxesRepresentation class, - pqCubeAxesEditorDialog.ui - Added UnscaledTicks check-box to Cube Axes Editor Dialog, - pqCubeAxesEditorDialog.cxx - Added registering of PQ link between UnscaledTicks check box and representation property.
Steps To Reproduce
Additional Information
Tags	No tags attached.
Relationships
Attached Files	vtkCubeAxesRepresentation.h (6,038) 2012-04-13 10:34 https://www.vtk.org/Bug/file/9159/vtkCubeAxesRepresentation.h vtkCubeAxesRepresentation.cxx (14,077) 2012-04-13 10:35 https://www.vtk.org/Bug/file/9160/vtkCubeAxesRepresentation.cxx pqCubeAxesEditorDialog.cxx (7,687) 2012-04-13 10:35 https://www.vtk.org/Bug/file/9161/pqCubeAxesEditorDialog.cxx pqCubeAxesEditorDialog.ui (16,465) 2012-04-13 10:36 https://www.vtk.org/Bug/file/9162/pqCubeAxesEditorDialog.ui views_and_representations.xml (173,524) 2012-04-13 10:36 https://www.vtk.org/Bug/file/9163/views_and_representations.xml

Issue History
Date Modified	Username	Field	Change
2012-04-13 10:34	Ian Curington	New Issue
2012-04-13 10:34	Ian Curington	File Added: vtkCubeAxesRepresentation.h
2012-04-13 10:35	Ian Curington	File Added: vtkCubeAxesRepresentation.cxx
2012-04-13 10:35	Ian Curington	File Added: pqCubeAxesEditorDialog.cxx
2012-04-13 10:36	Ian Curington	File Added: pqCubeAxesEditorDialog.ui
2012-04-13 10:36	Ian Curington	File Added: views_and_representations.xml
2012-04-23 10:37	Utkarsh Ayachit	Category	(No Category) => Feature
2012-04-23 10:41	Utkarsh Ayachit	Project	TBD => ParaViewPro
2012-06-07 17:15	Lawrence	Note Added: 0028677
2012-06-07 17:47	Lawrence	Note Edited: 0028677	bug_revision_view_page.php?bugnote_id=28677#r450
2012-06-25 13:36	Cory Quammen	Note Added: 0028720
2012-07-05 17:02	Lawrence	Note Added: 0028745
2012-07-11 15:44	Lawrence	Note Added: 0028765
2012-07-12 16:42	Sebastien Jourdain	Assigned To	=> Sebastien Jourdain
2012-07-12 16:42	Sebastien Jourdain	Status	backlog => todo
2012-07-12 16:42	Sebastien Jourdain	Status	todo => active development
2012-07-12 16:43	Sebastien Jourdain	Topic Name	=> 13262-non-orthogonal-source-plugin
2012-07-12 16:43	Sebastien Jourdain	Status	active development => gatekeeper review
2012-07-12 16:43	Sebastien Jourdain	Resolution	open => fixed
2012-07-12 16:45	Sebastien Jourdain	Note Added: 0028769
2012-07-13 10:41	Utkarsh Ayachit	Fixed in Version	=> git-master
2012-07-13 10:41	Utkarsh Ayachit	Status	gatekeeper review => customer review
2012-07-13 10:41	Utkarsh Ayachit	Note Added: 0028774
2012-07-13 16:49	Lawrence	Note Added: 0028780
2012-07-13 16:54	Sebastien Jourdain	Note Added: 0028781
2012-07-16 12:42	Lawrence	Note Added: 0028782
2012-07-18 17:02	Ian Curington	Note Added: 0028796
2012-07-19 10:50	Sebastien Jourdain	Note Added: 0028846
2012-07-19 10:50	Sebastien Jourdain	Status	customer review => gatekeeper review
2012-07-19 10:50	Sebastien Jourdain	Status	gatekeeper review => active development
2012-07-19 10:50	Sebastien Jourdain	Status	active development => gatekeeper review
2012-07-20 11:42	Ian Curington	Note Added: 0028889
2012-07-24 10:48	Utkarsh Ayachit	Status	gatekeeper review => customer review
2012-07-24 10:48	Utkarsh Ayachit	Note Added: 0028899
2012-07-25 16:53	Alan Scott	Note Added: 0028937
2012-07-25 16:53	Alan Scott	Status	customer review => closed
2012-10-29 17:04	Utkarsh Ayachit	Fixed in Version	git-master => 3.98.0

Notes

Ouch. From the description above, I'm concerned this is not sufficient to automatically proper axes display of scaled and translated geographic surfaces. Please can I suggest the following alternative fix is sufficient to handle scaled and translated objects.
NB Rotated and scaled objects cannot be supported until VTK object-(rotate)-aligned axis is ready.

The following fix has been tested with wavelet source translated AND/OR scaled with default and CUSTOM bounds.

void vtkCubeAxesRepresentation::UpdateBounds()
{
  double *scale = this->Scale;
  double *position = this->Position;
  double *rotation = this->Orientation;

  double unscaledBounds[6];
  double transformedBounds[6];

  this->GetDataBounds(unscaledBounds);
  for(int i = 0;i < 6; i++)
      {
      if(this->CustomBoundsActive[ i / 2 ])
        {
        unscaledBounds[i] = this->CustomBounds[i];
        }
    }

  vtkSmartPointer<vtkTransform> transform =
      vtkSmartPointer<vtkTransform>::New();
  transform->Translate(position);
  transform->RotateZ(rotation[2]);
  transform->RotateX(rotation[0]);
  transform->RotateY(rotation[1]);
  transform->Scale(scale);
  vtkBoundingBox bbox;
  int i, j, k;
  double origX[3], x[3];
  // Visit all 8 corners of the transformed bounding box
  // NB This code will be unnecessary once axes can be aligned with rotated objects
  for (i = 0; i < 2; i++)
  {
      origX[0] = unscaledBounds[i];
      for (j = 0; j < 2; j++)
      {
          origX[1] = unscaledBounds[2 + j];
          for (k = 0; k < 2; k++)
          {
              origX[2] = unscaledBounds[4 + k];
              transform->TransformPoint(origX, x);
              bbox.AddPoint(x);
          }
      }
  }
  bbox.GetBounds(transformedBounds);

  this->CubeAxesActor->SetBounds(transformedBounds);
  if(UseBoundsRangeAsLabel)
    {
// vtkPrismCubeAxesRepresentation explicitly sets the bounds and sets UseBoundsRangeAsLabel to false
// Use the original (unscaled, untranslated) object range as the axes range to display
    this->CubeAxesActor->SetXAxisRange(&unscaledBounds[0]);
    this->CubeAxesActor->SetYAxisRange(&unscaledBounds[2]);
    this->CubeAxesActor->SetZAxisRange(&unscaledBounds[4]);
    }
}