MantisBT - ParaView
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013655ParaView(No Category)public2012-11-13 17:272015-01-11 08:32
ReporterOrion Poplawski 
Assigned ToUtkarsh Ayachit 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version3.98.0 
ProjectTBD
Topic Name13655_fix_hdf5_include
Typeincorrect functionality
Summary0013655: Include H5public.h instead of H5pubconf.h
DescriptionVTK/ThirdParty/xdmf2/vtkxdmf2/libsrc/XdmfH5Driver.h still includes H5pubconf.h instead of H5public.h. From H5public.h:

/* Include files for public use... */
/*
 * Since H5pubconf.h is a generated header file, it is messy to try
 * to put a #ifndef _H5pubconf_H ... #endif guard in it.
 * HDF5 has set an internal rule that it is being included here.
 * Source files should NOT include H5pubconf.h directly but include
 * it via H5public.h. The #ifndef _H5public_H guard above would
 * prevent repeated include.
 */
#include "H5pubconf.h" /*from configure */

Fedora renames H5pubconf.h to H5pubconf-{32,64}.h to support multilib installs.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-11-13 17:27Orion PoplawskiNew Issue
2012-11-16 00:11Utkarsh AyachitAssigned To => Utkarsh Ayachit
2012-11-16 00:11Utkarsh AyachitStatusbacklog => tabled
2012-11-16 00:12Utkarsh AyachitProjectVTK => ParaView
2012-11-16 00:22Utkarsh AyachitTopic Name => 13655_fix_hdf5_include
2012-11-16 00:22Utkarsh AyachitNote Added: 0029731
2012-11-16 00:22Utkarsh AyachitStatustabled => gatekeeper review
2012-11-16 00:22Utkarsh AyachitFixed in Version => git-next
2012-11-16 00:22Utkarsh AyachitResolutionopen => fixed
2012-11-20 12:16Kyle LutzStatusgatekeeper review => customer review
2012-11-20 12:16Kyle LutzNote Added: 0029765
2012-11-20 16:01Utkarsh AyachitFixed in Versiongit-next => git-master
2012-11-23 11:34Utkarsh AyachitFixed in Versiongit-master => 3.98.0
2013-01-10 20:44Alan ScottNote Added: 0030075
2013-01-10 20:44Alan ScottStatuscustomer review => closed
2015-01-09 14:04Kyle LutzSource_changeset_attached => VTK master 8d098410
2015-01-09 14:05Utkarsh AyachitSource_changeset_attached => VTK master acec1267
2015-01-09 14:07Dave DeMarleSource_changeset_attached => VTK master 4b7b1394
2015-01-11 08:31Kyle LutzSource_changeset_attached => ParaView master 76b93d53
2015-01-11 08:32Utkarsh AyachitSource_changeset_attached => ParaView master 4c51588a

Notes
(0029731)
Utkarsh Ayachit   
2012-11-16 00:22   
commit acec1267caf591998f0ebeab0d02b178bb0dc5d0
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Fri Nov 16 00:16:56 2012 -0500

    BUG 0013655: Fix include to use H5public instead of H5pubconf.
    
    H5public.h must be used instead of H5pubconf.h, based on documentation in
    H5public.h. Fixing accordingly.
    
    Change-Id: Ie868707e28b5487cda77fe40b71630241e3bf4f2
(0029765)
Kyle Lutz   
2012-11-20 12:16   
Merged into ParaView-master (if applicable)
(0030075)
Alan Scott   
2013-01-10 20:44   
Developer tag in Git. Closing.