MantisBT - ParaView
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014279ParaView(No Category)public2013-09-16 13:072015-01-11 08:16
ReporterUtkarsh Ayachit 
Assigned ToUtkarsh Ayachit 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version4.0 
Target Version4.2Fixed in Version4.2 
ProjectKitware
Topic Name14279_fix_rand_on_windows_attempt_2
Typeincorrect functionality
Summary0014279: Glyph filter producing different results on OsX and Windows.
DescriptionCheck the attached images produces on OsX and Windows using data in Archive.zip (check with Utkarsh for the dataset).
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
has duplicate 0014923closed Utkarsh Ayachit Illustration of glyphs 
Attached Filespng Windows_401.png (52,907) 2013-09-16 13:07
https://www.vtk.org/Bug/file/9524/Windows_401.png
png

png OSX_401.png (74,905) 2013-09-16 13:08
https://www.vtk.org/Bug/file/9525/OSX_401.png
png
Issue History
Date ModifiedUsernameFieldChange
2013-09-16 13:07Utkarsh AyachitNew Issue
2013-09-16 13:07Utkarsh AyachitFile Added: Windows_401.png
2013-09-16 13:08Utkarsh AyachitFile Added: OSX_401.png
2013-09-16 13:08Utkarsh AyachitTarget Version => 4.1
2014-02-07 21:47Utkarsh AyachitTarget Version4.1 => 4.2
2014-06-08 17:33Utkarsh AyachitAssigned To => George Zagaris
2014-06-08 17:33Utkarsh AyachitNote Added: 0032779
2014-07-05 21:25Utkarsh AyachitAssigned ToGeorge Zagaris => Cory Quammen
2014-07-22 22:24Utkarsh AyachitAssigned ToCory Quammen => Utkarsh Ayachit
2014-07-31 13:08Utkarsh AyachitStatusbacklog => todo
2014-08-01 20:22Utkarsh AyachitNote Deleted: 0032779
2014-08-02 17:51Utkarsh AyachitTopic Name => 14279_fix_rand_on_windows
2014-08-02 17:51Utkarsh AyachitNote Added: 0033177
2014-08-02 17:51Utkarsh AyachitStatustodo => gatekeeper review
2014-08-02 17:51Utkarsh AyachitFixed in Version => git-next
2014-08-02 17:51Utkarsh AyachitResolutionopen => fixed
2014-08-02 17:54Utkarsh AyachitNote Added: 0033178
2014-08-04 10:12Utkarsh AyachitFixed in Versiongit-next => git-master
2014-08-04 10:12Utkarsh AyachitStatusgatekeeper review => customer review
2014-08-04 10:12Utkarsh AyachitNote Added: 0033180
2014-08-04 10:13Utkarsh AyachitNote Added: 0033181
2014-08-13 11:17Utkarsh AyachitRelationship addedhas duplicate 0014923
2014-08-19 11:00Utkarsh AyachitStatuscustomer review => todo
2014-08-19 11:00Utkarsh AyachitTopic Name14279_fix_rand_on_windows => 14279_fix_rand_on_windows_attempt_2
2014-08-19 11:00Utkarsh AyachitNote Added: 0033253
2014-08-19 11:00Utkarsh AyachitStatustodo => gatekeeper review
2014-08-20 08:45Utkarsh AyachitStatusgatekeeper review => customer review
2014-08-20 08:45Utkarsh AyachitNote Added: 0033274
2014-08-29 10:59Utkarsh AyachitFixed in Versiongit-master => 4.2
2014-11-06 20:35Alan ScottNote Added: 0033779
2014-11-06 20:35Alan ScottStatuscustomer review => closed
2015-01-11 08:16Utkarsh AyachitSource_changeset_attached => ParaView master 19b0565f
2015-01-11 08:16Utkarsh AyachitSource_changeset_attached => ParaView master 069f1024

Notes
(0033177)
Utkarsh Ayachit   
2014-08-02 17:51   
commit 340d1bae94100b8f459680ca8d0c15fbab0e8e1d
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Sat Aug 2 17:48:37 2014 -0400

    BUG 0014279. Fix random glyphs on Windows.
    
    BUG 0014279 was encountered because the code that used rand() didn't not
    take into consideration that the int value returned by rand() may be
    less than the number of point ids in the dataset. On Windows, is was
    indeed limited to 32767 (on unixes, it wasn't that low). Thus resulted
    in the rand point ids selected being limited to that range.
    Fixed that.
    
    Change-Id: Ifd0e13cdba8404776a2388e2c5c3f68c6889a8ca
(0033178)
Utkarsh Ayachit   
2014-08-02 17:54   
Alan, you can test this out without the actual data by simply creating a large dataset with more than 32767 points e.g. Wavelet with extents 0, 64, 0, 64, 0, 64.
(0033180)
Utkarsh Ayachit   
2014-08-04 10:12   
SUMMARY
---------------------------------------------
Topics merged into master:
(VTK) 14279_glyph_filter
(VTK) fix_invalid_socket_check
(0033181)
Utkarsh Ayachit   
2014-08-04 10:13   
Alan,

This Glyph filter was entirely revamped. However this old version of the filter is still available as "Legacy Glyph". To test this fix, you should use that filter instead of the "Glyph".
(0033253)
Utkarsh Ayachit   
2014-08-19 11:00   
commit 069f1024a6807380b43ead6cf0e9e97bdf92cf01
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Tue Aug 19 10:58:31 2014 -0400

    BUG 0014279. Fix random glyphs on Windows.
    
    BUG 0014279 was encountered because the code that used rand() didn't not
    take into consideration that the int value returned by rand() may be
    less than the number of point ids in the dataset. On Windows, is was
    indeed limited to 32767 (on unixes, it wasn't that low). Thus resulted
    in the rand point ids selected being limited to that range.
    Fixed that.
    
    Change-Id: Ifd0e13cdba8404776a2388e2c5c3f68c6889a8ca
(0033274)
Utkarsh Ayachit   
2014-08-20 08:45   
SUMMARY
---------------------------------------------
Topics merged into master:
        14279_fix_rand_on_windows_attempt_2
        14813_fix_mode_shapes_range
        catalyst-updates


---------------------------------------------
Topics reverted from next:
  catalyst-script-plugin-client
(0033779)
Alan Scott   
2014-11-06 20:35   
Tested as per Utkarsh's directions below. Tested Linux, master, local server.