MantisBT - ParaView
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015442ParaView(No Category)public2015-04-30 11:562016-07-13 11:38
ReporterOrion Poplawski 
Assigned ToBen Boeckel (Kitware) 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version4.3 
Target VersionFixed in Version 
ProjectTBD
Topic Name
Typeincorrect functionality
Summary0015442: paraview fails to compile against protobuf 2.6.1
DescriptionFedora has updated protobuf to 2.6.1 causing paraview builds to fail. Initial issue with proto file compilation is fixed here:

https://gitlab.kitware.com/paraview/paraview/merge_requests/52 [^]

but compile still fails with:


/builddir/build/BUILD/ParaView-v4.3.1-source/ParaViewCore/ServerManager/Rendering/vtkSMCameraLink.cxx: In member function 'virtual void vtkSMCameraLink::UpdateState()':
/builddir/build/BUILD/ParaView-v4.3.1-source/ParaViewCore/ServerManager/Rendering/vtkSMCameraLink.cxx:367:45: error: no matching function for call to 'paraview_protobuf::Message::GetExtension(google::protobuf::internal::ExtensionIdentifier<paraview_protobuf::Message, google::protobuf::internal::PrimitiveTypeTraits<bool>, 8u, false>&, int)'
     this->GetSynchronizeInteractiveRenders());
                                             ^
In file included from /builddir/build/BUILD/ParaView-v4.3.1-source/fedora/ParaViewCore/ServerImplementation/Core/vtkPVMessage.pb.h:25:0,
                 from /builddir/build/BUILD/ParaView-v4.3.1-source/ParaViewCore/ServerImplementation/Core/vtkSMMessage.h:30,
                 from /builddir/build/BUILD/ParaView-v4.3.1-source/ParaViewCore/ServerManager/Rendering/vtkSMCameraLink.cxx:24:
/builddir/build/BUILD/ParaView-v4.3.1-source/fedora/ParaViewCore/ServerImplementation/Core/vtkPVMessage.pb.h:608:3: note: candidate: template<class _proto_TypeTraits, unsigned char _field_type, bool _is_packed> typename _proto_TypeTraits::Singular::ConstType paraview_protobuf::Message::GetExtension(const google::protobuf::internal::ExtensionIdentifier<paraview_protobuf::Message, _proto_TypeTraits, _field_type, _is_packed>&) const
   GOOGLE_PROTOBUF_EXTENSION_ACCESSORS(Message)
   ^
/builddir/build/BUILD/ParaView-v4.3.1-source/fedora/ParaViewCore/ServerImplementation/Core/vtkPVMessage.pb.h:608:3: note: template argument deduction/substitution failed:
/builddir/build/BUILD/ParaView-v4.3.1-source/ParaViewCore/ServerManager/Rendering/vtkSMCameraLink.cxx:367:45: note: candidate expects 1 argument, 2 provided
     this->GetSynchronizeInteractiveRenders());
                                             ^
In file included from /builddir/build/BUILD/ParaView-v4.3.1-source/fedora/ParaViewCore/ServerImplementation/Core/vtkPVMessage.pb.h:25:0,
                 from /builddir/build/BUILD/ParaView-v4.3.1-source/ParaViewCore/ServerImplementation/Core/vtkSMMessage.h:30,
                 from /builddir/build/BUILD/ParaView-v4.3.1-source/ParaViewCore/ServerManager/Rendering/vtkSMCameraLink.cxx:24:
/builddir/build/BUILD/ParaView-v4.3.1-source/fedora/ParaViewCore/ServerImplementation/Core/vtkPVMessage.pb.h:608:3: note: candidate: template<class _proto_TypeTraits, unsigned char _field_type, bool _is_packed> typename _proto_TypeTraits::Repeated::ConstType paraview_protobuf::Message::GetExtension(const google::protobuf::internal::ExtensionIdentifier<paraview_protobuf::Message, _proto_TypeTraits, _field_type, _is_packed>&, int) const
   GOOGLE_PROTOBUF_EXTENSION_ACCESSORS(Message)
   ^
/builddir/build/BUILD/ParaView-v4.3.1-source/fedora/ParaViewCore/ServerImplementation/Core/vtkPVMessage.pb.h:608:3: note: template argument deduction/substitution failed:
/builddir/build/BUILD/ParaView-v4.3.1-source/fedora/ParaViewCore/ServerImplementation/Core/vtkPVMessage.pb.h: In substitution of 'template<class _proto_TypeTraits, unsigned char _field_type, bool _is_packed> typename _proto_TypeTraits::Repeated::ConstType paraview_protobuf::Message::GetExtension(const google::protobuf::internal::ExtensionIdentifier<paraview_protobuf::Message, _proto_TypeTraits, _field_type, _is_packed>&, int) const [with _proto_TypeTraits = google::protobuf::internal::PrimitiveTypeTraits<bool>; unsigned char _field_type = 8u; bool _is_packed = false]':
/builddir/build/BUILD/ParaView-v4.3.1-source/ParaViewCore/ServerManager/Rendering/vtkSMCameraLink.cxx:367:45: required from here
/builddir/build/BUILD/ParaView-v4.3.1-source/fedora/ParaViewCore/ServerImplementation/Core/vtkPVMessage.pb.h:608:3: error: no type named 'Repeated' in 'class google::protobuf::internal::PrimitiveTypeTraits<bool>'
/usr/bin/cmake -E cmake_progress_report /builddir/build/BUILD/ParaView-v4.3.1-source/fedora/CMakeFiles
ParaViewCore/ServerManager/Rendering/CMakeFiles/vtkPVServerManagerRendering.dir/build.make:199: recipe for target 'ParaViewCore/ServerManager/Rendering/CMakeFiles/vtkPVServerManagerRendering.dir/vtkSMCameraLink.cxx.o' failed
/usr/bin/cmake -E cmake_progress_report /builddir/build/BUILD/ParaView-v4.3.1-source/fedora/CMakeFiles
make[2]: *** [ParaViewCore/ServerManager/Rendering/CMakeFiles/vtkPVServerManagerRendering.dir/vtkSMCameraLink.cxx.o] Error 1

Full build logs here:
https://kojipkgs.fedoraproject.org//work/tasks/5991/9595991/build.log [^]
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-04-30 11:56Orion PoplawskiNew Issue
2015-07-28 12:05Orion PoplawskiNote Added: 0034847
2015-08-14 23:51Orion PoplawskiNote Added: 0034997
2015-09-18 14:03Ben Boeckel (Kitware)Assigned To => Ben Boeckel (Kitware)
2015-09-18 14:24Ben Boeckel (Kitware)Note Added: 0035234
2015-09-18 14:24Ben Boeckel (Kitware)Statusbacklog => active development
2016-07-13 11:38Ben Boeckel (Kitware)Note Added: 0036363
2016-07-13 11:38Ben Boeckel (Kitware)Statusactive development => customer review
2016-07-13 11:38Ben Boeckel (Kitware)Resolutionopen => fixed
2016-07-13 11:38Ben Boeckel (Kitware)Statuscustomer review => closed

Notes
(0034847)
Orion Poplawski   
2015-07-28 12:05   
Any chance we could get some more movement on this? Fedora 23 has branched and we're trying to stabilize it. But paraview still cannot build due to these errors. Thanks.
(0034997)
Orion Poplawski   
2015-08-14 23:51   
First part of the fix - https://gitlab.kitware.com/ben.boeckel/paraview/commit/40a62e0bd20ceb73d7a545dab73e975fa07cddbb [^]

Rest of it I think needs to be:

diff -up ParaView-v4.3.1-source/ParaViewCore/ServerManager/Rendering/vtkSMCameraLink.cxx.protobuf ParaView-v4.3.1-source/ParaViewCore/ServerManager/Rendering/vtkSMCameraLink.cxx
--- ParaView-v4.3.1-source/ParaViewCore/ServerManager/Rendering/vtkSMCameraLink.cxx.protobuf 2015-01-14 06:07:33.000000000 -0700
+++ ParaView-v4.3.1-source/ParaViewCore/ServerManager/Rendering/vtkSMCameraLink.cxx 2015-08-14 20:55:11.571171848 -0600
@@ -363,6 +363,6 @@ void vtkSMCameraLink::LoadState(const vt
 void vtkSMCameraLink::UpdateState()
 {
   this->Superclass::UpdateState();
- this->State->GetExtension(LinkState::sync_interactive_renders,
+ this->State->SetExtension(LinkState::sync_interactive_renders,
     this->GetSynchronizeInteractiveRenders());
 }

As this looks like it should be a Set action rather than a Get action. This has been this way since its introduction in 2012.
(0035234)
Ben Boeckel (Kitware)   
2015-09-18 14:24   
Build is finishing up now; will see how the pvcs and pvcrs tests do with it.
(0036363)
Ben Boeckel (Kitware)   
2016-07-13 11:38   
`megas` now tests protobuf 2.6.1 and tests are passing.