MantisBT - ParaView
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0009133ParaViewBugpublic2009-06-10 13:562010-05-04 20:02
ReporterKen Moreland 
Assigned ToKen Moreland 
PriorityimmediateSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version3.8Fixed in Version3.10 
Project
Topic Name
Type
Summary0009133: Wireframe for quadratic faces is wrong
DescriptionWhen you turn on the wireframe for a data set that has quadratic elements, you get lines for all the internal edges created for the approximation. The wireframe should just be the lines around the actual cells.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0009132closed Ken Moreland Ability to control subdivision of quadratic faces 
related to 0010676closed Ken Moreland Wireframe for quadratic faces still wrong for client/server 
related to 0010677closed Ken Moreland Internal fields for rendering quadratic surfaces exposed 
Attached Filespatch NonlinearSubdivisions4.patch (55,821) 2009-06-10 18:26
https://www.vtk.org/Bug/file/7312/NonlinearSubdivisions4.patch
patch NonlinearSubdivisions6.patch (83,364) 2009-06-12 15:08
https://www.vtk.org/Bug/file/7321/NonlinearSubdivisions6.patch
patch NonlinearSubdivisions9.patch (95,916) 2010-01-22 12:01
https://www.vtk.org/Bug/file/7796/NonlinearSubdivisions9.patch
patch NonlinearSurface10.VTK.patch (63,517) 2010-04-21 17:03
https://www.vtk.org/Bug/file/8046/NonlinearSurface10.VTK.patch
patch NonlinearSurface10.ParaView.patch (37,736) 2010-04-21 17:03
https://www.vtk.org/Bug/file/8047/NonlinearSurface10.ParaView.patch
patch NonlinearSurface11.VTK.patch (58,621) 2010-04-22 20:07
https://www.vtk.org/Bug/file/8058/NonlinearSurface11.VTK.patch
patch NonlinearSurface11.ParaView.patch (72,664) 2010-04-22 20:08
https://www.vtk.org/Bug/file/8059/NonlinearSurface11.ParaView.patch
Issue History
Date ModifiedUsernameFieldChange
2009-06-10 13:56Ken MorelandNew Issue
2009-06-10 13:56Ken MorelandStatusbacklog => tabled
2009-06-10 13:56Ken MorelandAssigned To => Ken Moreland
2009-06-10 13:56Ken MorelandRelationship addedrelated to 0009132
2009-06-10 18:26Ken MorelandFile Added: NonlinearSubdivisions4.patch
2009-06-10 18:29Ken MorelandNote Added: 0016700
2009-06-12 15:08Ken MorelandFile Added: NonlinearSubdivisions6.patch
2009-06-12 16:11Ken MorelandNote Added: 0016719
2010-01-22 12:02Ken MorelandFile Added: NonlinearSubdivisions9.patch
2010-01-22 12:02Ken MorelandAssigned ToKen Moreland => Utkarsh Ayachit
2010-01-22 12:06Ken MorelandNote Added: 0019272
2010-02-04 13:03Utkarsh AyachitPrioritynormal => immediate
2010-02-10 09:34Utkarsh AyachitAssigned ToUtkarsh Ayachit => Berk Geveci
2010-03-01 10:27Utkarsh AyachitAssigned ToBerk Geveci => Will Schroeder
2010-04-21 17:03Ken MorelandFile Added: NonlinearSurface10.VTK.patch
2010-04-21 17:03Ken MorelandFile Added: NonlinearSurface10.ParaView.patch
2010-04-21 17:09Ken MorelandNote Added: 0020339
2010-04-22 20:07Ken MorelandFile Added: NonlinearSurface11.VTK.patch
2010-04-22 20:08Ken MorelandFile Added: NonlinearSurface11.ParaView.patch
2010-04-22 20:09Ken MorelandNote Added: 0020368
2010-04-27 12:52Ken MorelandAssigned ToWill Schroeder => Ken Moreland
2010-04-27 12:54Ken MorelandNote Added: 0020430
2010-04-27 12:54Ken MorelandStatustabled => @80@
2010-04-27 12:54Ken MorelandFixed in Version => 3.10
2010-04-27 12:54Ken MorelandResolutionopen => fixed
2010-05-04 20:02Alan ScottNote Added: 0020573
2010-05-04 20:02Alan ScottStatus@80@ => closed
2010-05-05 10:24Ken MorelandRelationship addedrelated to 0010676
2010-05-05 10:29Ken MorelandRelationship addedrelated to 0010677

Notes
(0016700)
Ken Moreland   
2009-06-10 18:29   
I've attached a patch that I think gets through about 75% of the work. It subdivides nonlinear faces to a chosen level (really bug 0009132) and then extracts an appropriate wireframe for the tessellated faces. There is some wiring to fix up (it does the wireframe all the time right now), but that should not be too hard. The part that I am struggling with is how to show only the "front" facing lines.
(0016719)
Ken Moreland   
2009-06-12 16:11   
The latest patch (NonlinearSubdivisions6.patch) mostly resolves the problem. Rendering wireframe with edges mode works pretty well. Simple wireframe mode is still showing all edges (not sure why). The approach is slightly different than that in the previous patch. To get rid of the extra edges, an edge flag is added to the point data. I had to change some painter code to support edge flags (which are supported by OpenGL 1.1).

Selecting nonlinear cells is also broken in this patch.
(0019272)
Ken Moreland   
2010-01-22 12:06   
The work is done! Because the changes touch some core classes, I am waiting for someone at Kitware to review the changes. I am assigning this bug to Utkarsh so that he can review the changes. When/if he approves them, he can assign the bug back to me and I will check in the code.

The latest patch, NonlinearSubdivisions9.patch, contains all the necessary changes. I also have the code waiting in a github repository if that is easier. The URL for the repository is <git://github.com/kmorel/ParaView.git> [^] and the change is in the branch <NonlinearSurface>. You can see a summary on this github.com page.

http://github.com/kmorel/ParaView/tree/NonlinearSurface [^]
(0020339)
Ken Moreland   
2010-04-21 17:09   
Due to the transition from CVS to git and other changes to files, I have uploaded new patches. Because ParaView and VTK are now separate modules and the changes span both, I have attached a separate patch for each of them. I have also created new repositories on github for direct git access.

http://github.com/kmorel/VTK-NonlinearSurface [^]
http://github.com/kmorel/ParaView-NonlinearSurface [^]
(0020368)
Ken Moreland   
2010-04-22 20:09   
Odd. I must have done a diff against the wrong git commit the last time I made the patches. Attached are new versions. Also including VTK_POLYHEDRON as a linear cell type.
(0020430)
Ken Moreland   
2010-04-27 12:54   
Pushed changes to the central repository.

VTK commits:
http://vtk.org/gitweb?p=VTK.git;a=commit;h=175efdc2937b89cef01f10cc6fbd0f2b3c1e313f [^]
http://vtk.org/gitweb?p=VTK.git;a=commit;h=b1778f69d6c38b828f7e28d7d43662084a15d320 [^]

ParaView commits:
http://paraview.org/gitweb?p=ParaView.git;a=commit;h=61f83397853c4a4c351ca8168e6d978b953b50e0 [^]
(0020573)
Alan Scott   
2010-05-04 20:02   
Tested local server, trunk, Windows.