MantisBT - ParaView
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002655ParaView(No Category)public2005-12-19 10:542009-12-09 14:51
ReporterKen Moreland 
Assigned ToUtkarsh Ayachit 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Project
Topic Name
Type
Summary0002655: SNL: Client/server state saved wrong
DescriptionWhen in client server mode, critical commands are missing in the pvs files written when "Save Session State" is selected. In standalone mode, the first few lines to set the state of glyphs looks something like this:

# Glyph Sources
set kw(vtkTemp876) [$kw(vtkTemp2) GetPVSource GlyphSources Arrow0]
set kw(vtkTemp877) [$kw(vtkTemp876) GetPVWidget {TipResolution}]
$kw(vtkTemp877) SetValue 6
set kw(vtkTemp883) [$kw(vtkTemp876) GetPVWidget {TipRadius}]
$kw(vtkTemp883) SetValue 0.1
set kw(vtkTemp889) [$kw(vtkTemp876) GetPVWidget {TipLength}]
$kw(vtkTemp889) SetValue 0.35
set kw(vtkTemp895) [$kw(vtkTemp876) GetPVWidget {ShaftResolution}]
$kw(vtkTemp895) SetValue 6
set kw(vtkTemp901) [$kw(vtkTemp876) GetPVWidget {ShaftRadius}]
$kw(vtkTemp901) SetValue 0.03
$kw(vtkTemp876) AcceptCallback


When you save the state in client/server mode, the set kw(vtkTemp*) commands are missing.

$kw(vtkTemp893) SetValue 6
$kw(vtkTemp899) SetValue 0.1
$kw(vtkTemp905) SetValue 0.35
$kw(vtkTemp911) SetValue 6
$kw(vtkTemp917) SetValue 0.03
$kw(vtkTemp892) AcceptCallback


I found this bug because I just submitted a bunch of pvs files in bug reports that will probably not work for others because these set commands are missin.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-12-09 14:51Berk GeveciProject@3@ => ParaView
2011-06-16 13:09Zack GalbreathCategory => (No Category)

Notes
(0003455)
Brian Wylie   
2005-12-19 11:32   
Down a notch. This is a bad bug, but not a firedrill.
(0003633)
Berk Geveci   
2006-01-31 10:27   
This would take about 2 days
(0003679)
Utkarsh Ayachit   
2006-02-03 10:34   
The issue had nothing to do with Client/Server. The second time a state was saved in any paraview session, it was always saved wrong.

The problem was the the widgets' trace helper assumed that the they had initialized the widgets in the state file after the first saving of state file. Any consecutive saves did not reset the flag that indicated that the widget had been initialized in the state, hence all subsequent saved states were broken. Fixed it.

new revision: 1.137; previous revision: 1.136
/cvsroot/ParaView/ParaView/GUI/Client/vtkPVSource.cxx,v <-- vtkPVSource.cxx
new revision: 1.475; previous revision: 1.474
/cvsroot/ParaView/ParaView/GUI/Client/vtkPVTraceHelper.cxx,v <-- vtkPVTraceHelper.cxx
new revision: 1.6; previous revision: 1.5
/cvsroot/ParaView/ParaView/GUI/Client/vtkPVTraceHelper.h,v <-- vtkPVTraceHelper.h
new revision: 1.5; previous revision: 1.4
/cvsroot/ParaView/ParaView/GUI/Client/vtkPVWindow.cxx,v <-- vtkPVWindow.cxx
new revision: 1.781; previous revision: 1.780
(0003764)
Ken Moreland   
2006-02-21 15:48   
There still are places where this is a problem. I just saved out a pvs file with, among many other things, is a pvtp file reader. It failed to write out many key set commands.

set kw(vtkTemp1188) [$kw(vtkTemp6) InitializeReadCustom "XMLPPolyDataReader" "/home/kmorel/data/capmilestone/fire/enclosure.pvtp"]
$kw(vtkTemp6) ReadFileInformation $kw(vtkTemp1188) "/home/kmorel/data/capmilestone/fire/enclosure.pvtp"
$kw(vtkTemp6) FinalizeRead $kw(vtkTemp1188) "/home/kmorel/data/capmilestone/fire/enclosure.pvtp"
$kw(vtkTemp1188) SetLabel {enclosure.pvtp}
$kw(vtkTemp1202) SetValue "/home/kmorel/data/capmilestone/fire/enclosure.pvtp"
$kw(vtkTemp1193) SetArrayStatus {vtkGhostLevels} 1
$kw(vtkTemp1193) SetArrayStatus {___D3___GlobalNodeIds} 1
$kw(vtkTemp1199) SetArrayStatus {vtkGhostLevels} 1
$kw(vtkTemp1188) AcceptCallback
(0003814)
Utkarsh Ayachit   
2006-02-28 10:38   
This patch also addresses Bug 0002545 - SNL: Plotting improvements.

Instead of relying of clearing of the StateInitialzed flags by the PVSource before saving state of a widget, now the TraceHelper for each widget obtains the unique state file id assigned to the currently active state file. If the Id is different, then the trace helper realizes that its a new state file and saves the initialization code.


/cvsroot/ParaView/ParaView/GUI/Client/CMakeLists.txt,v <-- CMakeLists.txt
new revision: 1.138; previous revision: 1.137
/cvsroot/ParaView/ParaView/GUI/Client/vtkPVArraySelection.cxx,v <-- vtkPVArraySelection.cxx
new revision: 1.83; previous revision: 1.82
/cvsroot/ParaView/ParaView/GUI/Client/vtkPVArraySelection.h,v <-- vtkPVArraySelection.h
new revision: 1.45; previous revision: 1.44
/cvsroot/ParaView/ParaView/GUI/Client/vtkPVDataAnalysis.cxx,v <-- vtkPVDataAnalysis.cxx
initial revision: 1.1
/cvsroot/ParaView/ParaView/GUI/Client/vtkPVDataAnalysis.h,v <-- vtkPVDataAnalysis.h
initial revision: 1.1
/cvsroot/ParaView/ParaView/GUI/Client/vtkPVLineSourceWidget.cxx,v <-- vtkPVLineSourceWidget.cxx
new revision: 1.40; previous revision: 1.39
/cvsroot/ParaView/ParaView/GUI/Client/vtkPVPlotArraySelection.cxx,v <-- vtkPVPlotArraySelection.cxx
initial revision: 1.1
/cvsroot/ParaView/ParaView/GUI/Client/vtkPVPlotArraySelection.h,v <-- vtkPVPlotArraySelection.h
initial revision: 1.1
/cvsroot/ParaView/ParaView/GUI/Client/vtkPVPlotDisplayLabelPropertiesDialog.cxx,v <-- vtkPVPlotDisplayLabelPropertiesDialog.cxx
initial revision: 1.1
/cvsroot/ParaView/ParaView/GUI/Client/vtkPVPlotDisplayLabelPropertiesDialog.h,v <-- vtkPVPlotDisplayLabelPropertiesDialog.h
initial revision: 1.1
/cvsroot/ParaView/ParaView/GUI/Client/vtkPVPointSourceWidget.cxx,v <-- vtkPVPointSourceWidget.cxx
new revision: 1.53; previous revision: 1.52
/cvsroot/ParaView/ParaView/GUI/Client/vtkPVPointSourceWidget.h,v <-- vtkPVPointSourceWidget.h
new revision: 1.25; previous revision: 1.24
/cvsroot/ParaView/ParaView/GUI/Client/vtkPVPointWidget.cxx,v <-- vtkPVPointWidget.cxx
new revision: 1.62; previous revision: 1.61
/cvsroot/ParaView/ParaView/GUI/Client/vtkPVProbe.cxx,v <-- vtkPVProbe.cxx
new revision: 1.171; previous revision: 1.170
/cvsroot/ParaView/ParaView/GUI/Client/vtkPVReaderModule.cxx,v <-- vtkPVReaderModule.cxx
new revision: 1.73; previous revision: 1.72
/cvsroot/ParaView/ParaView/GUI/Client/vtkPVSelectWidget.cxx,v <-- vtkPVSelectWidget.cxx
new revision: 1.78; previous revision: 1.77
/cvsroot/ParaView/ParaView/GUI/Client/vtkPVSelectWidget.h,v <-- vtkPVSelectWidget.h
new revision: 1.37; previous revision: 1.36
/cvsroot/ParaView/ParaView/GUI/Client/vtkPVSource.cxx,v <-- vtkPVSource.cxx
new revision: 1.477; previous revision: 1.476
/cvsroot/ParaView/ParaView/GUI/Client/vtkPVSource.h,v <-- vtkPVSource.h
new revision: 1.205; previous revision: 1.204
/cvsroot/ParaView/ParaView/GUI/Client/vtkPVTraceHelper.cxx,v <-- vtkPVTraceHelper.cxx
new revision: 1.7; previous revision: 1.6
/cvsroot/ParaView/ParaView/GUI/Client/vtkPVTraceHelper.h,v <-- vtkPVTraceHelper.h
new revision: 1.6; previous revision: 1.5
/cvsroot/ParaView/ParaView/GUI/Client/vtkPVWindow.cxx,v <-- vtkPVWindow.cxx
new revision: 1.783; previous revision: 1.782
/cvsroot/ParaView/ParaView/GUI/Client/vtkPVWindow.h,v <-- vtkPVWindow.h
new revision: 1.246; previous revision: 1.245
/cvsroot/ParaView/ParaView/GUI/Client/Resources/Filters.xml,v <-- Filters.xml
new revision: 1.169; previous revision: 1.168
/cvsroot/ParaView/ParaView/Servers/Filters/CMakeLists.txt,v <-- CMakeLists.txt
new revision: 1.85; previous revision: 1.84
/cvsroot/ParaView/ParaView/Servers/Filters/vtkDataAnalysisFilter.cxx,v <-- vtkDataAnalysisFilter.cxx
initial revision: 1.1
/cvsroot/ParaView/ParaView/Servers/Filters/vtkDataAnalysisFilter.h,v <-- vtkDataAnalysisFilter.h
initial revision: 1.1
/cvsroot/ParaView/ParaView/Servers/Filters/vtkPPickFilter.cxx,v <-- vtkPPickFilter.cxx
initial revision: 1.1
/cvsroot/ParaView/ParaView/Servers/Filters/vtkPPickFilter.h,v <-- vtkPPickFilter.h
initial revision: 1.1
/cvsroot/ParaView/ParaView/Servers/Filters/vtkPickFilter.h,v <-- vtkPickFilter.hnew revision: 1.9; previous revision: 1.8
/cvsroot/ParaView/ParaView/Servers/Filters/vtkTemporalCacheFilter.cxx,v <-- vtkTemporalCacheFilter.cxx
initial revision: 1.1
/cvsroot/ParaView/ParaView/Servers/Filters/vtkTemporalCacheFilter.h,v <-- vtkTemporalCacheFilter.h
initial revision: 1.1
/cvsroot/ParaView/ParaView/Servers/ServerManager/CMakeLists.txt,v <-- CMakeLists.txt
new revision: 1.83; previous revision: 1.82
/cvsroot/ParaView/ParaView/Servers/ServerManager/vtkSMAnimationCueProxy.h,v <-- vtkSMAnimationCueProxy.h
new revision: 1.10; previous revision: 1.9
/cvsroot/ParaView/ParaView/Servers/ServerManager/vtkSMTemporalXYPlotDisplayProxy.cxx,v <-- vtkSMTemporalXYPlotDisplayProxy.cxx
initial revision: 1.1
/cvsroot/ParaView/ParaView/Servers/ServerManager/vtkSMTemporalXYPlotDisplayProxy.h,v <-- vtkSMTemporalXYPlotDisplayProxy.h
initial revision: 1.1
/cvsroot/ParaView/ParaView/Servers/ServerManager/vtkSMXYPlotActorProxy.cxx,v <-- vtkSMXYPlotActorProxy.cxx
new revision: 1.7; previous revision: 1.6
/cvsroot/ParaView/ParaView/Servers/ServerManager/vtkSMXYPlotActorProxy.h,v <-- vtkSMXYPlotActorProxy.h
new revision: 1.6; previous revision: 1.5
/cvsroot/ParaView/ParaView/Servers/ServerManager/vtkSMXYPlotDisplayProxy.cxx,v <-- vtkSMXYPlotDisplayProxy.cxx
new revision: 1.19; previous revision: 1.18
/cvsroot/ParaView/ParaView/Servers/ServerManager/vtkSMXYPlotDisplayProxy.h,v <-- vtkSMXYPlotDisplayProxy.h
new revision: 1.13; previous revision: 1.12
/cvsroot/ParaView/ParaView/Servers/ServerManager/Resources/filters.xml,v <-- filters.xml
new revision: 1.105; previous revision: 1.104
/cvsroot/ParaView/ParaView/Servers/ServerManager/Resources/rendering.xml,v <-- rendering.xml
new revision: 1.70; previous revision: 1.69
/cvsroot/ParaView/ParaView/Servers/ServerManager/Resources/utilities.xml,v <-- utilities.xml
new revision: 1.46; previous revision: 1.45