View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0013096ParaViewFeaturepublic2012-04-13 11:162016-08-12 09:59
ReporterIan Curington 
Assigned ToKitware Robot 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionmoved 
PlatformOSOS Version
Product Version3.14.1 
Target VersionFixed in Version 
Summary0013096: Fix Cancel action on Fix Path in State Files dialog
DescriptionPROBLEM:
Cancel of data path dialog continues to load possibly incorrect data paths.

SOLUTION:
Add canceling of entire loading of state file after clicking on 'X' or 'Cancel' button in "Fix Paths in State Files" dialog.

   patched files: pqApplicationCore.[h, cxx], pqFixPathsInStateFilesBehavior.cxx
   action: copy pqApplicationCore.* to ParaView-3.14.0/Qt/Core
           copy pqFixPathsInStateFilesBehavior.cxx to ParaView-3.14.0/Qt/ApplicationComponents

    DESCRIPTION: When user loads state file with filenames specified in it, dialog pops up to allow user to update filenames
    paths. In case user clicks on Cancel or 'X' button, patch allows stopping entire process of loading of state files, instead of
    stopping only fixing pathnames in state file being loaded as it was previously done. Perhaps previous behavior was intended
    feature, but canceling of entire loading process when user clicks on 'X' or 'Cancel' looks much more natural than continuing with
    loading of state file.

    CHANGES: To make this patch, following changes were made (ParaView source patch):

        - Added QuitLoadingStateFile property and its mutator to pqApplicationCore class,
        - Added logic of quiting loading of state file in case flag is set in pqApplicationCore::loadStateFile() routine,
        - Added setting of pqApplicationCore::QuitLoadingStateFile flag in pqFixPathsInStateFilesBehavior class.



TagsNo tags attached.
ProjectParaViewPro
Topic Name
Typeincorrect functionality
Attached Files? file icon pqApplicationCore.h [^] (13,622 bytes) 2012-04-13 11:16
cxx file icon pqApplicationCore.cxx [^] (27,396 bytes) 2012-04-13 11:17
cxx file icon pqFixPathsInStateFilesBehavior.cxx [^] (3,333 bytes) 2012-04-13 11:18

 Relationships

  Notes
(0028514)
Utkarsh Ayachit (administrator)
2012-04-23 10:36

 I'd propose removing the "Cancel" button all together.
(0028600)
Nenad Vujicic (reporter)
2012-05-14 05:14

 Dear Utkarsh,

We think it would be great if we could have cancellation mechanism like Cancel or 'X' button. It would help us in cases we make mistake and start loading wrong state file or would like to prepare input in a different way.

If You don't have some particular reasons for removing it, can You please keep Cancel and 'X' buttons?

Best regards,
Nenad.
(0038192)
Kitware Robot (administrator)
2016-08-12 09:59

 Resolving issue as `moved`.

This issue tracker is no longer used. Further discussion of this issue may take place in the current ParaView Issues page linked in the banner at the top of this page.

 Issue History
Date Modified Username Field Change
2012-04-13 11:16 Ian Curington New Issue
2012-04-13 11:16 Ian Curington File Added: pqApplicationCore.h
2012-04-13 11:17 Ian Curington File Added: pqApplicationCore.cxx
2012-04-13 11:18 Ian Curington File Added: pqFixPathsInStateFilesBehavior.cxx
2012-04-23 10:36 Utkarsh Ayachit Note Added: 0028514
2012-04-23 10:36 Utkarsh Ayachit Category (No Category) => Feature
2012-04-23 10:41 Utkarsh Ayachit Project TBD => ParaViewPro
2012-05-14 05:14 Nenad Vujicic Note Added: 0028600
2016-08-12 09:59 Kitware Robot Note Added: 0038192
2016-08-12 09:59 Kitware Robot Status backlog => closed
2016-08-12 09:59 Kitware Robot Resolution open => moved
2016-08-12 09:59 Kitware Robot Assigned To => Kitware Robot

Copyright © 2000 - 2018 MantisBT Team