| View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0013377 | VTK | (No Category) | public | 2012-08-20 14:45 | 2013-07-29 11:40 | ||||
| Reporter | Utkarsh Ayachit | ||||||||
| Assigned To | Brad King | ||||||||
| Priority | normal | Severity | minor | Reproducibility | have not tried | ||||
| Status | closed | Resolution | fixed | ||||||
| Platform | OS | OS Version | |||||||
| Product Version | |||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0013377: SystemTools::EnableMSVCDebugHook using old environment variable. | ||||||||
| Description | SystemTools::EnableMSVCDebugHook() is still using the old DART environment variable to determine if we are running dashboard tests. Ideally, we'd add support for the new DASHBOARD_TEST_FROM_CTEST variable. | ||||||||
| Tags | No tags attached. | ||||||||
| Project | Kitware | ||||||||
| Type | incorrect functionality | ||||||||
| Attached Files | |||||||||
| Relationships | |
| Relationships |
| Notes | |
|
(0029032) David Cole (developer) 2012-08-20 14:48 |
Both variables are set by ctest, and always will be for backwards compatibility. |
|
(0029033) Brad King (developer) 2012-08-20 16:37 edited on: 2012-08-20 16:38 |
Try this patch:
diff --git a/Utilities/KWSys/vtksys/SystemTools.cxx b/Utilities/KWSys/vtksys/SystemTools.cxx
index 66850e9..4fd2c04 100644
--- a/Utilities/KWSys/vtksys/SystemTools.cxx
+++ b/Utilities/KWSys/vtksys/SystemTools.cxx
@@ -4841,7 +4841,8 @@ static int SystemToolsDebugReport(int, char* message, int*)
void SystemTools::EnableMSVCDebugHook()
{
- if (getenv("DART_TEST_FROM_DART"))
+ if (getenv("DART_TEST_FROM_DART") ||
+ getenv("DASHBOARD_TEST_FROM_CTEST"))
{
_CrtSetReportHook(SystemToolsDebugReport);
}
|
|
(0031245) Dave DeMarle (administrator) 2013-07-22 20:02 |
moving all "tabled" bugs into "backlog" category since "tabled" is no longer used. |
|
(0031332) Brad King (developer) 2013-07-25 09:00 |
Patch from 0013377:0029033 applied to upstream KWSys: http://public.kitware.com/gitweb?p=KWSys.git;a=commitdiff;h=e39f85e0 [^] |
|
(0031360) Brad King (developer) 2013-07-29 11:39 |
KWSys change from 0013377:0031332 imported to VTK: http://vtk.org/gitweb?p=VTK.git;a=commitdiff;h=196cc337 [^] |
| Notes |
| Issue History | |||
| Date Modified | Username | Field | Change |
| 2012-08-20 14:45 | Utkarsh Ayachit | New Issue | |
| 2012-08-20 14:45 | Utkarsh Ayachit | Status | backlog => tabled |
| 2012-08-20 14:45 | Utkarsh Ayachit | Assigned To | => Brad King |
| 2012-08-20 14:48 | David Cole | Note Added: 0029032 | |
| 2012-08-20 16:37 | Brad King | Note Added: 0029033 | |
| 2012-08-20 16:38 | Brad King | Note Edited: 0029033 | |
| 2013-07-22 20:02 | Dave DeMarle | Status | tabled => backlog |
| 2013-07-22 20:02 | Dave DeMarle | Note Added: 0031245 | |
| 2013-07-25 09:00 | Brad King | Note Added: 0031332 | |
| 2013-07-29 11:39 | Brad King | Status | backlog => active development |
| 2013-07-29 11:39 | Brad King | Note Added: 0031360 | |
| 2013-07-29 11:40 | Brad King | Status | active development => closed |
| 2013-07-29 11:40 | Brad King | Resolution | open => fixed |
| Issue History |
| Copyright © 2000 - 2018 MantisBT Team |