View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0013655 | ParaView | (No Category) | public | 2012-11-13 17:27 | 2015-01-11 08:32 | ||||
Reporter | Orion Poplawski | ||||||||
Assigned To | Utkarsh Ayachit | ||||||||
Priority | normal | Severity | minor | Reproducibility | have not tried | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | |||||||||
Target Version | Fixed in Version | 3.98.0 | |||||||
Summary | 0013655: Include H5public.h instead of H5pubconf.h | ||||||||
Description | VTK/ThirdParty/xdmf2/vtkxdmf2/libsrc/XdmfH5Driver.h still includes H5pubconf.h instead of H5public.h. From H5public.h: /* Include files for public use... */ /* * Since H5pubconf.h is a generated header file, it is messy to try * to put a #ifndef _H5pubconf_H ... #endif guard in it. * HDF5 has set an internal rule that it is being included here. * Source files should NOT include H5pubconf.h directly but include * it via H5public.h. The #ifndef _H5public_H guard above would * prevent repeated include. */ #include "H5pubconf.h" /*from configure */ Fedora renames H5pubconf.h to H5pubconf-{32,64}.h to support multilib installs. | ||||||||
Tags | No tags attached. | ||||||||
Project | TBD | ||||||||
Topic Name | 13655_fix_hdf5_include | ||||||||
Type | incorrect functionality | ||||||||
Attached Files | |||||||||
Relationships | |
Relationships |
Notes | |
(0029731) Utkarsh Ayachit (administrator) 2012-11-16 00:22 |
commit acec1267caf591998f0ebeab0d02b178bb0dc5d0 Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com> Date: Fri Nov 16 00:16:56 2012 -0500 BUG 0013655: Fix include to use H5public instead of H5pubconf. H5public.h must be used instead of H5pubconf.h, based on documentation in H5public.h. Fixing accordingly. Change-Id: Ie868707e28b5487cda77fe40b71630241e3bf4f2 |
(0029765) Kyle Lutz (viewer) 2012-11-20 12:16 |
Merged into ParaView-master (if applicable) |
(0030075) Alan Scott (manager) 2013-01-10 20:44 |
Developer tag in Git. Closing. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2012-11-13 17:27 | Orion Poplawski | New Issue | |
2012-11-16 00:11 | Utkarsh Ayachit | Assigned To | => Utkarsh Ayachit |
2012-11-16 00:11 | Utkarsh Ayachit | Status | backlog => tabled |
2012-11-16 00:12 | Utkarsh Ayachit | Project | VTK => ParaView |
2012-11-16 00:22 | Utkarsh Ayachit | Topic Name | => 13655_fix_hdf5_include |
2012-11-16 00:22 | Utkarsh Ayachit | Note Added: 0029731 | |
2012-11-16 00:22 | Utkarsh Ayachit | Status | tabled => gatekeeper review |
2012-11-16 00:22 | Utkarsh Ayachit | Fixed in Version | => git-next |
2012-11-16 00:22 | Utkarsh Ayachit | Resolution | open => fixed |
2012-11-20 12:16 | Kyle Lutz | Status | gatekeeper review => customer review |
2012-11-20 12:16 | Kyle Lutz | Note Added: 0029765 | |
2012-11-20 16:01 | Utkarsh Ayachit | Fixed in Version | git-next => git-master |
2012-11-23 11:34 | Utkarsh Ayachit | Fixed in Version | git-master => 3.98.0 |
2013-01-10 20:44 | Alan Scott | Note Added: 0030075 | |
2013-01-10 20:44 | Alan Scott | Status | customer review => closed |
2015-01-09 14:04 | Kyle Lutz | Source_changeset_attached | => VTK master 8d098410 |
2015-01-09 14:05 | Utkarsh Ayachit | Source_changeset_attached | => VTK master acec1267 |
2015-01-09 14:07 | Dave DeMarle | Source_changeset_attached | => VTK master 4b7b1394 |
2015-01-11 08:31 | Kyle Lutz | Source_changeset_attached | => ParaView master 76b93d53 |
2015-01-11 08:32 | Utkarsh Ayachit | Source_changeset_attached | => ParaView master 4c51588a |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |