View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0013656

ParaView

(No Category)

public

2012-11-13 18:13

2016-08-12 09:59

Reporter

Orion Poplawski

Assigned To

Kitware Robot

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

moved

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0013656: Try to support using system installed protobuf

Description

For Fedora packages, need to use the system installed version of libraries. Attached is a hack to try to do that with 3.98.0. First step is to change:

-vtk_module_third_party(protobuf
+vtk_module_third_party(Protobuf

in ParaView/ThirdParty/protobuf/CMakeLists.txt so that cmake finds FindProtobuf.cmake. Next I hacked out:

+#vtk_target_export(protobuf)
+#vtk_target_export(protobuf-lite)
+#vtk_compile_tools_target_export(protoc_compiler)

because they are not available in that configuration.

Finally, Fedora 18 has protobuf 2.4.1 and the compiler is named "protoc" so I changed the name in ParaView/ParaViewCore/ServerImplementation/Core/CMakeLists.txt and removed protoc_compiler as a build dependency.

Finally though I get the following link error:

/usr/lib64/ccache/g++ -fPIC -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -g -Wl,--fatal-warnings -Wl,--no-undefined -lc -Wl,-z,relro -shared -Wl,-soname,libvtkPVServerImplementationCore-pv3.98.so.1 -o ../../../lib/libvtkPVServerImplementationCore-pv3.98.so.1 CMakeFiles/vtkPVServerImplementationCore.dir/vtkPVCatalystSessionCore.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkPVProxyDefinitionIterator.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkPVSessionBase.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkPVSessionCore.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkPVSessionCoreInterpreterHelper.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkPVSessionServer.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkSIArraySelectionProperty.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkSICollaborationManager.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkSICompoundSourceProxy.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkSIDataArrayProperty.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkSIDoubleVectorProperty.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkSIFileSeriesReaderProxy.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkSIIdTypeVectorProperty.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkSIInputProperty.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkSIIntVectorProperty.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkSIObject.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkSIProperty.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkSIProxy.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkSIProxyDefinitionManager.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkSIProxyProperty.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkSISILProperty.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkSISourceProxy.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkSIStringVectorProperty.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkSITimeLabelProperty.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkSITimeRangeProperty.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkSITimeStepsProperty.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkSIVectorProperty.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkSIWriterProxy.cxx.o CMakeFiles/vtkPVServerImplementationCore.dir/vtkSMMessage.cxx.o ../../../lib/libvtkPVClientServerCoreCore-pv3.98.so.1 -lprotobuf ../../../lib/libvtkFiltersProgrammable-pv3.98.so.1 ../../../lib/libvtkPVPythonSupport-pv3.98.so.1 -lpython2.7 ../../../lib/libvtkPVVTKExtensionsCore-pv3.98.so.1 ../../../lib/libvtkPVCommon-pv3.98.so.1 ../../../lib/libvtkClientServer-pv3.98.so.1 ../../../lib/libvtkIOXML-pv3.98.so.1 ../../../lib/libvtkIOGeometry-pv3.98.so.1 ../../../lib/libvtkIOXMLParser-pv3.98.so.1 -lexpat ../../../lib/libvtkImagingCore-pv3.98.so.1 ../../../lib/libvtkInfovisCore-pv3.98.so.1 ../../../lib/libvtkFiltersExtraction-pv3.98.so.1 ../../../lib/libvtkFiltersGeneral-pv3.98.so.1 ../../../lib/libvtkFiltersCore-pv3.98.so.1 ../../../lib/libvtkCommonComputationalGeometry-pv3.98.so.1 ../../../lib/libvtkParallelCore-pv3.98.so.1 ../../../lib/libvtkIOLegacy-pv3.98.so.1 ../../../lib/libvtkIOCore-pv3.98.so.1 ../../../lib/libvtkCommonExecutionModel-pv3.98.so.1 ../../../lib/libvtkCommonDataModel-pv3.98.so.1 ../../../lib/libvtkCommonSystem-pv3.98.so.1 ../../../lib/libvtkCommonTransforms-pv3.98.so.1 ../../../lib/libvtkCommonMisc-pv3.98.so.1 ../../../lib/libvtkCommonMath-pv3.98.so.1 ../../../lib/libvtkCommonCore-pv3.98.so.1 ../../../lib/libvtksys-pv3.98.so.1 -ldl -lz -Wl,-rpath,/export/home/orion/fedora/paraview/ParaView/fedora/lib:
CMakeFiles/vtkPVServerImplementationCore.dir/vtkSMMessage.cxx.o: In function `protobuf_AssignDescriptorsOnce':
CMakeFiles/vtkPVServerImplementationCore.dir/vtkSMMessage.cxx.o:/usr/include/google/protobuf/stubs/once.h:115: more undefined references to `pthread_once' follow

It's going to need to link against -lpthread but I don't know the best way to handle that.

Tags

No tags attached.

Project

TBD

Topic Name

Type

feature

Attached Files

paraview-Protobuf.patch [^] (2,540 bytes) 2012-11-13 18:13 [Show Content] [Hide Content]

diff -up ParaView/ParaViewCore/ServerImplementation/Core/CMakeLists.txt.Protobuf ParaView/ParaViewCore/ServerImplementation/Core/CMakeLists.txt
--- ParaView/ParaViewCore/ServerImplementation/Core/CMakeLists.txt.Protobuf	2012-11-08 07:51:51.000000000 -0700
+++ ParaView/ParaViewCore/ServerImplementation/Core/CMakeLists.txt	2012-11-13 15:17:53.980027098 -0700
@@ -80,16 +80,16 @@ set (${vtk-module}_HDRS
 #------------------------------------------------------------------------------
 # Generate the protbuf message file.
 #------------------------------------------------------------------------------
-get_target_property(PROTOC_LOCATION protoc_compiler LOCATION)
+get_target_property(PROTOC_LOCATION protoc LOCATION)
 add_custom_command(
     OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/vtkPVMessage.pb.h
            ${CMAKE_CURRENT_BINARY_DIR}/vtkPVMessage.pb.cc
     
-    COMMAND protoc_compiler
+    COMMAND protoc
            "--cpp_out=dllexport_decl=VTKPVSERVERIMPLEMENTATIONCORE_EXPORT:${CMAKE_CURRENT_BINARY_DIR}"
            --proto_path "@CMAKE_CURRENT_SOURCE_DIR@"
            "${CMAKE_CURRENT_SOURCE_DIR}/vtkPVMessage.proto"
-    DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/vtkPVMessage.proto protoc_compiler
+    DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/vtkPVMessage.proto
     WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
 )
 
diff -up ParaView/ThirdParty/protobuf/CMakeLists.txt.Protobuf ParaView/ThirdParty/protobuf/CMakeLists.txt
--- ParaView/ThirdParty/protobuf/CMakeLists.txt.Protobuf	2012-11-08 07:51:51.000000000 -0700
+++ ParaView/ThirdParty/protobuf/CMakeLists.txt	2012-11-13 15:09:31.526673020 -0700
@@ -34,7 +34,7 @@ set (PROTOBUF_INSTALL_BIN_DIR ${VTK_INST
 set (PROTOBUF_INSTALL_LIB_DIR ${VTK_INSTALL_LIBRARY_DIR})
 set (PROTOBUF_INSTALL_EXPORT_NAME ${VTK_INSTALL_EXPORT_NAME})
 
-vtk_module_third_party(protobuf
+vtk_module_third_party(Protobuf
   INCLUDE_DIRS ${CMAKE_CURRENT_SOURCE_DIR}/vtkprotobuf/src
   LIBRARIES protobuf
 )
@@ -42,9 +42,9 @@ vtk_module_third_party(protobuf
 # protobuf exports it's build-dir targets to a custom file
 # (PROTOBUF_EXPORTS.cmake). We don't care much about that. We export
 # build-dir targets ourselves.
-vtk_target_export(protobuf)
-vtk_target_export(protobuf-lite)
-vtk_compile_tools_target_export(protoc_compiler)
+#vtk_target_export(protobuf)
+#vtk_target_export(protobuf-lite)
+#vtk_compile_tools_target_export(protoc_compiler)
 
 # All these exports don't add any install rules. However we make protobuf itself
 # install components at the right location by setting PROTOBUF_INSTALL_*

paraview-4.0.1-Protobuf.patch [^] (3,064 bytes) 2013-07-29 10:59 [Show Content] [Hide Content]

http://paraview.org/Bug/view.php?id=13656

diff -up ParaView/ParaViewCore/ServerImplementation/Core/CMakeLists.txt.Protobuf ParaView/ParaViewCore/ServerImplementation/Core/CMakeLists.txt
--- ParaView/ParaViewCore/ServerImplementation/Core/CMakeLists.txt.Protobuf	2012-11-08 07:51:51.000000000 -0700
+++ ParaView/ParaViewCore/ServerImplementation/Core/CMakeLists.txt	2012-11-13 15:17:53.980027098 -0700
@@ -81,16 +81,24 @@
 #------------------------------------------------------------------------------
 # Generate the protbuf message file.
 #------------------------------------------------------------------------------
-get_target_property(PROTOC_LOCATION protoc_compiler LOCATION)
+if (VTK_USE_SYSTEM_PROTOBUF)
+	set (_PROTOC_COMPILER protoc)
+	set (_PROTOC_DEPEND "")
+else()
+	set (_PROTOC_COMPILER protoc_compiler)
+	set (_PROTOC_DEPEND ${_PROTOC_COMPILER})
+endif()
+
+get_target_property(PROTOC_LOCATION ${_PROTOC_COMPILER} LOCATION)
 add_custom_command(
     OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/vtkPVMessage.pb.h
            ${CMAKE_CURRENT_BINARY_DIR}/vtkPVMessage.pb.cc
     
-    COMMAND protoc_compiler
+    COMMAND ${_PROTOC_COMPILER}
            "--cpp_out=dllexport_decl=VTKPVSERVERIMPLEMENTATIONCORE_EXPORT:${CMAKE_CURRENT_BINARY_DIR}"
            --proto_path "@CMAKE_CURRENT_SOURCE_DIR@"
            "${CMAKE_CURRENT_SOURCE_DIR}/vtkPVMessage.proto"
-    DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/vtkPVMessage.proto protoc_compiler
+    DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/vtkPVMessage.proto ${_PROTOC_DEPEND}
     WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
 )
 
@@ -109,5 +117,9 @@
 vtk_module_library(vtkPVServerImplementationCore
   ${Module_SRCS})
 
+if (VTK_USE_SYSTEM_PROTOBUF)
+	target_link_libraries(vtkPVServerImplementationCore ${CMAKE_THREAD_LIBS_INIT})
+endif()
+
 add_dependencies(vtkPVServerImplementationCore
   protobuf_code_generation)
diff -up ParaView/ThirdParty/protobuf/CMakeLists.txt.Protobuf ParaView/ThirdParty/protobuf/CMakeLists.txt
--- ParaView/ThirdParty/protobuf/CMakeLists.txt.Protobuf	2012-11-08 07:51:51.000000000 -0700
+++ ParaView/ThirdParty/protobuf/CMakeLists.txt	2012-11-13 15:09:31.526673020 -0700
@@ -34,7 +34,7 @@
 set (PROTOBUF_INSTALL_LIB_DIR ${VTK_INSTALL_LIBRARY_DIR})
 set (PROTOBUF_INSTALL_EXPORT_NAME ${VTK_INSTALL_EXPORT_NAME})
 
-vtk_module_third_party(protobuf
+vtk_module_third_party(Protobuf
   INCLUDE_DIRS ${CMAKE_CURRENT_SOURCE_DIR}/vtkprotobuf/src
   LIBRARIES protobuf
 )
@@ -42,10 +42,12 @@
 # protobuf exports it's build-dir targets to a custom file
 # (PROTOBUF_EXPORTS.cmake). We don't care much about that. We export
 # build-dir targets ourselves.
-vtk_target_export(protobuf)
-vtk_target_export(protobuf-lite)
-if (NOT CMAKE_CROSSCOMPILING)
-  vtk_compile_tools_target_export(protoc_compiler)
+if (NOT VTK_USE_SYSTEM_PROTOBUF)
+  vtk_target_export(protobuf)
+  vtk_target_export(protobuf-lite)
+  if (NOT CMAKE_CROSSCOMPILING)
+    vtk_compile_tools_target_export(protoc_compiler)
+  endif()
 endif()
 
 # All these exports don't add any install rules. However we make protobuf itself

paraview-4.2RC1-Protobuf.patch [^] (2,855 bytes) 2014-09-03 18:39 [Show Content] [Hide Content]

diff -up ParaView-v4.2.0-RC1-source/ParaViewCore/ServerImplementation/Core/CMakeLists.txt.Protobuf ParaView-v4.2.0-RC1-source/ParaViewCore/ServerImplementation/Core/CMakeLists.txt
--- ParaView-v4.2.0-RC1-source/ParaViewCore/ServerImplementation/Core/CMakeLists.txt.Protobuf	2014-08-31 19:35:53.000000000 -0600
+++ ParaView-v4.2.0-RC1-source/ParaViewCore/ServerImplementation/Core/CMakeLists.txt	2014-09-03 12:13:42.954720347 -0600
@@ -82,15 +82,23 @@ set (${vtk-module}_HDRS
 #------------------------------------------------------------------------------
 # Generate the protbuf message file.
 #------------------------------------------------------------------------------
+if (VTK_USE_SYSTEM_PROTOBUF)
+    set (_PROTOC_COMPILER protoc)
+    set (_PROTOC_DEPEND "")
+else()
+    set (_PROTOC_COMPILER protoc_compiler)
+    set (_PROTOC_DEPEND ${_PROTOC_COMPILER})
+endif()
+
 add_custom_command(
     OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/vtkPVMessage.pb.h
            ${CMAKE_CURRENT_BINARY_DIR}/vtkPVMessage.pb.cc
     
-    COMMAND protoc_compiler
+    COMMAND ${_PROTOC_COMPILER}
            "--cpp_out=dllexport_decl=VTKPVSERVERIMPLEMENTATIONCORE_EXPORT:${CMAKE_CURRENT_BINARY_DIR}"
            --proto_path "${CMAKE_CURRENT_SOURCE_DIR}"
            "${CMAKE_CURRENT_SOURCE_DIR}/vtkPVMessage.proto"
-    DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/vtkPVMessage.proto protoc_compiler
+    DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/vtkPVMessage.proto ${_PROTOC_DEPEND}
     WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
 )
 
diff -up ParaView-v4.2.0-RC1-source/ThirdParty/protobuf/CMakeLists.txt.Protobuf ParaView-v4.2.0-RC1-source/ThirdParty/protobuf/CMakeLists.txt
--- ParaView-v4.2.0-RC1-source/ThirdParty/protobuf/CMakeLists.txt.Protobuf	2014-08-31 19:35:53.000000000 -0600
+++ ParaView-v4.2.0-RC1-source/ThirdParty/protobuf/CMakeLists.txt	2014-09-03 12:06:54.042370637 -0600
@@ -34,7 +34,7 @@ set (PROTOBUF_INSTALL_BIN_DIR ${VTK_INST
 set (PROTOBUF_INSTALL_LIB_DIR ${VTK_INSTALL_LIBRARY_DIR})
 set (PROTOBUF_INSTALL_EXPORT_NAME ${VTK_INSTALL_EXPORT_NAME})
 
-vtk_module_third_party(protobuf
+vtk_module_third_party(Protobuf
   INCLUDE_DIRS ${CMAKE_CURRENT_SOURCE_DIR}/vtkprotobuf/src
   LIBRARIES protobuf
 )
@@ -42,10 +42,12 @@ vtk_module_third_party(protobuf
 # protobuf exports it's build-dir targets to a custom file
 # (PROTOBUF_EXPORTS.cmake). We don't care much about that. We export
 # build-dir targets ourselves.
-vtk_target_export(protobuf)
-vtk_target_export(protobuf-lite)
-if (NOT CMAKE_CROSSCOMPILING)
-  vtk_compile_tools_target_export(protoc_compiler)
+if (NOT VTK_USE_SYSTEM_PROTOBUF)
+  vtk_target_export(protobuf)
+  vtk_target_export(protobuf-lite)
+  if (NOT CMAKE_CROSSCOMPILING)
+    vtk_compile_tools_target_export(protoc_compiler)
+  endif()
 endif()
 
 # All these exports don't add any install rules. However we make protobuf itself

paraview-cmake.patch [^] (959 bytes) 2014-09-05 11:33 [Show Content] [Hide Content]

--- ParaView-v4.2.0-RC1-source/CommandLineExecutables/CMakeLists.txt.cmake	2014-09-05 08:59:31.077125795 -0600
+++ ParaView-v4.2.0-RC1-source/CommandLineExecutables/CMakeLists.txt	2014-09-05 09:01:18.183583829 -0600
@@ -64,7 +64,12 @@
     file(APPEND "${CMAKE_CURRENT_BINARY_DIR}/vtkModuleDependencies.h"
 "const char* ${vtk_module}Libraries[] = { ")
     foreach (vtk_module_library IN LISTS "${vtk_module}_LIBRARIES")
-      if (IS_ABSOLUTE "${vtk_module_library}")
+      if (vtk_module_library STREQUAL "optimized" OR vtk_module_library STREQUAL "debug")
+        unset(vtk_module_library_name)
+      elseif (vtk_module_library MATCHES "^-l")
+        string(SUBSTRING ${vtk_module_library} 2 -1 vtk_module_library)
+        find_library(vtk_module_library_name ${vtk_module_library})
+      elseif (IS_ABSOLUTE "${vtk_module_library}")
         set(vtk_module_library_name "${vtk_module_library}")
       elseif (vtk_module_library)
         set(type)

Relationships

Notes
(0031359) hasufell (reporter) 2013-07-29 10:59	Updated for paraview-4.0.1, with proper conditionals so both ON and OFF work as expected lpthread problem solved as well

(0031363) Orion Poplawski (reporter) 2013-07-29 17:07	Updated patch works for me.

(0033306) Orion Poplawski (reporter) 2014-09-03 14:10	With 4.2RC1 things will need to get updated as well. Looks like even less support for configuring it.

(0033307) Orion Poplawski (reporter) 2014-09-03 18:41	Updated patch. Not sure if I need to re-add the thread stuff. There are problems interacting with the cmake FindProtobuf module (see also http://www.cmake.org/Bug/view.php?id=15128 [^]) due to its adding of items to PROTOBUF_LIBRARIES. Any suggestions there appreciated.

(0033309) Orion Poplawski (reporter) 2014-09-04 12:33	These are the errors I get when the system FindProtobuf add -lpthread to PROTOBUF_LIBRARIES: CMake Error at CommandLineExecutables/CMakeLists.txt:71 (get_property): get_property could not find TARGET -lpthread. Perhaps it has not yet been created. CMake Error at CommandLineExecutables/CMakeLists.txt:76 (get_property): get_property could not find TARGET -lpthread. Perhaps it has not yet been created. Not sure if this is more of an issue with the ParaView cmake code making assumptions about various libraries, or something that should be fixed in cmake's FindProtobuf.

(0033312) Orion Poplawski (reporter) 2014-09-05 12:06	paraview-cmake.patch is a patch suggested by the cmake folks to handle different kinds of entries in vtk_module_libraries. Appears to work for me.

(0034391) Orion Poplawski (reporter) 2015-04-30 11:52	I believe this can be closed now as paraview does support the -DVTK_USE_SYSTEM_PROTOBUF:BOOL=ON option now.

(0038279) Kitware Robot (administrator) 2016-08-12 09:59	Resolving issue as `moved`. This issue tracker is no longer used. Further discussion of this issue may take place in the current ParaView Issues page linked in the banner at the top of this page.

Issue History
Date Modified	Username	Field	Change
2012-11-13 18:13	Orion Poplawski	New Issue
2012-11-13 18:13	Orion Poplawski	File Added: paraview-Protobuf.patch
2013-07-29 10:59	hasufell	File Added: paraview-4.0.1-Protobuf.patch
2013-07-29 10:59	hasufell	Note Added: 0031359
2013-07-29 17:07	Orion Poplawski	Note Added: 0031363
2014-09-03 14:10	Orion Poplawski	Note Added: 0033306
2014-09-03 18:39	Orion Poplawski	File Added: paraview-4.2RC1-Protobuf.patch
2014-09-03 18:41	Orion Poplawski	Note Added: 0033307
2014-09-04 12:33	Orion Poplawski	Note Added: 0033309
2014-09-05 11:33	Orion Poplawski	File Added: paraview-cmake.patch
2014-09-05 12:06	Orion Poplawski	Note Added: 0033312
2015-04-30 11:52	Orion Poplawski	Note Added: 0034391
2016-08-12 09:59	Kitware Robot	Note Added: 0038279
2016-08-12 09:59	Kitware Robot	Status	backlog => closed
2016-08-12 09:59	Kitware Robot	Resolution	open => moved
2016-08-12 09:59	Kitware Robot	Assigned To	=> Kitware Robot