View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0014238

ParaView

(No Category)

public

2013-08-20 15:14

2015-01-11 08:23

Reporter

Alan Scott

Assigned To

Kyle Lutz

Priority

high

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

git-master

Target Version

4.1

Fixed in Version

4.1

Summary

0014238: Crash opening EnSight .case files with FILE block

Description

I have a dataset that crashes. It is an EnSight .case file. The issue occurs in the FILE block of the .case file. ParaView is reading three lines for the following, where it should be reading two:

file set: #
number of steps: #

This works if there is only one file set, but if you have more than one, it is wrong. Issue was found in parallel (with crash), but should also have happened in serial (which surprisingly didn't crash).

Linux, master, remote server.
Open attached .case file. Dies.

I have attached two .diff files that patch and correct this bug.

>> pwd
/projects/viz/ParaView-Distribution/ParaView/4.1.0-alan/ParaView4/ParaViewCore/VTKExtensions/Default

git diff vtkPEnSightReader.cxx > ~/vtkPEnSightReader.cxx.diff

>> pwd
/projects/viz/ParaView-Distribution/ParaView/4.1.0-alan/ParaView4/VTK/IO/EnSight
redsky-login3:EnSight$ git diff vtkEnSightReader.cxx > ~/vtkEnSightReader.cxx.diff

Bug and dataset provided by Georg Hammerl (Thanks!)

Tags

No tags attached.

Project

Sandia

Topic Name

14238-fix-ensight-crash

Type

crash

Attached Files

bug-14238-test-dataset.tar.gz [^] (1,019 bytes) 2013-08-20 15:18

vtkEnSightReader.cxx.diff [^] (389 bytes) 2013-08-20 15:19 [Show Content] [Hide Content]

diff --git a/IO/EnSight/vtkEnSightReader.cxx b/IO/EnSight/vtkEnSightReader.cxx
index 3fb5f48..f86bd4a 100644
--- a/IO/EnSight/vtkEnSightReader.cxx
+++ b/IO/EnSight/vtkEnSightReader.cxx
@@ -1306,7 +1306,6 @@ int vtkEnSightReader::ReadCaseFileFile(char* line)
 
     filenameNums->Delete();
     numSteps->Delete();
-    lineRead = this->ReadNextDataLine(line);
     }
 
   return lineRead;

vtkPEnSightReader.cxx.diff [^] (490 bytes) 2013-08-20 15:19 [Show Content] [Hide Content]

diff --git a/ParaViewCore/VTKExtensions/Default/vtkPEnSightReader.cxx b/ParaViewCore/VTKExtensions/Default/vtkPEnSightReader.cxx
index 9484ce9..2c2ea37 100644
--- a/ParaViewCore/VTKExtensions/Default/vtkPEnSightReader.cxx
+++ b/ParaViewCore/VTKExtensions/Default/vtkPEnSightReader.cxx
@@ -1353,7 +1353,6 @@ int vtkPEnSightReader::ReadCaseFileFile(char* line)
 
     filenameNums->Delete();
     numSteps->Delete();
-    lineRead = this->ReadNextDataLine(line);
     }
 
   return lineRead;

Relationships

Notes
(0031490) Alan Scott (manager) 2013-08-20 15:20	Please review patch, and apply.

(0031537) Kyle Lutz (viewer) 2013-09-04 11:12	Merge topic '14238-fix-ensight-crash' into next 6ea35af Fix crash in EnSight reader Gerrit topic: http://review.source.kitware.com/#/t/3208/ [^]

(0031538) Kyle Lutz (viewer) 2013-09-04 11:13	Patch applied. Verified ParaView successfully opens the attached data set.

(0031548) Utkarsh Ayachit (administrator) 2013-09-09 12:08	14238-fix-ensight-crash (VTK) add_cosmo_reader find-data (VTK) fix-python-cmake-rules fix-warnings (VTK) forward-to-vtk-master (VTK) vtkweb-integration

(0031597) Alan Scott (manager) 2013-09-18 13:23	Tested local server, master, Linux.

Issue History
Date Modified	Username	Field	Change
2013-08-20 15:14	Alan Scott	New Issue
2013-08-20 15:18	Alan Scott	File Added: bug-14238-test-dataset.tar.gz
2013-08-20 15:19	Alan Scott	File Added: vtkEnSightReader.cxx.diff
2013-08-20 15:19	Alan Scott	File Added: vtkPEnSightReader.cxx.diff
2013-08-20 15:20	Alan Scott	Description Updated
2013-08-20 15:20	Alan Scott	Note Added: 0031490
2013-08-20 15:20	Alan Scott	Assigned To	=> Utkarsh Ayachit
2013-08-20 15:20	Alan Scott	Status	backlog => todo
2013-08-23 15:54	Utkarsh Ayachit	Assigned To	Utkarsh Ayachit => Kyle Lutz
2013-08-23 17:09	Utkarsh Ayachit	Target Version	=> 4.1
2013-09-04 11:12	Kyle Lutz	Topic Name	=> 14238-fix-ensight-crash
2013-09-04 11:12	Kyle Lutz	Note Added: 0031537
2013-09-04 11:12	Kyle Lutz	Status	todo => gatekeeper review
2013-09-04 11:12	Kyle Lutz	Resolution	open => fixed
2013-09-04 11:13	Kyle Lutz	Note Added: 0031538
2013-09-09 12:07	Utkarsh Ayachit	Fixed in Version	=> git-master
2013-09-09 12:08	Utkarsh Ayachit	Status	gatekeeper review => customer review
2013-09-09 12:08	Utkarsh Ayachit	Note Added: 0031548
2013-09-18 13:23	Alan Scott	Note Added: 0031597
2013-09-18 13:23	Alan Scott	Status	customer review => closed
2013-11-01 13:18	Utkarsh Ayachit	Fixed in Version	git-master => 4.1
2015-01-09 13:46	Kyle Lutz	Source_changeset_attached	=> VTK master cac24ae3
2015-01-11 08:23	Kyle Lutz	Source_changeset_attached	=> ParaView master 6ea35afd