View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0014279ParaView(No Category)public2013-09-16 13:072015-01-11 08:16
ReporterUtkarsh Ayachit 
Assigned ToUtkarsh Ayachit 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version4.0 
Target Version4.2Fixed in Version4.2 
Summary0014279: Glyph filter producing different results on OsX and Windows.
DescriptionCheck the attached images produces on OsX and Windows using data in Archive.zip (check with Utkarsh for the dataset).
TagsNo tags attached.
ProjectKitware
Topic Name14279_fix_rand_on_windows_attempt_2
Typeincorrect functionality
Attached Filespng file icon Windows_401.png [^] (52,907 bytes) 2013-09-16 13:07


png file icon OSX_401.png [^] (74,905 bytes) 2013-09-16 13:08

 Relationships
has duplicate 0014923closedUtkarsh Ayachit Illustration of glyphs 

  Notes
(0033177)
Utkarsh Ayachit (administrator)
2014-08-02 17:51

 commit 340d1bae94100b8f459680ca8d0c15fbab0e8e1d
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Sat Aug 2 17:48:37 2014 -0400

    BUG 0014279. Fix random glyphs on Windows.
    
    BUG 0014279 was encountered because the code that used rand() didn't not
    take into consideration that the int value returned by rand() may be
    less than the number of point ids in the dataset. On Windows, is was
    indeed limited to 32767 (on unixes, it wasn't that low). Thus resulted
    in the rand point ids selected being limited to that range.
    Fixed that.
    
    Change-Id: Ifd0e13cdba8404776a2388e2c5c3f68c6889a8ca
(0033178)
Utkarsh Ayachit (administrator)
2014-08-02 17:54

 Alan, you can test this out without the actual data by simply creating a large dataset with more than 32767 points e.g. Wavelet with extents 0, 64, 0, 64, 0, 64.
(0033180)
Utkarsh Ayachit (administrator)
2014-08-04 10:12

 SUMMARY
---------------------------------------------
Topics merged into master:
(VTK) 14279_glyph_filter
(VTK) fix_invalid_socket_check
(0033181)
Utkarsh Ayachit (administrator)
2014-08-04 10:13

 Alan,

This Glyph filter was entirely revamped. However this old version of the filter is still available as "Legacy Glyph". To test this fix, you should use that filter instead of the "Glyph".
(0033253)
Utkarsh Ayachit (administrator)
2014-08-19 11:00

 commit 069f1024a6807380b43ead6cf0e9e97bdf92cf01
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Tue Aug 19 10:58:31 2014 -0400

    BUG 0014279. Fix random glyphs on Windows.
    
    BUG 0014279 was encountered because the code that used rand() didn't not
    take into consideration that the int value returned by rand() may be
    less than the number of point ids in the dataset. On Windows, is was
    indeed limited to 32767 (on unixes, it wasn't that low). Thus resulted
    in the rand point ids selected being limited to that range.
    Fixed that.
    
    Change-Id: Ifd0e13cdba8404776a2388e2c5c3f68c6889a8ca
(0033274)
Utkarsh Ayachit (administrator)
2014-08-20 08:45

 SUMMARY
---------------------------------------------
Topics merged into master:
        14279_fix_rand_on_windows_attempt_2
        14813_fix_mode_shapes_range
        catalyst-updates


---------------------------------------------
Topics reverted from next:
  catalyst-script-plugin-client
(0033779)
Alan Scott (manager)
2014-11-06 20:35

 Tested as per Utkarsh's directions below. Tested Linux, master, local server.

 Issue History
Date Modified Username Field Change
2013-09-16 13:07 Utkarsh Ayachit New Issue
2013-09-16 13:07 Utkarsh Ayachit File Added: Windows_401.png
2013-09-16 13:08 Utkarsh Ayachit File Added: OSX_401.png
2013-09-16 13:08 Utkarsh Ayachit Target Version => 4.1
2014-02-07 21:47 Utkarsh Ayachit Target Version 4.1 => 4.2
2014-06-08 17:33 Utkarsh Ayachit Assigned To => George Zagaris
2014-06-08 17:33 Utkarsh Ayachit Note Added: 0032779
2014-07-05 21:25 Utkarsh Ayachit Assigned To George Zagaris => Cory Quammen
2014-07-22 22:24 Utkarsh Ayachit Assigned To Cory Quammen => Utkarsh Ayachit
2014-07-31 13:08 Utkarsh Ayachit Status backlog => todo
2014-08-01 20:22 Utkarsh Ayachit Note Deleted: 0032779
2014-08-02 17:51 Utkarsh Ayachit Topic Name => 14279_fix_rand_on_windows
2014-08-02 17:51 Utkarsh Ayachit Note Added: 0033177
2014-08-02 17:51 Utkarsh Ayachit Status todo => gatekeeper review
2014-08-02 17:51 Utkarsh Ayachit Fixed in Version => git-next
2014-08-02 17:51 Utkarsh Ayachit Resolution open => fixed
2014-08-02 17:54 Utkarsh Ayachit Note Added: 0033178
2014-08-04 10:12 Utkarsh Ayachit Fixed in Version git-next => git-master
2014-08-04 10:12 Utkarsh Ayachit Status gatekeeper review => customer review
2014-08-04 10:12 Utkarsh Ayachit Note Added: 0033180
2014-08-04 10:13 Utkarsh Ayachit Note Added: 0033181
2014-08-13 11:17 Utkarsh Ayachit Relationship added has duplicate 0014923
2014-08-19 11:00 Utkarsh Ayachit Status customer review => todo
2014-08-19 11:00 Utkarsh Ayachit Topic Name 14279_fix_rand_on_windows => 14279_fix_rand_on_windows_attempt_2
2014-08-19 11:00 Utkarsh Ayachit Note Added: 0033253
2014-08-19 11:00 Utkarsh Ayachit Status todo => gatekeeper review
2014-08-20 08:45 Utkarsh Ayachit Status gatekeeper review => customer review
2014-08-20 08:45 Utkarsh Ayachit Note Added: 0033274
2014-08-29 10:59 Utkarsh Ayachit Fixed in Version git-master => 4.2
2014-11-06 20:35 Alan Scott Note Added: 0033779
2014-11-06 20:35 Alan Scott Status customer review => closed
2015-01-11 08:16 Utkarsh Ayachit Source_changeset_attached => ParaView master 19b0565f
2015-01-11 08:16 Utkarsh Ayachit Source_changeset_attached => ParaView master 069f1024

Copyright © 2000 - 2018 MantisBT Team