View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003934ParaView(No Category)public2006-10-12 08:212007-08-14 09:02
ReporterKen Moreland 
Assigned ToClinton Stimpson 
PrioritynormalSeverityfeatureReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0003934: Specular Highlights
DescriptionI think it would be better if ParaView's display properties allowed adding specular highlights. Partially because specular highlights can help define a curvy surface, but mostly to ramp up the glitz factor.

Specular highlights can be efficiently defined with three parameters: A specular highlight intensity (a slider that goes from 0 to 1 or a checkbox that toggles between the two), the "specular power" variable that defines the size of the highlight (generally between 0 and 128), and a checkbox to determine if the specular highlight should be white (plastic-like) or follow the diffuse color (metal-like). These parameters are fed into the SetSpecular, SetSpecularPower, and SetSpecularColor methods, respectively, of vtkProperty.
TagsNo tags attached.
Project
Topic Name
Type
Attached Files

 Relationships

  Notes
(0005955)
Clinton Stimpson (developer)
2006-12-12 12:45

 I had to expose SpecularPower and SpecularColor in the SM so I could modify those parameters.

/cvsroot/ParaView3/ParaView3/Qt/Components/pqDisplayProxyEditor.cxx,v <-- pqDisplayProxyEditor.cxx
new revision: 1.14; previous revision: 1.13
/cvsroot/ParaView3/ParaView3/Qt/Components/pqDisplayProxyEditor.h,v <-- pqDisplayProxyEditor.h
new revision: 1.10; previous revision: 1.9
/cvsroot/ParaView3/ParaView3/Qt/Components/Resources/UI/pqDisplayProxyEditor.ui,v <-- pqDisplayProxyEditor.ui
new revision: 1.8; previous revision: 1.7

Try it out. We may need to adjust the UI a bit.
(0005996)
Ken Moreland (manager)
2006-12-18 19:13

 It's pretty good, but there are a few issues.

If you have an object that has specular highlighting on and then create a new filter with that as input, the GUI says that the new object has specular lighting on but it clearly is not. Clicking "Specular Lighting" off and on fixes the problem.

The "Specular White" option has some problems. If you turn on Specular Lighting and Specular White and then change the color, the specular highlights are no longer white.

Now that I look at the GUI, "Specular Power" seems confusing. Perhaps we could change it to "Specular Focus".

Could we add a "Specular Intensity" parameter that ranged between 0 and 1 to give the intensity of the highlight. It should default to 1.
(0006040)
Clinton Stimpson (developer)
2006-12-21 18:20
Fixed most of the issues.

The default value of 0 instead of 1 is set by the server manager. Easily changed in the SM XML.
When changing the color, the specular color seems to be changed under the covers beyond my control.

/cvsroot/ParaView3/ParaView3/Qt/Components/pqDisplayProxyEditor.cxx,v <-- pqDisplayProxyEditor.cxx
new revision: 1.15; previous revision: 1.14
/cvsroot/ParaView3/ParaView3/Qt/Components/pqDisplayProxyEditor.h,v <-- pqDisplayProxyEditor.h
new revision: 1.11; previous revision: 1.10
/cvsroot/ParaView3/ParaView3/Qt/Components/Resources/UI/pqDisplayProxyEditor.ui,v <-- pqDisplayProxyEditor.ui
new revision: 1.9; previous revision: 1.8
(0006041)
Ken Moreland (manager)
2006-12-21 18:23

 The color changing is probably happening because a color changes causes vtkProperty::SetColor to be called. The SetColor method sets the ambient, diffuse, and specular colors all to the given color.

The problem should be resolved if a color changes calls SetDiffuse and SetAmbient explicitly instead of SetColor.
(0006551)
Ken Moreland (manager)
2007-02-23 10:51

 This is now fixed.

/cvsroot/ParaView3/ParaView3/Qt/Components/pqDisplayProxyEditor.cxx,v <-- pqDisplayProxyEditor.cxx
new revision: 1.18; previous revision: 1.17
/cvsroot/ParaView3/ParaView3/Qt/Components/Resources/UI/pqDisplayProxyEditor.ui,v <-- pqDisplayProxyEditor.ui
new revision: 1.12; previous revision: 1.11
/cvsroot/ParaView3/ParaView3/Servers/ServerManager/Resources/rendering.xml,v <-- rendering.xml
new revision: 1.137; previous revision: 1.136
(0007345)
Utkarsh Ayachit (administrator)
2007-04-17 10:29

 As per BUG 0004883, the GUI is now hidden. Will be unhidden (with additional fixes) in 3.2.
(0008446)
Ken Moreland (manager)
2007-08-14 09:02

 Coming full circle, the GUI has been added back in and is now working correctly.

 Issue History
Date Modified Username Field Change
2007-08-13 15:15 Berk Geveci Status backlog => @80@
2007-08-13 15:15 Berk Geveci Resolution reopened => fixed
2007-08-14 09:02 Ken Moreland Status @80@ => closed
2007-08-14 09:02 Ken Moreland Note Added: 0008446
2011-06-16 13:10 Zack Galbreath Category => (No Category)

Copyright © 2000 - 2018 MantisBT Team