View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0004830ParaView(No Category)public2007-04-10 10:002007-05-07 14:53
ReporterDavid Karelitz 
Assigned ToUtkarsh Ayachit 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0004830: Toolbar Timestep Spinbox should not change timestep value as you type
DescriptionThe toolbar timestep spinbox currently changes timesteps as you type (type in 36 and it goes to timestep 3 and then 36). This will not work for large data where it takes minutes to load a timestep. It should go to the timestep when enter/return/tab is pressed or it loses focus.
TagsNo tags attached.
Project
Topic Name
Type
Attached Files

 Relationships

  Notes
(0007230)
Utkarsh Ayachit (administrator)
2007-04-10 15:50

 Current time is no longer pushed immediately, until editing is "finished".

/cvsroot/ParaView3/ParaView3/Qt/Components/pqAnimationPanel.cxx,v <-- pqAnimationPanel.cxx
new revision: 1.28; previous revision: 1.27
/cvsroot/ParaView3/ParaView3/Qt/Components/pqAnimationPanel.h,v <-- pqAnimationPanel.h
new revision: 1.8; previous revision: 1.7
(0007320)
Ken Moreland (manager)
2007-04-16 11:48

 I'm still seeing this problem. I've tried on Windows, Mac, and X11.
(0007329)

2007-04-16 15:43

 Oops, I misread the bug, I only fixed for the line edit, not the spin boxes. Fixed for the spin boxes. However, now one must press "Enter" or take focus away even after changing the index by using the up-down arrows.


Checking for path: /cvsroot/ParaView3/ParaView3/Qt/Components
Unrestricted user: utkarsh
/cvsroot/ParaView3/ParaView3/Qt/Components/pqAnimationPanel.cxx,v <-- pqAnimationPanel.cxx
new revision: 1.29; previous revision: 1.28
/cvsroot/ParaView3/ParaView3/Qt/Components/pqAnimationPanel.h,v <-- pqAnimationPanel.h
new revision: 1.9; previous revision: 1.8
(0007330)
Utkarsh Ayachit (administrator)
2007-04-16 15:44

 Oops, I misread the bug. I only fixed for the line edit, not for the spin boxes. Fixed the spin boxes. However, now one must press enter or take focus away even after changing the index by using the up-down arrows.

/cvsroot/ParaView3/ParaView3/Qt/Components/pqAnimationPanel.cxx,v <-- pqAnimationPanel.cxx
new revision: 1.29; previous revision: 1.28
/cvsroot/ParaView3/ParaView3/Qt/Components/pqAnimationPanel.h,v <-- pqAnimationPanel.h
new revision: 1.9; previous revision: 1.8
(0007339)
Ken Moreland (manager)
2007-04-17 09:31

 Is it a fundamental "feature" of the spin box that you cannot have an update after an arrow is pressed without also updating every time a digit is entered? The proper behavior is to require the focus lost when typing a number but to update immediatly when an arrow button is pressed.

If this mode is impossible, we should get rid of the arrows althogether (change the widget to a line edit). The spin box arrows have the same functionality as the step forward/back buttons on the VCR toolbar, so they are actually pretty redundant.
(0007354)
Ken Moreland (manager)
2007-04-17 13:48

 Replace the spin box with a line edit (to get rid of the up/down arrows).
(0007359)

2007-04-17 14:47

 Added a new subclass of QSpinBox which fires editingFinished signal when the value is changed by stepping (up/down).

/cvsroot/ParaView3/ParaView3/Qt/Components/pqAnimationPanel.cxx,v <-- pqAnimationPanel.cxxnew revision: 1.30; previous revision: 1.29
/cvsroot/ParaView3/ParaView3/Qt/Components/Resources/UI/pqAnimationPanel.ui,v <-- pqAnimationPanel.ui
new revision: 1.12; previous revision: 1.11
/cvsroot/ParaView3/ParaView3/Qt/Widgets/CMakeLists.txt,v <-- CMakeLists.txt
new revision: 1.20; previous revision: 1.19
/cvsroot/ParaView3/ParaView3/Qt/Widgets/pqSpinBox.cxx,v <-- pqSpinBox.cxx
initial revision: 1.1
/cvsroot/ParaView3/ParaView3/Qt/Widgets/pqSpinBox.h,v <-- pqSpinBox.h
initial revision: 1.1
(0007360)
Utkarsh Ayachit (administrator)
2007-04-17 14:48

 Added a new subclass of QSpinBox which fires editingFinished signal when the value is changed by stepping (up/down).

/cvsroot/ParaView3/ParaView3/Qt/Components/pqAnimationPanel.cxx,v <-- pqAnimationPanel.cxxnew revision: 1.30; previous revision: 1.29
/cvsroot/ParaView3/ParaView3/Qt/Components/Resources/UI/pqAnimationPanel.ui,v <-- pqAnimationPanel.ui
new revision: 1.12; previous revision: 1.11
/cvsroot/ParaView3/ParaView3/Qt/Widgets/CMakeLists.txt,v <-- CMakeLists.txt
new revision: 1.20; previous revision: 1.19
/cvsroot/ParaView3/ParaView3/Qt/Widgets/pqSpinBox.cxx,v <-- pqSpinBox.cxx
initial revision: 1.1
/cvsroot/ParaView3/ParaView3/Qt/Widgets/pqSpinBox.h,v <-- pqSpinBox.h
initial revision: 1.1
(0007368)
Ken Moreland (manager)
2007-04-18 12:44

 Wow. We resolved that we should get rid of the arrows because we could not get them to work, and an hour later Utkarsh has them working. Good show.

 Issue History
Date Modified Username Field Change
2011-06-16 13:10 Zack Galbreath Category => (No Category)

Copyright © 2000 - 2018 MantisBT Team