| View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0008244 | ParaView | (No Category) | public | 2008-12-05 15:48 | 2009-05-13 13:47 | ||||
| Reporter | Zhanping Liu | ||||||||
| Assigned To | Zhanping Liu | ||||||||
| Priority | normal | Severity | minor | Reproducibility | have not tried | ||||
| Status | closed | Resolution | open | ||||||
| Platform | OS | OS Version | |||||||
| Product Version | |||||||||
| Target Version | 3.6 | Fixed in Version | |||||||
| Summary | 0008244: a fix to vtkEnSightReader.cxx from Hank | ||||||||
| Description | Excerpted from Hank's e-mail " Hello VTK Developers! I am attaching a patched version of vtkEnSightReader.cxx. I have a dearth of test data, so hopefully Kitware already does some good regression testing for this file format. The key issue was the way EnSight case files use wildcards. If you are replacing file.** with 2, it becomes file.02. But if you are replacing with file.* with 200, then, in the old version, it becomes fil200, where the attached version will create file.200. Slightly complicating the fix was that the strings passed into the ReplaceWildcards routine were not sized properly for wildcard expansion. The bottom line is that I think I did everything right and it works for me, but I certainly wouldn't mind if someone puts it through the paces. Finally, there appears to be a similar issue in vtkGenericEnSightReader.cxx. Since I have *no* test data for that reader, I'm not going to attempt a blind fix. Best regards, Hank " | ||||||||
| Tags | No tags attached. | ||||||||
| Project | |||||||||
| Topic Name | |||||||||
| Type | |||||||||
| Attached Files |  vtkEnSightReader_Hank_LLNL.cxx [^] (68,959 bytes) 2008-12-05 15:48 | ||||||||
| Relationships | |
| Relationships |
| Notes | |
|
(0014307) Zhanping Liu (developer) 2008-12-08 12:14 |
After careful checking, I am sure the fix suggested by Hank (on May 28, 2008) for vtkEnSightReader.cxx (based on version 1.77, April, 29, 2008) has been applied to / reflected in all the later versions (beginning from version 1.78, July 29, 2008). Respecting this fix, some sdditional but minor changes were made to vtkEnSightReader::ReplaceWildcards(......) (1) in version 1.79 on July 30, 2008 to remove several un-referenced local variables. (2) in version 1.81 on Aug 11, 2008 to add static_cast<int> for strlen(). Thus Report 0008244 can now be closed Thanks for Hank's fix. |
| Notes |
| Issue History | |||
| Date Modified | Username | Field | Change |
| 2008-12-05 15:48 | Zhanping Liu | New Issue | |
| 2008-12-05 15:48 | Zhanping Liu | File Added: vtkEnSightReader_Hank_LLNL.cxx | |
| 2008-12-05 15:49 | Zhanping Liu | Status | backlog => tabled |
| 2008-12-05 15:49 | Zhanping Liu | Assigned To | => Zhanping Liu |
| 2008-12-08 12:14 | Zhanping Liu | Note Added: 0014307 | |
| 2008-12-08 12:15 | Zhanping Liu | Status | tabled => closed |
| 2009-05-13 13:47 | Utkarsh Ayachit | Target Version | => 3.6 |
| 2011-06-16 13:10 | Zack Galbreath | Category | => (No Category) |
| Issue History |
| Copyright © 2000 - 2018 MantisBT Team |