Coding Standard Violations

From ParaQ Wiki
Jump to navigationJump to search

Overview

This documents just lists a few coding violations to help clean them up.

Convention: Names of local variables, arguments must being with a lower case letter

  • void pqMainWindow::setServer(pqServer* Server), void pqMainWindow::onFileNew(pqServer* Server) etc...
  • void pqSMAdaptor::linkPropertyTo(vtkSMProxy* Proxy, vtkSMProperty* Property, int Index, ...

Convention: Use this-> when accessing class members.

  • In pqMainWindow::onServerConnect(), pqMainWindow::onServerDisconnect() : setServer(0) instead of this->setServer(0) etc...

Convention: No global functions.

  • Qt/Testing/pqImageComparison.h|.cxx
  • Qt/Widgets/pqParts.h|.cxx
  • Qt/Widgets/pqXMLUtil.h|.cxx
  • Qt/Widgets/pqSMMultiView.h|cxx